Skip to contentSkip to conversation

soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 7, 2022 – Apr 5, 2022

Subsystems (4)
Arm Qualcomm mailing list Kernel janitors Qualcomm audio (ASoC) drivers SoundWire
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()

The logical AND && is supposed to be bitwise AND & so it will sometimes print "connected" instead of "disconnected".

Fixes 74e79da9fd46 ("soundwire: qcom: add runtime pm support")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/soundwire/qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soundwire/qcom.c +1 -1
index f613a41c278a..6ca041f9e449 100644
@@ -1452,7 +1452,7 @@ static bool swrm_wait_for_frame_gen_enabled(struct qcom_swrm_ctrl *swrm)
 	} while (retry--);
 
 	dev_err(swrm->dev, "%s: link status not %s\n", __func__,
-		comp_sts && SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
+		comp_sts & SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
 
 	return false;
 }
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 2 lines · Dan Carpenter

The logical AND && is supposed to be bitwise AND & so it will sometimes print "connected" instead of "disconnected".

Applied, thanks

Signature · 1 line
~Vinod