drm/msm/adreno: fix cast in adreno_get_param()
Subsystems (5)
PATCH 1/1 drm/msm/adreno: fix cast in adreno_get_param()
These casts need to happen before the shift. The only time it would matter would be if "rev.core" is >= 128. In that case the sign bit would be extended and we do not want that.
--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +4 -4
@@ -244,10 +244,10 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx, *value = !adreno_is_a650_family (adreno_gpu) ?0x100000 :0 ;return 0 ;case MSM_PARAM_CHIP_ID : - *value = (uint64_t ) adreno_gpu->rev.patchid | - (uint64_t ) (adreno_gpu->rev.minor <<8 ) | - (uint64_t ) (adreno_gpu->rev.major <<16 ) | - (uint64_t ) (adreno_gpu->rev.core <<24 ); + *value = (uint64_t )adreno_gpu->rev.patchid | + ((uint64_t )adreno_gpu->rev.minor <<8 ) | + ((uint64_t )adreno_gpu->rev.major <<16 ) | + ((uint64_t )adreno_gpu->rev.core <<24 );if (!adreno_gpu->info->revn) *value |= ((uint64_t ) adreno_gpu->speedbin) <<32 ;return 0 ;
Signature · 1 line
2.20.1
Quoted 19 lines · Dan Carpenter
These casts need to happen before the shift. The only time it would matter would be if "rev.core" is >= 128. In that case the sign bit would be extended and we do not want that.
Fixes afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/msm/adreno/adreno_gpu.c +0
-1@@ -244,10 +244,10 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx, *value = !adreno_is_a650_family (adreno_gpu) ?0x100000 :0 ;return 0 ;case MSM_PARAM_CHIP_ID : - *value = (uint64_t) adreno_gpu->rev.patchid |
drivers/gpu/drm/msm/adreno/adreno_gpu.c int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx, · line 253
Quoted 10 lines
drivers/gpu/drm/msm/adreno/adreno_gpu.c +4
-3- (uint64_t ) (adreno_gpu->rev.minor <<8 ) | - (uint64_t ) (adreno_gpu->rev.major <<16 ) | - (uint64_t ) (adreno_gpu->rev.core <<24 ); + *value = (uint64_t )adreno_gpu->rev.patchid | + ((uint64_t )adreno_gpu->rev.minor <<8 ) | + ((uint64_t )adreno_gpu->rev.major <<16 ) | + ((uint64_t )adreno_gpu->rev.core <<24 );if (!adreno_gpu->info->revn) *value |= ((uint64_t ) adreno_gpu->speedbin) <<32 ;return 0 ;
-Akhil
Quoting Dan Carpenter (2022-03-07 05:31:05)
Quoted 7 lines
These casts need to happen before the shift. The only time it would matter would be if "rev.core" is >= 128. In that case the sign bit would be extended and we do not want that.
Fixes afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace")Signed-off-by Dan Carpenter <[email protected]>---