Skip to contentSkip to conversation

gpio: sim: Declare gpio_sim_hog_config_item_ops static

PATCH Applied Andy Shevchenko 2 participants 2 messages Mar 7, 2022 – Mar 8, 2022 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: sim: Declare gpio_sim_hog_config_item_ops static

Compiler is not happy:

warning: symbol 'gpio_sim_hog_config_item_ops' was not declared. Should it be static?

Fixes cb8c474e79be ("gpio: sim: new testing module")
---
 drivers/gpio/gpio-sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-sim.c +1 -1
index 153fe79e1bf3..bb9bb595c1a8 100644
@@ -1322,7 +1322,7 @@ static void gpio_sim_hog_config_item_release(struct config_item *item)
 	kfree(hog);
 }
 
-struct configfs_item_operations gpio_sim_hog_config_item_ops = {
+static struct configfs_item_operations gpio_sim_hog_config_item_ops = {
 	.release	= gpio_sim_hog_config_item_release,
 };
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 25 lines · Andy Shevchenko

Compiler is not happy:

warning: symbol 'gpio_sim_hog_config_item_ops' was not declared. Should it be static?

Fixes cb8c474e79be ("gpio: sim: new testing module")
---
 drivers/gpio/gpio-sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-sim.c +1 -2
index 153fe79e1bf3..bb9bb595c1a8 100644
@@ -1322,7 +1322,7 @@ static void gpio_sim_hog_config_item_release(struct config_item *item)
        kfree(hog);
 }
 
-struct configfs_item_operations gpio_sim_hog_config_item_ops = {
+static struct configfs_item_operations gpio_sim_hog_config_item_ops = {
        .release        = gpio_sim_hog_config_item_release,
 };
 
--
Quoted 2 lines

2.34.1

Queued for fixes, thanks!

Bart