remoteproc: qcom_q6v5_mss: Fix some leaks in q6v5_alloc_memory_region
Subsystems (2)
PATCH 1/1 remoteproc: qcom_q6v5_mss: Fix some leaks in q6v5_alloc_memory_region
The device_node pointer is returned by of_parse_phandle() or of_get_child_by_name() with refcount incremented. We should use of_node_put() on it when done.
This function only call of_node_put(node) when of_address_to_resource succeeds, missing error cases.
Fixes 278d744c46fd ("remoteproc: qcom: Fix potential device node leaks")
Fixes 051fb70fd4ea ("remoteproc: qcom: Driver for the self-authenticating Hexagon v5")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/remoteproc/qcom_q6v5_mss.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/remoteproc/qcom_q6v5_mss.c +6 -3
@@ -1809,15 +1809,17 @@ static int q6v5_alloc_memory_region(struct q6v5 *qproc)if (!child) node =of_parse_phandle (qproc->dev->of_node,"memory-region" ,0 ); -else +else { node =of_parse_phandle (child,"memory-region" ,0 ); +of_node_put (child); + } ret =of_address_to_resource (node,0 , &r); +of_node_put (node);if (ret) {dev_err (qproc->dev,"unable to resolve mba region\n" );return ret; } -of_node_put (node); qproc->mba_phys = r.start; qproc->mba_size =resource_size (&r);
@@ -1828,14 +1830,15 @@ static int q6v5_alloc_memory_region(struct q6v5 *qproc) }else { child =of_get_child_by_name (qproc->dev->of_node,"mpss" ); node =of_parse_phandle (child,"memory-region" ,0 ); +of_node_put (child); } ret =of_address_to_resource (node,0 , &r); +of_node_put (node);if (ret) {dev_err (qproc->dev,"unable to resolve mpss region\n" );return ret; } -of_node_put (node); qproc->mpss_phys = qproc->mpss_reloc = r.start; qproc->mpss_size =resource_size (&r);
Signature · 1 line
2.17.1