Skip to contentSkip to conversation

soc: qcom: smsm: Fix missing of_node_put() in smsm_parse_ipc

PATCH New Miaoqian Lin 1 participant 1 message Mar 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: smsm: Fix missing of_node_put() in smsm_parse_ipc

The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done.

Fixes c97c4090ff72 ("soc: qcom: smsm: Add driver for Qualcomm SMSM")
---
 drivers/soc/qcom/smsm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/qcom/smsm.c +1 -0
index ef15d014c03a..9df9bba242f3 100644
@@ -374,6 +374,7 @@ static int smsm_parse_ipc(struct qcom_smsm *smsm, unsigned host_id)
 		return 0;
 
 	host->ipc_regmap = syscon_node_to_regmap(syscon);
+	of_node_put(syscon);
 	if (IS_ERR(host->ipc_regmap))
 		return PTR_ERR(host->ipc_regmap);
 
Signature · 1 line
2.17.1