Ingenic DRM bridge_atomic_enable proposal
Subsystems (6)
v2 cover Ingenic DRM bridge_atomic_enable proposal
Hello, this is the v2 for my set of patches :
- use dev_err_probe() instead of dev_err() in the newvision panel driver probe function
- add bindings documentation for the Leadtek ltk035c5444t
Cheers - Christophe
------------------------
Hello, this is a set of patches to allow the upstreaming of the NV3052C panel found in the Anbernic RG350M mips gaming handheld.
It was never upstreamed so far due to a longstanding graphical bug, which I propose to solve by introducing ingenic_drm_bridge_atomic_enable in the drm driver so the CRTC can be enabled after the panel itself slept out, and not before as it used to.
After the drm change, 2 of the existing panels have to be modified accordingly to introduce missing .enable and .disable in their code.
Christophe Branchereau (4):
drm/ingenic : add ingenic_drm_bridge_atomic_enable drm/panel: Add panel driver for NewVision NV3052C based LCDs drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and
.disable
dt-bindings: display/panel: Add Leadtek ltk035c5444t
.../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++ drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 23 +- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 +- .../gpu/drm/panel/panel-newvision-nv3052c.c | 497 ++++++++++++++++++ 7 files changed, 627 insertions(+), 12 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c
Signature · 1 line
2.34.1
PATCH v2 1/4 drm/ingenic : add ingenic_drm_bridge_atomic_enable
This allows the CRTC to be enabled after panels have slept out, and before their display is turned on, solving a graphical bug on the newvision nv3502c
--- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)
drivers/gpu/drm/ingenic/ingenic-drm-drv.c +13 -6
@@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct notifier_block *nb, } } +static void ingenic_drm_bridge_atomic_enable (struct drm_bridge *bridge, +struct drm_bridge_state *old_bridge_state) +{ +struct ingenic_drm *priv =drm_device_get_priv (bridge->dev); + +regmap_write (priv->map,JZ_REG_LCD_STATE ,0 ); + +regmap_update_bits (priv->map,JZ_REG_LCD_CTRL , +JZ_LCD_CTRL_ENABLE |JZ_LCD_CTRL_DISABLE , +JZ_LCD_CTRL_ENABLE ); +} +static void ingenic_drm_crtc_atomic_enable (struct drm_crtc *crtc,struct drm_atomic_state *state) {
@@ -237,17 +249,11 @@ static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,if (WARN_ON (IS_ERR (priv_state)))return ; -regmap_write (priv->map,JZ_REG_LCD_STATE ,0 ); -/* Set addresses of our DMA descriptor chains */ next_id = priv_state->use_palette ?HWDESC_PALETTE :0 ;regmap_write (priv->map,JZ_REG_LCD_DA0 ,dma_hwdesc_addr (priv, next_id));regmap_write (priv->map,JZ_REG_LCD_DA1 ,dma_hwdesc_addr (priv,1 )); -regmap_update_bits (priv->map,JZ_REG_LCD_CTRL , -JZ_LCD_CTRL_ENABLE |JZ_LCD_CTRL_DISABLE , -JZ_LCD_CTRL_ENABLE ); -drm_crtc_vblank_on (crtc); }
@@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs ingenic_drm_encoder_helper_funcs =static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { .attach = ingenic_drm_bridge_attach, + .atomic_enable = ingenic_drm_bridge_atomic_enable, .atomic_check = ingenic_drm_bridge_atomic_check, .atomic_reset = drm_atomic_helper_bridge_reset, .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
Signature · 1 line
2.34.1
PATCH v2 2/4 drm/panel: Add panel driver for NewVision NV3052C based LCDs
In reply to Christophe BranchereauThis driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console.
--- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-newvision-nv3052c.c | 497 ++++++++++++++++++ 3 files changed, 507 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c
drivers/gpu/drm/panel/Kconfig +9 -0
@@ -283,6 +283,15 @@ config DRM_PANEL_NEC_NL8048HL11 panel (found on the Zoom2/3/3630 SDP boards). To compile this driver as a module, choose M here. +config DRM_PANEL_NEWVISION_NV3052C + tristate "NewVision NV3052C RGB/SPI panel" + depends on OF && SPI + depends on BACKLIGHT_CLASS_DEVICE + select DRM_MIPI_DBI + help + Say Y here if you want to enable support for the panels built + around the NewVision NV3052C display controller. + config DRM_PANEL_NOVATEK_NT35510 tristate "Novatek NT35510 RGB panel driver" depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
@@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o +obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o
drivers/gpu/drm/panel/panel-newvision-nv3052c.c new file +497 -0
497 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v2 3/4 drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable
In reply to Christophe BranchereauFollowing the introduction of bridge_atomic_enable in the ingenic drm driver, the crtc is enabled between .prepare and .enable, if it exists.
Add it so the backlight is only enabled after the crtc is, to avoid graphical issues.
--- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 23 ++++++++++++-- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 31 ++++++++++++++++--- 2 files changed, 48 insertions(+), 6 deletions(-)
drivers/gpu/drm/panel/panel-abt-y030xx067a.c +21 -2
@@ -183,8 +183,6 @@ static int y030xx067a_prepare(struct drm_panel *panel) goto err_disable_regulator; } -msleep (120 ); -return 0 ; err_disable_regulator:
@@ -202,6 +200,25 @@ static int y030xx067a_unprepare(struct drm_panel *panel)return 0 ; } +static int y030xx067a_enable (struct drm_panel *panel) +{ +if (panel->backlight) { +/* Wait for the picture to be ready before enabling backlight */ +msleep (120 ); + } + +return 0 ; +} + +static int y030xx067a_disable (struct drm_panel *panel) +{ +struct y030xx067a *priv =to_y030xx067a (panel); + +regmap_clear_bits (priv->map,0x06 ,REG06_XPSAVE ); + +return 0 ; +} +static int y030xx067a_get_modes (struct drm_panel *panel,struct drm_connector *connector) {
@@ -239,6 +256,8 @@ static int y030xx067a_get_modes(struct drm_panel *panel,static const struct drm_panel_funcs y030xx067a_funcs = { .prepare = y030xx067a_prepare, .unprepare = y030xx067a_unprepare, + .enable = y030xx067a_enable, + .disable = y030xx067a_disable, .get_modes = y030xx067a_get_modes, };
drivers/gpu/drm/panel/panel-innolux-ej030na.c +27 -4
@@ -80,8 +80,6 @@ static const struct reg_sequence ej030na_init_sequence[] = { { 0x47, 0x08 }, { 0x48, 0x0f }, { 0x49, 0x0f }, - - { 0x2b, 0x01 }, };static int ej030na_prepare (struct drm_panel *panel)
@@ -109,8 +107,6 @@ static int ej030na_prepare(struct drm_panel *panel) goto err_disable_regulator; } -msleep (120 ); -return 0 ; err_disable_regulator:
@@ -128,6 +124,31 @@ static int ej030na_unprepare(struct drm_panel *panel)return 0 ; } +static int ej030na_enable (struct drm_panel *panel) +{ +struct ej030na *priv =to_ej030na (panel); + +/* standby off */ +regmap_write (priv->map,0x2b ,0x01 ); + +if (panel->backlight) { +/* Wait for the picture to be ready before enabling backlight */ +msleep (120 ); + } + +return 0 ; +} + +static int ej030na_disable (struct drm_panel *panel) +{ +struct ej030na *priv =to_ej030na (panel); + +/* standby on */ +regmap_write (priv->map,0x2b ,0x00 ); + +return 0 ; +} +static int ej030na_get_modes (struct drm_panel *panel,struct drm_connector *connector) {
@@ -165,6 +186,8 @@ static int ej030na_get_modes(struct drm_panel *panel,static const struct drm_panel_funcs ej030na_funcs = { .prepare = ej030na_prepare, .unprepare = ej030na_unprepare, + .enable = ej030na_enable, + .disable = ej030na_disable, .get_modes = ej030na_get_modes, };
Signature · 1 line
2.34.1
PATCH v2 4/4 dt-bindings: display/panel: Add Leadtek ltk035c5444t
In reply to Christophe BranchereauAdd binding for the leadtek ltk035c5444t, which is a 640x480 mipi-dbi over spi / 24-bit RGB panel based on the newvision NV03052C chipset.
It is found in the Anbernic RG350M mips handheld.
--- .../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml new file +59 -0
@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD panel + +maintainers: + - Paul Cercueil <[email protected]> + - Christophe Branchereau <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + const: leadtek,ltk035c5444t-spi + + backlight: true + port: true + power-supply: true + reg: true + reset-gpios: true + +required: + - compatible + - power-supply + - reset-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "leadtek,ltk035c5444t-spi"; + reg = <0>; + + spi-3wire; + spi-max-frequency = <3125000>; + + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>; + + backlight = <&backlight>; + power-supply = <&vcc>; + + port { + panel_input: endpoint { + remote-endpoint = <&panel_output>; + }; + }; + }; + };
Signature · 1 line
2.34.1
Re: [PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t
Quoted 11 lines · Christophe Branchereau
Add binding for the leadtek ltk035c5444t, which is a 640x480 mipi-dbi over spi / 24-bit RGB panel based on the newvision NV03052C chipset.
It is found in the Anbernic RG350M mips handheld.
Signed-off-by Christophe Branchereau <[email protected]>--- .../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
We have 18 SPI based panels already:
$ git grep -i 'spi.* {' Documentation/devicetree/bindings/display/panel/
Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: spi {
Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: spi {
Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: spi {
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: spi {
Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml: spi {
Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml: spi {
Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: spi {
Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml: spi {
Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: spi0 {
Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml: spi {
Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml: spi {
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml: spi {
Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: spi {
Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi {
Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: spi {Most except for the Samsung ones look like they'd fit in our definition of 'simple panels' which primarily means 1 supply.
So I think it is time for a panel-simple-spi.yaml binding to combine all these. But I'm not going to make the person adding the 19th case to do that, and this otherwise looks fine:
With one nit fixed below:
Quoted 16 lines
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml new file +9
-0@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD panel + +maintainers:
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml line 19
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml new file +10
-0+ - Paul Cercueil <[email protected]> + - Christophe Branchereau <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + const: leadtek,ltk035c5444t-spi
'-spi' is redundant, so drop.
Quoted 13 lines
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml new file +13
-0+ + backlight: true + port: true + power-supply: true + reg: true + reset-gpios: true + +required: + - compatible + - power-supply + - reset-gpios + +unevaluatedProperties: false
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml line 42
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml new file +10
-0+ +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "leadtek,ltk035c5444t-spi";
And update the example...
Quoted 21 lines
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml new file +17
-0+ reg = <0>; + + spi-3wire; + spi-max-frequency = <3125000>; + + reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>; + + backlight = <&backlight>; + power-supply = <&vcc>; + + port { + panel_input: endpoint { + remote-endpoint = <&panel_output>; + }; + }; + }; + };Signature · 1 line
2.34.1
Paul Cercueil
maintainerRe: [PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t
Hi Rob,
Quoted 52 lines · Rob Herring
Quoted 6 lines · Christophe Branchereau
Add binding for the leadtek ltk035c5444t, which is a 640x480 mipi-dbi over spi / 24-bit RGB panel based on the newvision NV03052C chipset.
It is found in the Anbernic RG350M mips handheld.
Quoted 7 lines
Signed-off-by Christophe Branchereau <[email protected]>---
.../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+)create mode 100644
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yamlWe have 18 SPI based panels already:
$ git grep -i 'spi.* {' Documentation/devicetree/bindings/display/panel/ Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: spi { Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: spi { Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: spi { Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: spi { Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml: spi { Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml: spi { Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: spi { Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml: spi { Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: spi0 { Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml: spi { Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml: spi { Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: spi { Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi { Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: spi {
Quoted 8 lines
Most except for the Samsung ones look like they'd fit in our definition of 'simple panels' which primarily means 1 supply.
So I think it is time for a
panel-simple-spi.yamlbinding to combine all these. But I'm not going to make the person adding the 19th case to do that, and this otherwise looks fine:Reviewed-by Rob Herring <[email protected]>
I actually thought you sent a patch for this already (I remember you talking about it last a binding for a new SPI panel has been added).
I will work on it next week - provided Cristophe's patch has been merged before.
Cheers,
-Paul
Quoted 83 lines
With one nit fixed below:
Quoted 22 lines
diff --git
a/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yamlb/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
new file mode 100644
index 000000000000..9b6f1810adab
---/dev/null
+++b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id:
http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD
panel
+
+maintainers:
+ - Paul Cercueil <[email protected]>
+ - Christophe Branchereau <[email protected]>Quoted 8 lines
+
+allOf:
+ - $ref: panel-common.yaml#
+ - $ref: /schemas/spi/spi-peripheral-props.yaml# +
+properties:
+ compatible:
+ const: leadtek,ltk035c5444t-spi'-spi' is redundant, so drop.
Quoted 22 lines
+
+ backlight: true + port: true + power-supply: true + reg: true + reset-gpios: true + +required: + - compatible + - power-supply + - reset-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 {Quoted 1 line
+ compatible = "leadtek,ltk035c5444t-spi";
And update the example...
Quoted 21 lines
+ reg = <0>;
+
+ spi-3wire;
+ spi-max-frequency = <3125000>;
+
+ reset-gpios = <&gpe 2GPIO_ACTIVE_LOW>;
+
+ backlight = <&backlight>;
+ power-supply = <&vcc>;
+
+ port {
+panel_input: endpoint {
+ remote-endpoint = <&panel_output>;
+ };
+ };
+ };
+ };
--
2.34.1
Rob Herring
maintainerRe: [PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t
Quoted 70 lines · Paul Cercueil
Hi Rob,
Quoted 65 lines · Rob Herring
Quoted 6 lines · Christophe Branchereau
Add binding for the leadtek ltk035c5444t, which is a 640x480 mipi-dbi over spi / 24-bit RGB panel based on the newvision NV03052C chipset.
It is found in the Anbernic RG350M mips handheld.
Quoted 7 lines
Signed-off-by Christophe Branchereau <[email protected]>---
.../panel/leadtek,ltk035c5444t-spi.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+)create mode 100644
Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yamlWe have 18 SPI based panels already:
$ git grep -i 'spi.* {' Documentation/devicetree/bindings/display/panel/ Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: spi { Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: spi { Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: spi { Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: spi { Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml: spi { Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml: spi { Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: spi { Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml: spi { Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: spi0 { Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml: spi { Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml: spi { Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml: spi { Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: spi { Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi { Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: spi {Most except for the Samsung ones look like they'd fit in our definition
of 'simple panels' which primarily means 1 supply.So I think it is time for a
panel-simple-spi.yamlbinding to combine all
these. But I'm not going to make the person adding the 19th case to do that, and this otherwise looks fine:
Quoted 4 lines
Quoted 1 line
Reviewed-by Rob Herring <[email protected]>I actually thought you sent a patch for this already (I remember you talking about it last a binding for a new SPI panel has been added).
It was just adding spi-peripheral-props.yaml reference that I sent.
Quoted 2 lines
I will work on it next week - provided Cristophe's patch has been merged before.
Thanks!
Rob