Skip to contentSkip to conversation

board: venice: add spl_board_loader_name

PATCH In review Tim Harvey 3 participants 3 messages Mar 8, 2022 – Apr 12, 2022

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 board: venice: add spl_board_loader_name

Implement spl_board_loader_name to provide more meaningful device names vs MMC1 and MMC2.

---
 board/gateworks/venice/spl.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
board/gateworks/venice/spl.c +14 -0
index 8b301570577c..b56e1b607d58 100644
@@ -301,3 +301,17 @@ int spl_board_boot_device(enum boot_device boot_dev_spl)
 		return BOOT_DEVICE_NONE;
 	}
 }
+
+const char *spl_board_loader_name(u32 boot_device)
+{
+	switch (boot_device) {
+	/* SDHC2 */
+	case BOOT_DEVICE_MMC1:
+		return "eMMC";
+	/* SDHC3 */
+	case BOOT_DEVICE_MMC2:
+		return "SD card";
+	default:
+		return NULL;
+	}
+}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines

Subject: [PATCH] board: venice: add spl_board_loader_name

Implement spl_board_loader_name to provide more meaningful device names vs MMC1 and MMC2.

Nice. Reviewed-by: Peng Fan <[email protected]>

Quoted 28 lines
---
 board/gateworks/venice/spl.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
board/gateworks/venice/spl.c +13 -1
index 8b301570577c..b56e1b607d58 100644
@@ -301,3 +301,17 @@ int spl_board_boot_device(enum boot_device
 boot_dev_spl)
 		return BOOT_DEVICE_NONE;
 	}
 }
+
+const char *spl_board_loader_name(u32 boot_device) {
+	switch (boot_device) {
+	/* SDHC2 */
+	case BOOT_DEVICE_MMC1:
+		return "eMMC";
+	/* SDHC3 */
+	case BOOT_DEVICE_MMC2:
+		return "SD card";
+	default:
+		return NULL;
+	}
+}
--

2.17.1

#2 lore raw

PATCH 1/1 board: venice: add spl_board_loader_name

In reply to Tim Harvey
Quoted 3 lines

Implement spl_board_loader_name to provide more meaningful device names vs MMC1 and MMC2.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================