Skip to contentSkip to conversation

board: gateworks venice: add support for GPY111 phy

PATCH In review Tim Harvey 3 participants 3 messages Mar 8, 2022 – Apr 12, 2022

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 board: gateworks venice: add support for GPY111 phy

The TI DP83867 phy has been replaced with the MaxLinear GPY111 phy due to part availability.

Add support for it by adding LED config and dt-prop based internal delay config tx-delay/rx-delay per PHY ID.

---
 board/gateworks/venice/venice.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
board/gateworks/venice/venice.c +16 -0
index 5334500ef6a7..425c69056da5 100644
@@ -63,6 +63,7 @@ static int setup_fec(void)
 int board_phy_config(struct phy_device *phydev)
 {
 	unsigned short val;
+	ofnode node;
 
 	switch (phydev->phy_id) {
 	case 0x2000a231: /* TI DP83867 GbE PHY */
@@ -73,6 +74,21 @@ int board_phy_config(struct phy_device *phydev)
 		val |= 0xb << 8; /* LED2(Green;Link/Act): blink for TX/RX act */
 		phy_write(phydev, MDIO_DEVAD_NONE, 24, val);
 		break;
+	case 0xd565a401: /* MaxLinear GPY111 */
+		puts("GPY111 ");
+		node = phy_get_ofnode(phydev);
+		if (ofnode_valid(node)) {
+			u32 rx_delay, tx_delay;
+
+			rx_delay = ofnode_read_u32_default(node, "rx-internal-delay-ps", 2000);
+			tx_delay = ofnode_read_u32_default(node, "tx-internal-delay-ps", 2000);
+			val = phy_read(phydev, MDIO_DEVAD_NONE, 0x17);
+			val &= ~((0x7 << 12) | (0x7 << 8));
+			val |= (rx_delay / 500) << 12;
+			val |= (tx_delay / 500) << 8;
+			phy_write(phydev, MDIO_DEVAD_NONE, 0x17, val);
+		}
+		break;
 	}
 
 	if (phydev->drv->config)
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

Subject: [PATCH] board: gateworks venice: add support for GPY111 phy

The TI DP83867 phy has been replaced with the MaxLinear GPY111 phy due to part availability.

Add support for it by adding LED config and dt-prop based internal delay config tx-delay/rx-delay per PHY ID.

Quoted 42 lines
---
 board/gateworks/venice/venice.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
(quoted diff) +0 -0

b/board/gateworks/venice/venice.c index 5334500ef6a7..425c69056da5 100644

board/gateworks/venice/venice.c +1 -0
@@ -63,6 +63,7 @@ static int setup_fec(void)  int board_phy_config(struct
 phy_device *phydev)  {
 	unsigned short val;
+	ofnode node;
 
 	switch (phydev->phy_id) {
 	case 0x2000a231: /* TI DP83867 GbE PHY */ @@ -73,6 +74,21 @@ int
 board_phy_config(struct phy_device *phydev)
board/gateworks/venice/venice.c +7 -0
 		val |= 0xb << 8; /* LED2(Green;Link/Act): blink for TX/RX act */
 		phy_write(phydev, MDIO_DEVAD_NONE, 24, val);
 		break;
+	case 0xd565a401: /* MaxLinear GPY111 */
+		puts("GPY111 ");
+		node = phy_get_ofnode(phydev);
+		if (ofnode_valid(node)) {
+			u32 rx_delay, tx_delay;
+
+			rx_delay = ofnode_read_u32_default(node,

"rx-internal-delay-ps", 2000);

board/gateworks/venice/venice.c +1 -0
+			tx_delay = ofnode_read_u32_default(node,

"tx-internal-delay-ps", 2000);

board/gateworks/venice/venice.c +7 -1
+			val = phy_read(phydev, MDIO_DEVAD_NONE, 0x17);
+			val &= ~((0x7 << 12) | (0x7 << 8));
+			val |= (rx_delay / 500) << 12;
+			val |= (tx_delay / 500) << 8;
+			phy_write(phydev, MDIO_DEVAD_NONE, 0x17, val);
+		}
+		break;
 	}
 
 	if (phydev->drv->config)
--

2.17.1

#2 lore raw

PATCH 1/1 board: gateworks venice: add support for GPY111 phy

In reply to Tim Harvey
Quoted 6 lines

The TI DP83867 phy has been replaced with the MaxLinear GPY111 phy due to part availability.
Add support for it by adding LED config and dt-prop based internal delay config tx-delay/rx-delay per PHY ID.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================