Skip to contentSkip to conversation

crypto: virtio - Select new dependencies

PATCH In review Nathan Chancellor 3 participants 3 messages Mar 8, 2022 – Mar 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: virtio - Select new dependencies

With ARCH=riscv defconfig, there are errors at link time:

virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to mpi_free' virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to rsa_parse_priv_key' virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to rsa_parse_pub_key' virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to mpi_read_raw_data' virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to crypto_register_akcipher' virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to crypto_unregister_akcipher'

The virtio crypto driver started making use of certain libraries and algorithms without selecting them. Do so to fix these errors.

Fixes 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")
---
 drivers/crypto/virtio/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/crypto/virtio/Kconfig +3 -0
index b894e3a8be4f..5f8915f4a9ff 100644
@@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
 	tristate "VirtIO crypto driver"
 	depends on VIRTIO
 	select CRYPTO_AEAD
+	select CRYPTO_AKCIPHER2
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
+	select CRYPTO_RSA
+	select MPILIB
 	help
 	  This driver provides support for virtio crypto device. If you
 	  choose 'M' here, this module will be called virtio_crypto.

base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b

Signature · 1 line
2.35.1
#1 lore raw
Quoted 9 lines · Nathan Chancellor

With ARCH=riscv defconfig, there are errors at link time:

virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to mpi_free' virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to rsa_parse_priv_key' virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to rsa_parse_pub_key' virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to mpi_read_raw_data' virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to crypto_register_akcipher' virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to crypto_unregister_akcipher'

Quoted 5 lines

The virtio crypto driver started making use of certain libraries and algorithms without selecting them. Do so to fix these errors.

Fixes 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")

Thanks! I'll squash this into the original commit so we don't have a broken commit during bisect.
zhenwei pi, ack pls?

Quoted 24 lines
---
 drivers/crypto/virtio/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/crypto/virtio/Kconfig +3 -0
index b894e3a8be4f..5f8915f4a9ff 100644
@@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
 	tristate "VirtIO crypto driver"
 	depends on VIRTIO
 	select CRYPTO_AEAD
+	select CRYPTO_AKCIPHER2
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
+	select CRYPTO_RSA
+	select MPILIB
 	help
 	  This driver provides support for virtio crypto device. If you
 	  choose 'M' here, this module will be called virtio_crypto.

base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b

Signature · 1 line
2.35.1
#2 lore raw
Quoted 13 lines · Michael S. Tsirkin
Quoted 12 lines · Nathan Chancellor

With ARCH=riscv defconfig, there are errors at link time:

   virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to `mpi_free'
   virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to `rsa_parse_priv_key'
   virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_pub_key'
   virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to `mpi_read_raw_data'
   virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to `crypto_register_akcipher'
   virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to `crypto_unregister_akcipher'

The virtio crypto driver started making use of certain libraries and algorithms without selecting them. Do so to fix these errors.

Quoted 7 lines
Quoted 2 lines
Fixes 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")

Thanks! I'll squash this into the original commit so we don't have a broken commit during bisect.
zhenwei pi, ack pls?

It looks good to me, thanks a lot.

Quoted 21 lines
Quoted 21 lines
---
  drivers/crypto/virtio/Kconfig | 3 +++
  1 file changed, 3 insertions(+)
drivers/crypto/virtio/Kconfig +3 -0
index b894e3a8be4f..5f8915f4a9ff 100644
@@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
  	tristate "VirtIO crypto driver"
  	depends on VIRTIO
  	select CRYPTO_AEAD
+	select CRYPTO_AKCIPHER2
  	select CRYPTO_SKCIPHER
  	select CRYPTO_ENGINE
+	select CRYPTO_RSA
+	select MPILIB
  	help
  	  This driver provides support for virtio crypto device. If you
  	  choose 'M' here, this module will be called virtio_crypto.
Quoted 3 lines
Quoted 3 lines

base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b

Signature · 1 line
2.35.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization