ethtool: Fix refcount leak in gfar_get_ts_info
PATCH 1/1 ethtool: Fix refcount leak in gfar_get_ts_info
The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount.
--- drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/freescale/gianfar_ethtool.c +1 -0
@@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev, ptp_node =of_find_compatible_node (NULL ,NULL ,"fsl,etsec-ptp" );if (ptp_node) { ptp_dev =of_find_device_by_node (ptp_node); +of_node_put (ptp_node);if (ptp_dev) ptp =platform_get_drvdata (ptp_dev); }
Signature · 1 line
2.17.1
Quoted 1 line
Subject: [PATCH] ethtool: Fix refcount leak in
gfar_get_ts_info
should be:
[PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
Quoted 15 lines · Miaoqian Lin
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/freescale/gianfar_ethtool.c +0
-0
drivers/net/ethernet/freescale/gianfar_ethtool.c static int gfar_get_ts_info(struct net_device *dev, · line 1470
Quoted 7 lines
drivers/net/ethernet/freescale/gianfar_ethtool.c +1
-0@@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev, ptp_node =of_find_compatible_node (NULL ,NULL ,"fsl,etsec-ptp" );if (ptp_node) { ptp_dev =of_find_device_by_node (ptp_node); +of_node_put (ptp_node);if (ptp_dev) ptp =platform_get_drvdata (ptp_dev); }
If you fix the subject and resend a v2, you can add
PATCH v2 1/1 gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount.
---
changes in v2:
- Fix the subject
--- drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/freescale/gianfar_ethtool.c +1 -0
@@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev, ptp_node =of_find_compatible_node (NULL ,NULL ,"fsl,etsec-ptp" );if (ptp_node) { ptp_dev =of_find_device_by_node (ptp_node); +of_node_put (ptp_node);if (ptp_dev) ptp =platform_get_drvdata (ptp_dev); }
Signature · 1 line
2.17.1
RE: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
Quoted 14 lines
-----Original Message-----
From: Miaoqian Lin <[email protected]>
Sent: Thursday, March 10, 2022 3:53 AM
To: Claudiu Manoil <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; Y.B. Lu <[email protected]>; [email protected]; linux- [email protected]
Cc: [email protected]
Subject: [PATCH net v2] gianfar: ethtool: Fix refcount leak ingfar_get_ts_infoThe
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.
Quoted 8 lines
Fixes 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index throughdrvdata")
Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Jesse Brandeburg <[email protected]>---
changes in v2:
- Fix the subject
---
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 9 Mar 2022 09:11:49 +0000 you wrote:
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")Signed-off-by Miaoqian Lin <[email protected]>[...]
Here is the summary with links:
- ethtool: Fix refcount leak in gfar_get_ts_info
https://git.kernel.org/netdev/net/c/2ac5b58e645c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
In reply to Miaoqian LinThis patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 10 Mar 2022 01:53:13 +0000 you wrote:
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Jesse Brandeburg <[email protected]>[...]
Here is the summary with links:
- [net,v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
https://git.kernel.org/netdev/net/c/2ac5b58e645c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Jakub Kicinski
maintainerQuoted 4 lines · On Thu, 10 Mar 2022 20:30:10 +0000 [email protected] wrote:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
No, it wasn't. Maybe I forgot to mark this version as Changes Requested before applying v2.
Quoted 15 lines · On Wed, 9 Mar 2022 09:11:49 +0000 you wrote:
Quoted 8 lines
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")Signed-off-by Miaoqian Lin <[email protected]>[...]
Here is the summary with links:
- ethtool: Fix refcount leak ingfar_get_ts_infohttps://git.kernel.org/netdev/net/c/2ac5b58e645cYou are awesome, thank you!