Skip to contentSkip to conversation

Add tile 4 plane format support

PATCH Superseded Jeevan B 3 participants 13 messages Mar 9, 2022 – Mar 15, 2022 Library code

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jeevan B

author
#0 lore raw

cover Add tile 4 plane format support

Adding new tests and support for tile 4 plane format.

Jeevan B (2):
igt/tests: Add support for Tile4(TileF) format to
tests/kms_addfb_basic
tests/kms_plane_scaling: Adding Tile-4 support

Matt Roper (1):
lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2

Mika Kahola (2):
tests/kms_frontbuffer_tracking: Add support for 4 tiling tests/kms_draw_crc: Use 4 tiling when filling framebuffer

 lib/igt_draw.c                        | 107 +++++++++++++++++++-------
 lib/intel_reg.h                       |   2 +
 tests/i915/kms_draw_crc.c             |   5 +-
 tests/i915/kms_frontbuffer_tracking.c |  22 +++++-
 tests/kms_addfb_basic.c               |  44 ++++++++++-
 tests/kms_plane_scaling.c             |  11 ++-
 6 files changed, 160 insertions(+), 31 deletions(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/5 lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2

From: Matt Roper <[email protected]>

The XY_COLOR_BLT instruction used by igt_draw's blitter implementation doesn't support F-tile (plus we've heard informally from the hardware team that the instruction is deprecated in general). Switch to XY_FAST_COLOR_BLT to perform our solid fills on DG2. This instruction will also allow us to extend the igt_draw support to 64bit+ color depths in the future too if we have tests that start wanting to test that.

Note that we don't currently pass enough information down to this routine to pick an appropriate value for the smem vs lmem performance hint bit, but that doesn't impact the output generated.

---
 lib/igt_draw.c  | 107 ++++++++++++++++++++++++++++++++++++------------
 lib/intel_reg.h |   2 +
 2 files changed, 83 insertions(+), 26 deletions(-)
lib/igt_draw.c +81 -26
index d78ecdf0..056101b9 100644
@@ -666,36 +666,91 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 	ibb = intel_bb_create(fd, PAGE_SIZE);
 	intel_bb_add_intel_buf(ibb, dst, true);
 
-	switch (buf->bpp) {
-	case 8:
-		blt_cmd_depth = 0;
-		break;
-	case 16: /* we're assuming 565 */
-		blt_cmd_depth = 1 << 24;
-		break;
-	case 32:
-		blt_cmd_depth = 3 << 24;
-		break;
-	default:
-		igt_assert(false);
-	}
+	if (IS_DG2(intel_get_drm_devid(fd))) {
+		int buf_height = buf->size / buf->stride;
+
+		switch (buf->bpp) {
+		case 8:
+			blt_cmd_depth = 0;
+			break;
+		case 16: /* we're assuming 565 */
+			blt_cmd_depth = 1 << 19;
+			break;
+		case 32:
+			blt_cmd_depth = 2 << 19;
+			break;
+		case 64:
+			/* Not used or supported yet */
+		default:
+			igt_assert(false);
+		}
+
+		switch (tiling) {
+		case I915_TILING_NONE:
+			blt_cmd_tiling = 0;
+			break;
+		case I915_TILING_X:
+			blt_cmd_tiling = 1 << 30;
+			break;
+		case I915_TILING_4:
+			blt_cmd_tiling = 2 << 30;
+			break;
+		default:
+			igt_assert(false);
+		}
+
+		pitch = tiling ? buf->stride / 4 : buf->stride;
+
+		intel_bb_out(ibb, XY_FAST_COLOR_BLT | blt_cmd_depth);
+		/* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */
+		intel_bb_out(ibb, blt_cmd_tiling | 2 << 21 | (pitch-1));
+		intel_bb_out(ibb, (rect->y << 16) | rect->x);
+		intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
+		intel_bb_emit_reloc_fenced(ibb, dst->handle, 0,
+					   I915_GEM_DOMAIN_RENDER, 0,
+					   dst->addr.offset);
+		intel_bb_out(ibb, 0);	/* TODO: Pass down enough info for target memory hint */
+		intel_bb_out(ibb, color);
+		intel_bb_out(ibb, 0);	/* 64 bit color */
+		intel_bb_out(ibb, 0);	/* 96 bit color */
+		intel_bb_out(ibb, 0);	/* 128 bit color */
+		intel_bb_out(ibb, 0);	/* clear address */
+		intel_bb_out(ibb, 0);	/* clear address */
+		intel_bb_out(ibb, (1 << 29) | ((pitch-1) << 14) | (buf_height-1));
+		intel_bb_out(ibb, 0);	/* mipmap levels / qpitch */
+		intel_bb_out(ibb, 0);	/* mipmap index / alignment */
+	} else {
+		switch (buf->bpp) {
+		case 8:
+			blt_cmd_depth = 0;
+			break;
+		case 16: /* we're assuming 565 */
+			blt_cmd_depth = 1 << 24;
+			break;
+		case 32:
+			blt_cmd_depth = 3 << 24;
+			break;
+		default:
+			igt_assert(false);
+		}
 
-	blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
-	blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
-	pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
+		blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
+		blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
+		pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
 
-	switch_blt_tiling(ibb, tiling, true);
+		switch_blt_tiling(ibb, tiling, true);
 
-	intel_bb_out(ibb, XY_COLOR_BLT_CMD_NOLEN | XY_COLOR_BLT_WRITE_ALPHA |
-		     XY_COLOR_BLT_WRITE_RGB | blt_cmd_tiling | blt_cmd_len);
-	intel_bb_out(ibb, blt_cmd_depth | (0xF0 << 16) | pitch);
-	intel_bb_out(ibb, (rect->y << 16) | rect->x);
-	intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
-	intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, I915_GEM_DOMAIN_RENDER,
-				   0, dst->addr.offset);
-	intel_bb_out(ibb, color);
+		intel_bb_out(ibb, XY_COLOR_BLT_CMD_NOLEN | XY_COLOR_BLT_WRITE_ALPHA |
+			     XY_COLOR_BLT_WRITE_RGB | blt_cmd_tiling | blt_cmd_len);
+		intel_bb_out(ibb, blt_cmd_depth | (0xF0 << 16) | pitch);
+		intel_bb_out(ibb, (rect->y << 16) | rect->x);
+		intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
+		intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, I915_GEM_DOMAIN_RENDER,
+					   0, dst->addr.offset);
+		intel_bb_out(ibb, color);
 
-	switch_blt_tiling(ibb, tiling, false);
+		switch_blt_tiling(ibb, tiling, false);
+	}
 
 	intel_bb_flush_blit(ibb);
 	intel_bb_destroy(ibb);
lib/intel_reg.h +2 -0
index 44b0d480..cb627288 100644
@@ -2557,6 +2557,8 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #define XY_MONO_SRC_BLT_WRITE_ALPHA	(1<<21)
 #define XY_MONO_SRC_BLT_WRITE_RGB	(1<<20)
 
+#define XY_FAST_COLOR_BLT		((0x2<<29)|(0x44<<22)|0xe)
+
 #define XY_FAST_COPY_BLT				((2<<29)|(0x42<<22)|0x8)
 /* dword 0 */
 #define   XY_FAST_COPY_SRC_TILING_LINEAR		(0 << 20)
Signature · 1 line
2.17.1
author
#3 lore raw

PATCH 2/5 igt/tests: Add support for Tile4(TileF) format to tests/kms_addfb_basic

In reply to Jeevan B

Adding subtest to test new tiling format

---
 tests/kms_addfb_basic.c | 44 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)
tests/kms_addfb_basic.c +43 -1
index b7b3b0f2..2fc99eb4 100644
@@ -155,7 +155,6 @@ static void invalid_tests(int fd)
 		uint64_t size;
 
 		igt_require_intel(fd);
-		igt_require(gem_has_lmem(fd));
 		igt_calc_fb_size(fd, f.width, f.height,
 				DRM_FORMAT_XRGB8888, 0, &size, &stride);
 		handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
@@ -676,6 +675,47 @@ static void addfb25_ytile(int fd)
 	}
 }
 
+static void addfb25_4tile(int fd)
+{
+	struct drm_mode_fb_cmd2 f = {};
+	igt_display_t display;
+
+	igt_fixture {
+		igt_display_require(&display, fd);
+
+		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
+				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+		igt_assert(gem_bo);
+
+		memset(&f, 0, sizeof(f));
+
+		f.width = 1024;
+		f.height = 1024;
+		f.pixel_format = DRM_FORMAT_XRGB8888;
+		f.pitches[0] = 1024*4;
+		f.flags = DRM_MODE_FB_MODIFIERS;
+		f.modifier[0] = DRM_FORMAT_MOD_LINEAR;
+
+		f.handles[0] = gem_bo;
+	}
+
+	igt_subtest("addfb25-4-tiled") {
+		igt_require_fb_modifiers(fd);
+
+		f.modifier[0] = I915_FORMAT_MOD_4_TILED;
+		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
+			   addfb_expected_ret(&display, &f));
+		if (!addfb_expected_ret(&display, &f))
+			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
+		f.fb_id = 0;
+	}
+
+	igt_fixture {
+		gem_close(fd, gem_bo);
+		igt_display_fini(&display);
+	}
+}
+
 static void prop_tests(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
@@ -826,6 +866,8 @@ igt_main
 
 	addfb25_ytile(fd);
 
+	addfb25_4tile(fd);
+
 	tiling_tests(fd);
 
 	prop_tests(fd);
Signature · 1 line
2.17.1
author
#5 lore raw

PATCH 3/5 tests/kms_frontbuffer_tracking: Add support for 4 tiling

In reply to Jeevan B

From: Mika Kahola <[email protected]>

GEN12 uses 4 tiling instead of Y tiling. Let's add support for tiling 4.

---
 tests/i915/kms_frontbuffer_tracking.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
tests/i915/kms_frontbuffer_tracking.c +20 -2
index 1c3acd79..814ddb46 100644
@@ -136,6 +136,7 @@ struct test_mode {
 		TILING_LINEAR = 0,
 		TILING_X,
 		TILING_Y,
+		TILING_4,
 		TILING_COUNT,
 		TILING_DEFAULT = TILING_X,
 	} tiling;
@@ -462,6 +463,8 @@ static uint64_t tiling_to_modifier(enum tiling_type tiling)
 		return I915_FORMAT_MOD_X_TILED;
 	case TILING_Y:
 		return I915_FORMAT_MOD_Y_TILED;
+	case TILING_4:
+		return I915_FORMAT_MOD_4_TILED;
 	default:
 		igt_assert(false);
 	}
@@ -2234,6 +2237,8 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
 	case TILING_X:
 	case TILING_Y:
 		return true;
+	case TILING_4:
+		return AT_LEAST_GEN(devid, 12);
 	default:
 		igt_assert(false);
 		return false;
@@ -3210,6 +3215,8 @@ static int opt_handler(int option, int option_index, void *data)
 			opt.tiling = TILING_X;
 		else if (!strcmp(optarg, "y"))
 			opt.tiling = TILING_Y;
+		else if (!strcmp(optarg, "4"))
+			opt.tiling = TILING_4;
 		else if (!strcmp(optarg, "l")) {
 			opt.tiling = TILING_LINEAR;
 		} else {
@@ -3353,6 +3360,8 @@ static const char *tiling_str(enum tiling_type tiling)
 		return "x";
 	case TILING_Y:
 		return "y";
+	case TILING_4:
+		return "4";
 	default:
 		igt_assert(false);
 	}
@@ -3404,9 +3413,12 @@ struct option long_options[] = {
 igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
 	struct test_mode t;
+	int devid;
 
-	igt_fixture
+	igt_fixture {
 		setup_environment();
+		devid = intel_get_drm_devid(drm.fd);
+	}
 
 	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
 		if (!opt.show_hidden && t.feature == FEATURE_NONE)
@@ -3604,8 +3616,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 
 					/* Tiling Y is only supported on GEN9+ */
 					if (t.tiling == TILING_Y) {
-						int devid = intel_get_drm_devid(drm.fd);
 						igt_require(AT_LEAST_GEN(devid, 9));
+						igt_require(!intel_get_device_info(devid)->has_4tile);
+					}
+
+					/* Tiling 4 is only supported on GEN12+ */
+					if (t.tiling == TILING_4) {
+						igt_require(AT_LEAST_GEN(devid, 12));
+						igt_require(intel_get_device_info(devid)->has_4tile);
 					}
 
 					if (tiling_is_valid(t.feature, t.tiling))
Signature · 1 line
2.17.1
author
#7 lore raw

PATCH 4/5 tests/kms_draw_crc: Use 4 tiling when filling framebuffer

In reply to Jeevan B

From: Mika Kahola <[email protected]>

For platforms with 4 tiling, let's use 4 tiling instead of Y tiling.

---
 tests/i915/kms_draw_crc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tests/i915/kms_draw_crc.c +4 -1
index 33b7bdf4..33fefed4 100644
@@ -226,6 +226,7 @@ static void fill_fb_subtest(void)
 	int rc;
 	struct igt_fb fb;
 	igt_crc_t base_crc, crc;
+	bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile;
 
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
@@ -248,7 +249,9 @@ static void fill_fb_subtest(void)
 	igt_assert_crc_equal(&crc, &base_crc);
 
 	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) {
-		get_fill_crc(I915_FORMAT_MOD_Y_TILED, &crc);
+		get_fill_crc(has_4tile ?
+			     I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED,
+			     &crc);
 		igt_assert_crc_equal(&crc, &base_crc);
 	}
 
Signature · 1 line
2.17.1
author
#9 lore raw

PATCH 5/5 tests/kms_plane_scaling: Adding Tile-4 support

In reply to Jeevan B

Adding subtest to test new tiling format

---
 tests/kms_plane_scaling.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
tests/kms_plane_scaling.c +10 -1
index b91039b0..73975480 100644
@@ -40,6 +40,7 @@ typedef struct {
 	igt_display_t display;
 	struct igt_fb fb[4];
 	bool extended;
+	bool has_4tile;
 } data_t;
 
 const struct {
@@ -331,7 +332,8 @@ static const uint64_t modifiers[] = {
 	DRM_FORMAT_MOD_LINEAR,
 	I915_FORMAT_MOD_X_TILED,
 	I915_FORMAT_MOD_Y_TILED,
-	I915_FORMAT_MOD_Yf_TILED
+	I915_FORMAT_MOD_Yf_TILED,
+	I915_FORMAT_MOD_4_TILED
 };
 
 static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, bool is_upscale,
@@ -350,6 +352,10 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height,
 
 		for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
 			uint64_t modifier = modifiers[i];
+
+			if (modifier == I915_FORMAT_MOD_4_TILED)
+				igt_require(d->has_4tile);
+
 			struct igt_vec tested_formats;
 
 			igt_vec_init(&tested_formats, sizeof(uint32_t));
@@ -682,6 +688,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		data.devid = is_i915_device(data.drm_fd) ?
 			intel_get_drm_devid(data.drm_fd) : 0;
 		igt_require(data.display.is_atomic);
+
+		data.has_4tile = is_i915_device(data.drm_fd) &&
+				 intel_get_device_info(intel_get_drm_devid(data.drm_fd))->has_4tile;
 	}
 
 	igt_subtest_group {
Signature · 1 line
2.17.1
#11 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Add tile 4 plane format support

In reply to Jeevan B
== Series Details ==

== Series Details ==

Series: Add tile 4 plane format support
URL : https://patchwork.freedesktop.org/series/101205/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11346 -> IGTPW_6765
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/index.html

Participating hosts (40 -> 35)
------------------------------

Additional (2): fi-icl-u2 fi-pnv-d510
Missing (7): fi-rkl-guc bat-dg1-5 fi-bsw-cyan bat-adlp-6 fi-ctg-p8600 bat-jsl-2 bat-jsl-1

Known issues
------------

Here are the changes found in IGTPW_6765 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@amdgpu/[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][4] -> [INCOMPLETE][5] ([i915#3303])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/fi-hsw-4770/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][6] ([i915#2927] / [i915#4528])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([fdo#109278]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [PASS][10] -> [DMESG-WARN][11] ([i915#295]) +12 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/fi-cfl-8109u/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-cfl-8109u/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#3555])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][13] ([fdo#109271]) +40 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-pnv-d510/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][14] ([i915#3301])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-icl-u2/igt@[email protected]

* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#2403] / [i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-pnv-d510/igt@[email protected]
- fi-hsw-4770: NOTRUN -> [FAIL][16] ([fdo#109271] / [i915#1436] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-hsw-4770/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-blb-e6850: [FAIL][17] ([i915#3194]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/fi-blb-e6850/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-blb-e6850/igt@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- {fi-rkl-11600}: [INCOMPLETE][19] ([i915#5127]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/fi-rkl-11600/igt@gem_exec_suspend@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6373 -> IGTPW_6765

CI-20190529: 20190529
CI_DRM_11346: ab6456d23719e60c20e8cef05a5f322eea134b88 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6765: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/index.html
IGT_6373: 82306f1903c0fee8371f43a156d8b63163ca61c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

+igt@kms_addfb_basic@addfb25-4-tiled
+igt@kms_frontbuffer_tracking@fbcdrrs-tiling-4
+igt@kms_frontbuffer_tracking@fbcpsrdrrs-tiling-4
+igt@kms_frontbuffer_tracking@fbcpsr-tiling-4
+igt@kms_frontbuffer_tracking@fbc-tiling-4

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/index.html

#12 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for Add tile 4 plane format support

In reply to Jeevan B
== Series Details ==

== Series Details ==

Series: Add tile 4 plane format support
URL : https://patchwork.freedesktop.org/series/101205/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11346_full -> IGTPW_6765_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6765_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6765_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/index.html

Participating hosts (13 -> 8)
------------------------------

Missing (5): pig-kbl-iris pig-glk-j5005 pig-skl-6260u shard-rkl shard-dg1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6765_full:

### IGT changes ###

#### Possible regressions ####

* igt@device_reset@unbind-reset-rebind:
- shard-glk: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk3/igt@[email protected]
- shard-apl: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-apl1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl4/igt@[email protected]
- shard-kbl: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl1/igt@[email protected]
- shard-iclb: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb1/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-kbl: [PASS][9] -> [TIMEOUT][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][11] -> [TIMEOUT][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-apl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl2/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb-size-offset-overflow:
- shard-tglb: NOTRUN -> [SKIP][13] +18 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb1/igt@[email protected]

* {igt@kms_frontbuffer_tracking@fbcpsr-tiling-4} (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][14] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglu-2/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-edp-1-scaler-with-clipping-clamping:
- shard-iclb: NOTRUN -> [SKIP][15] +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb8/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-edp-1-scaler-with-clipping-clamping.html

* igt@testdisplay:
- shard-apl: NOTRUN -> [TIMEOUT][16]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl6/[email protected]

#### Warnings ####

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-apl: [SKIP][17] ([fdo#109271]) -> [FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-apl4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl7/igt@[email protected]
- shard-tglb: [SKIP][19] ([i915#3826]) -> [FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb7/igt@[email protected]
- shard-glk: [SKIP][21] ([fdo#109271]) -> [FAIL][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk9/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk4/igt@[email protected]
- shard-kbl: [SKIP][23] ([fdo#109271]) -> [FAIL][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl4/igt@[email protected]
- shard-snb: [SKIP][25] ([fdo#109271]) -> [FAIL][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-snb5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-snb7/igt@[email protected]
- shard-iclb: [SKIP][27] ([i915#3826]) -> [FAIL][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb6/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@device_reset@unbind-reset-rebind:
- {shard-tglu}: [PASS][29] -> [DMESG-WARN][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglu-2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglu-4/igt@[email protected]

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- {shard-tglu}: [SKIP][31] ([i915#3826]) -> [FAIL][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglu-6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglu-1/igt@[email protected]

* {igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1-downscale-with-pixel-format}:
- {shard-tglu}: NOTRUN -> [SKIP][33] +25 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglu-1/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1-downscale-with-pixel-format.html

* {igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format}:
- shard-iclb: [SKIP][34] ([i915#5176]) -> [SKIP][35] +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb8/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html

* {igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format}:
- shard-tglb: [PASS][36] -> [SKIP][37] +19 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglb5/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb7/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html

* {igt@kms_plane_scaling@upscale-with-pixel-format-20x20@pipe-c-edp-1-upscale-with-pixel-format}:
- shard-iclb: [PASS][38] -> [SKIP][39] +11 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb3/igt@kms_plane_scaling@upscale-with-pixel-format-20x20@pipe-c-edp-1-upscale-with-pixel-format.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb1/igt@kms_plane_scaling@upscale-with-pixel-format-20x20@pipe-c-edp-1-upscale-with-pixel-format.html

* {igt@kms_plane_scaling@upscale-with-pixel-format-factor-0-25@pipe-c-hdmi-a-1-upscale-with-pixel-format}:
- {shard-tglu}: [PASS][40] -> [SKIP][41] +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglu-2/igt@kms_plane_scaling@upscale-with-pixel-format-factor-0-25@pipe-c-hdmi-a-1-upscale-with-pixel-format.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglu-8/igt@kms_plane_scaling@upscale-with-pixel-format-factor-0-25@pipe-c-hdmi-a-1-upscale-with-pixel-format.html

New tests
---------

New tests have been introduced between CI_DRM_11346_full and IGTPW_6765_full:

### New IGT tests (3) ###

* igt@kms_addfb_basic@addfb25-4-tiled:
- Statuses : 6 pass(s)
- Exec time: [0.0, 0.00] s

* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in IGTPW_6765_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][42] -> [SKIP][43] ([i915#658])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb2/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb8/igt@[email protected]

* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][44] ([i915#4991])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl1/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#1099])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-snb4/igt@[email protected]

* igt@gem_ctx_sseu@invalid-args:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#280])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb8/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: NOTRUN -> [FAIL][47] ([i915#232]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-contexts:
- shard-tglb: NOTRUN -> [DMESG-WARN][48] ([i915#5076]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb5/igt@[email protected]
- shard-kbl: NOTRUN -> [DMESG-WARN][49] ([i915#5076])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#4525])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb5/igt@[email protected]

* igt@gem_exec_capture@pi@vcs0:
- shard-iclb: [PASS][51] -> [INCOMPLETE][52] ([i915#3371])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb8/igt@gem_exec_capture@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb1/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][53] -> [FAIL][54] ([i915#2846])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl4/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: NOTRUN -> [FAIL][55] ([i915#2842]) +11 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][56] ([i915#2842]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][57] -> [FAIL][58] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl4/igt@gem_exec_fair@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][59] ([i915#2842]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@no-vebox:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109283] / [i915#4877])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb1/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2190])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2190])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#2190])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb4/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2190])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl7/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl6/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#4613])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb2/igt@[email protected]

* igt@gem_lmem_swapping@random:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk6/igt@[email protected]

* igt@gem_lmem_swapping@random-engines:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#4613]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb1/igt@[email protected]

* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#4270]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb5/igt@[email protected]

* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#4270]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb4/igt@[email protected]

* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][72] ([fdo#109271]) +204 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl1/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#768]) +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb1/igt@[email protected]

* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109312])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109312])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb1/igt@[email protected]

* igt@gem_userptr_blits@create-destroy-unsync:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3297]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb1/igt@[email protected]

* igt@gem_userptr_blits@unsync-overlap:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#3297]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb7/igt@[email protected]

* igt@gem_workarounds@suspend-resume:
- shard-kbl: [PASS][78] -> [DMESG-WARN][79] ([i915#180])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl3/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl7/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][80] -> [DMESG-WARN][81] ([i915#180]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-apl4/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl1/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][82] -> [DMESG-WARN][83] ([i915#1436] / [i915#716])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-apl8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl8/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#2527] / [i915#2856]) +4 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb7/igt@[email protected]

* igt@gen9_exec_parse@bb-start-far:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2856]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb2/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: NOTRUN -> [FAIL][86] ([i915#454])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb8/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#111644] / [i915#1397] / [i915#2411])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#110892])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb3/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-snb: NOTRUN -> [SKIP][89] ([fdo#109271]) +137 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-snb2/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109293] / [fdo#109506])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109506] / [i915#2411])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb8/igt@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#4387])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb1/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#1769])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb2/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [PASS][94] -> [DMESG-WARN][95] ([i915#118])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk3/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk4/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#110725] / [fdo#111614]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][97] ([fdo#111614]) +3 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb3/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3777]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#3777]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#111615]) +5 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb2/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#110723]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb5/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#2705])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb7/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109278] / [i915#3886]) +6 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb4/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#3886]) +8 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#3689] / [i915#3886]) +4 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][106] ([i915#3689]) +9 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb7/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs.html

* igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#111615] / [i915#3689]) +4 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb5/igt@kms_ccs@pipe-a-random-ccs-data-yf_tiled_ccs.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#3886]) +6 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk3/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
- shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#3886]) +4 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl2/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109278]) +26 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb6/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_cdclk@plane-scaling:
- shard-iclb: NOTRUN -> [SKIP][111] ([i915#3742])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#3742])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb6/igt@[email protected]

* igt@kms_chamelium@dp-frame-dump:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109284] / [fdo#111827]) +8 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb5/igt@[email protected]

* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][114] ([fdo#109271] / [fdo#111827]) +9 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][115] ([fdo#109284] / [fdo#111827]) +15 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][116] ([fdo#109271] / [fdo#111827]) +8 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-glk9/igt@[email protected]

* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][117] ([fdo#109271] / [fdo#111827]) +4 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-snb2/igt@[email protected]

* igt@kms_color@pipe-d-gamma:
- shard-iclb: NOTRUN -> [SKIP][118] ([fdo#109278] / [i915#1149])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb1/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [fdo#111827]) +15 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@content_type_change:
- shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109300] / [fdo#111066]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb2/igt@kms_content_protection@content_type_change.html

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][122] ([i915#3116])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][123] ([i915#3116] / [i915#3299])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb2/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-tglb: NOTRUN -> [SKIP][124] ([i915#1063]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb2/igt@[email protected]
- shard-kbl: NOTRUN -> [TIMEOUT][125] ([i915#1319])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-kbl4/igt@[email protected]
- shard-apl: NOTRUN -> [TIMEOUT][126] ([i915#1319])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-apl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][127] ([fdo#109278] / [fdo#109279]) +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][128] ([fdo#109279] / [i915#3359]) +6 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][129] ([i915#3359]) +10 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][130] ([fdo#109274] / [fdo#109278]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-iclb5/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-tglb: NOTRUN -> [SKIP][131] ([i915#4103])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][132] ([fdo#109274] / [fdo#111825]) +12 similar issues
[132]: https://intel-gfx-

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6765/index.html

Reviewed-by on v1 1/5
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 1/5] lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2

In reply to Jeevan B

Hi Jeevan,

Quoted 4 lines · Jeevan B

From: Matt Roper <[email protected]>

The XY_COLOR_BLT instruction used by igt_draw's blitter implementation doesn't support F-tile (plus we've heard informally from the hardware

^^
tile4

that draw_rect_blt(..) which is being patched is not very pretty function with lot of magic but it matches to style what was already there..

Quoted 151 lines

team that the instruction is deprecated in general). Switch to XY_FAST_COLOR_BLT to perform our solid fills on DG2. This instruction will also allow us to extend the igt_draw support to 64bit+ color depths in the future too if we have tests that start wanting to test that.

Note that we don't currently pass enough information down to this routine to pick an appropriate value for the smem vs lmem performance hint bit, but that doesn't impact the output generated.

---
  lib/igt_draw.c  | 107 ++++++++++++++++++++++++++++++++++++------------
  lib/intel_reg.h |   2 +
  2 files changed, 83 insertions(+), 26 deletions(-)
lib/igt_draw.c +81 -26
index d78ecdf0..056101b9 100644
@@ -666,36 +666,91 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
  	ibb = intel_bb_create(fd, PAGE_SIZE);
  	intel_bb_add_intel_buf(ibb, dst, true);
 
-	switch (buf->bpp) {
-	case 8:
-		blt_cmd_depth = 0;
-		break;
-	case 16: /* we're assuming 565 */
-		blt_cmd_depth = 1 << 24;
-		break;
-	case 32:
-		blt_cmd_depth = 3 << 24;
-		break;
-	default:
-		igt_assert(false);
-	}
+	if (IS_DG2(intel_get_drm_devid(fd))) {
+		int buf_height = buf->size / buf->stride;
+
+		switch (buf->bpp) {
+		case 8:
+			blt_cmd_depth = 0;
+			break;
+		case 16: /* we're assuming 565 */
+			blt_cmd_depth = 1 << 19;
+			break;
+		case 32:
+			blt_cmd_depth = 2 << 19;
+			break;
+		case 64:
+			/* Not used or supported yet */
+		default:
+			igt_assert(false);
+		}
+
+		switch (tiling) {
+		case I915_TILING_NONE:
+			blt_cmd_tiling = 0;
+			break;
+		case I915_TILING_X:
+			blt_cmd_tiling = 1 << 30;
+			break;
+		case I915_TILING_4:
+			blt_cmd_tiling = 2 << 30;
+			break;
+		default:
+			igt_assert(false);
+		}
+
+		pitch = tiling ? buf->stride / 4 : buf->stride;
+
+		intel_bb_out(ibb, XY_FAST_COLOR_BLT | blt_cmd_depth);
+		/* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */
+		intel_bb_out(ibb, blt_cmd_tiling | 2 << 21 | (pitch-1));
+		intel_bb_out(ibb, (rect->y << 16) | rect->x);
+		intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
+		intel_bb_emit_reloc_fenced(ibb, dst->handle, 0,
+					   I915_GEM_DOMAIN_RENDER, 0,
+					   dst->addr.offset);
+		intel_bb_out(ibb, 0);	/* TODO: Pass down enough info for target memory hint */
+		intel_bb_out(ibb, color);
+		intel_bb_out(ibb, 0);	/* 64 bit color */
+		intel_bb_out(ibb, 0);	/* 96 bit color */
+		intel_bb_out(ibb, 0);	/* 128 bit color */
+		intel_bb_out(ibb, 0);	/* clear address */
+		intel_bb_out(ibb, 0);	/* clear address */
+		intel_bb_out(ibb, (1 << 29) | ((pitch-1) << 14) | (buf_height-1));
+		intel_bb_out(ibb, 0);	/* mipmap levels / qpitch */
+		intel_bb_out(ibb, 0);	/* mipmap index / alignment */
+	} else {
+		switch (buf->bpp) {
+		case 8:
+			blt_cmd_depth = 0;
+			break;
+		case 16: /* we're assuming 565 */
+			blt_cmd_depth = 1 << 24;
+			break;
+		case 32:
+			blt_cmd_depth = 3 << 24;
+			break;
+		default:
+			igt_assert(false);
+		}
 
-	blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
-	blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
-	pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
+		blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
+		blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
+		pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
 
-	switch_blt_tiling(ibb, tiling, true);
+		switch_blt_tiling(ibb, tiling, true);
 
-	intel_bb_out(ibb, XY_COLOR_BLT_CMD_NOLEN | XY_COLOR_BLT_WRITE_ALPHA |
-		     XY_COLOR_BLT_WRITE_RGB | blt_cmd_tiling | blt_cmd_len);
-	intel_bb_out(ibb, blt_cmd_depth | (0xF0 << 16) | pitch);
-	intel_bb_out(ibb, (rect->y << 16) | rect->x);
-	intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
-	intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, I915_GEM_DOMAIN_RENDER,
-				   0, dst->addr.offset);
-	intel_bb_out(ibb, color);
+		intel_bb_out(ibb, XY_COLOR_BLT_CMD_NOLEN | XY_COLOR_BLT_WRITE_ALPHA |
+			     XY_COLOR_BLT_WRITE_RGB | blt_cmd_tiling | blt_cmd_len);
+		intel_bb_out(ibb, blt_cmd_depth | (0xF0 << 16) | pitch);
+		intel_bb_out(ibb, (rect->y << 16) | rect->x);
+		intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
+		intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, I915_GEM_DOMAIN_RENDER,
+					   0, dst->addr.offset);
+		intel_bb_out(ibb, color);
 
-	switch_blt_tiling(ibb, tiling, false);
+		switch_blt_tiling(ibb, tiling, false);
+	}
 
  	intel_bb_flush_blit(ibb);
  	intel_bb_destroy(ibb);
lib/intel_reg.h +2 -0
index 44b0d480..cb627288 100644
@@ -2557,6 +2557,8 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  #define XY_MONO_SRC_BLT_WRITE_ALPHA	(1<<21)
  #define XY_MONO_SRC_BLT_WRITE_RGB	(1<<20)
 
+#define XY_FAST_COLOR_BLT		((0x2<<29)|(0x44<<22)|0xe)
+
  #define XY_FAST_COPY_BLT				((2<<29)|(0x42<<22)|0x8)
  /* dword 0 */
  #define   XY_FAST_COPY_SRC_TILING_LINEAR		(0 << 20)
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 2/5] igt/tests: Add support for Tile4(TileF) format to tests/kms_addfb_basic

In reply to Jeevan B
Quoted 12 lines · Jeevan B

Adding subtest to test new tiling format

---
  tests/kms_addfb_basic.c | 44 ++++++++++++++++++++++++++++++++++++++++-
  1 file changed, 43 insertions(+), 1 deletion(-)
tests/kms_addfb_basic.c +0 -0
index b7b3b0f2..2fc99eb4 100644

tests/kms_addfb_basic.c static void invalid_tests(int fd) · line 158

Quoted 4 lines
tests/kms_addfb_basic.c +0 -1
@@ -155,7 +155,6 @@ static void invalid_tests(int fd)
  		uint64_t size;
 
  		igt_require_intel(fd);
-		igt_require(gem_has_lmem(fd));

I think this change caused those ci failures on kms_addfb_basic

Quoted 60 lines
tests/kms_addfb_basic.c +43 -0
  		igt_calc_fb_size(fd, f.width, f.height,
  				DRM_FORMAT_XRGB8888, 0, &size, &stride);
  		handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
@@ -676,6 +675,47 @@ static void addfb25_ytile(int fd)
  	}
  }
 
+static void addfb25_4tile(int fd)
+{
+	struct drm_mode_fb_cmd2 f = {};
+	igt_display_t display;
+
+	igt_fixture {
+		igt_display_require(&display, fd);
+
+		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
+				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+		igt_assert(gem_bo);
+
+		memset(&f, 0, sizeof(f));
+
+		f.width = 1024;
+		f.height = 1024;
+		f.pixel_format = DRM_FORMAT_XRGB8888;
+		f.pitches[0] = 1024*4;
+		f.flags = DRM_MODE_FB_MODIFIERS;
+		f.modifier[0] = DRM_FORMAT_MOD_LINEAR;
+
+		f.handles[0] = gem_bo;
+	}
+
+	igt_subtest("addfb25-4-tiled") {
+		igt_require_fb_modifiers(fd);
+
+		f.modifier[0] = I915_FORMAT_MOD_4_TILED;
+		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
+			   addfb_expected_ret(&display, &f));
+		if (!addfb_expected_ret(&display, &f))
+			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
+		f.fb_id = 0;
+	}
+
+	igt_fixture {
+		gem_close(fd, gem_bo);
+		igt_display_fini(&display);
+	}
+}
+
  static void prop_tests(int fd)
  {
  	struct drm_mode_fb_cmd2 f = {};
@@ -826,6 +866,8 @@ igt_main
 
  	addfb25_ytile(fd);
 
+	addfb25_4tile(fd);
+
  	tiling_tests(fd);
 
  	prop_tests(fd);
Reviewed-by on v1 3/5
#6 lore raw

Re: [igt-dev] [PATCH i-g-t 3/5] tests/kms_frontbuffer_tracking: Add support for 4 tiling

In reply to Jeevan B
Quoted 89 lines · Jeevan B

From: Mika Kahola <[email protected]>

GEN12 uses 4 tiling instead of Y tiling. Let's add support for tiling 4.

---
  tests/i915/kms_frontbuffer_tracking.c | 22 ++++++++++++++++++++--
  1 file changed, 20 insertions(+), 2 deletions(-)
tests/i915/kms_frontbuffer_tracking.c +20 -2
index 1c3acd79..814ddb46 100644
@@ -136,6 +136,7 @@ struct test_mode {
  		TILING_LINEAR = 0,
  		TILING_X,
  		TILING_Y,
+		TILING_4,
  		TILING_COUNT,
  		TILING_DEFAULT = TILING_X,
  	} tiling;
@@ -462,6 +463,8 @@ static uint64_t tiling_to_modifier(enum tiling_type tiling)
  		return I915_FORMAT_MOD_X_TILED;
  	case TILING_Y:
  		return I915_FORMAT_MOD_Y_TILED;
+	case TILING_4:
+		return I915_FORMAT_MOD_4_TILED;
  	default:
  		igt_assert(false);
  	}
@@ -2234,6 +2237,8 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
  	case TILING_X:
  	case TILING_Y:
  		return true;
+	case TILING_4:
+		return AT_LEAST_GEN(devid, 12);
  	default:
  		igt_assert(false);
  		return false;
@@ -3210,6 +3215,8 @@ static int opt_handler(int option, int option_index, void *data)
  			opt.tiling = TILING_X;
  		else if (!strcmp(optarg, "y"))
  			opt.tiling = TILING_Y;
+		else if (!strcmp(optarg, "4"))
+			opt.tiling = TILING_4;
  		else if (!strcmp(optarg, "l")) {
  			opt.tiling = TILING_LINEAR;
  		} else {
@@ -3353,6 +3360,8 @@ static const char *tiling_str(enum tiling_type tiling)
  		return "x";
  	case TILING_Y:
  		return "y";
+	case TILING_4:
+		return "4";
  	default:
  		igt_assert(false);
  	}
@@ -3404,9 +3413,12 @@ struct option long_options[] = {
  igt_main_args("", long_options, help_str, opt_handler, NULL)
  {
  	struct test_mode t;
+	int devid;
 
-	igt_fixture
+	igt_fixture {
  		setup_environment();
+		devid = intel_get_drm_devid(drm.fd);
+	}
 
  	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
  		if (!opt.show_hidden && t.feature == FEATURE_NONE)
@@ -3604,8 +3616,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 
  					/* Tiling Y is only supported on GEN9+ */
  					if (t.tiling == TILING_Y) {
-						int devid = intel_get_drm_devid(drm.fd);
  						igt_require(AT_LEAST_GEN(devid, 9));
+						igt_require(!intel_get_device_info(devid)->has_4tile);
+					}
+
+					/* Tiling 4 is only supported on GEN12+ */
+					if (t.tiling == TILING_4) {
+						igt_require(AT_LEAST_GEN(devid, 12));
+						igt_require(intel_get_device_info(devid)->has_4tile);
  					}
 
  					if (tiling_is_valid(t.feature, t.tiling))
Reviewed-by on v1 4/5
#8 lore raw

Re: [igt-dev] [PATCH i-g-t 4/5] tests/kms_draw_crc: Use 4 tiling when filling framebuffer

In reply to Jeevan B
Quoted 33 lines · Jeevan B

From: Mika Kahola <[email protected]>

For platforms with 4 tiling, let's use 4 tiling instead of Y tiling.

---
  tests/i915/kms_draw_crc.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
tests/i915/kms_draw_crc.c +4 -1
index 33b7bdf4..33fefed4 100644
@@ -226,6 +226,7 @@ static void fill_fb_subtest(void)
  	int rc;
  	struct igt_fb fb;
  	igt_crc_t base_crc, crc;
+	bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile;
 
  	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
  		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
@@ -248,7 +249,9 @@ static void fill_fb_subtest(void)
  	igt_assert_crc_equal(&crc, &base_crc);
 
  	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) {
-		get_fill_crc(I915_FORMAT_MOD_Y_TILED, &crc);
+		get_fill_crc(has_4tile ?
+			     I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED,
+			     &crc);
  		igt_assert_crc_equal(&crc, &base_crc);
  	}
 
#10 lore raw

Re: [igt-dev] [PATCH i-g-t 5/5] tests/kms_plane_scaling: Adding Tile-4 support

In reply to Jeevan B
Quoted 12 lines · Jeevan B

Adding subtest to test new tiling format

---
  tests/kms_plane_scaling.c | 11 ++++++++++-
  1 file changed, 10 insertions(+), 1 deletion(-)
tests/kms_plane_scaling.c +0 -0
index b91039b0..73975480 100644

tests/kms_plane_scaling.c typedef struct { · line 43

Quoted 4 lines
tests/kms_plane_scaling.c +1 -0
@@ -40,6 +40,7 @@ typedef struct {
  	igt_display_t display;
  	struct igt_fb fb[4];
  	bool extended;
+	bool has_4tile;

this entire has_4tile flag seems mostly harmful. Only place where it is used is followed by igt_plane_has_format_mod(..)

Quoted 14 lines
tests/kms_plane_scaling.c +2 -1
  } data_t;
 
  const struct {
@@ -331,7 +332,8 @@ static const uint64_t modifiers[] = {
  	DRM_FORMAT_MOD_LINEAR,
  	I915_FORMAT_MOD_X_TILED,
  	I915_FORMAT_MOD_Y_TILED,
-	I915_FORMAT_MOD_Yf_TILED
+	I915_FORMAT_MOD_Yf_TILED,
+	I915_FORMAT_MOD_4_TILED
  };
 
  static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, bool is_upscale,

tests/kms_plane_scaling.c static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, · line 358

Quoted 7 lines
tests/kms_plane_scaling.c +4 -0
@@ -350,6 +352,10 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height,
 
  		for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
  			uint64_t modifier = modifiers[i];
+
+			if (modifier == I915_FORMAT_MOD_4_TILED)
+				igt_require(d->has_4tile);
+

I think this will cause this test to skip on all non dg2 boxes?

Quoted 13 lines
tests/kms_plane_scaling.c +3 -0
  			struct igt_vec tested_formats;
 
  			igt_vec_init(&tested_formats, sizeof(uint32_t));
@@ -682,6 +688,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
  		data.devid = is_i915_device(data.drm_fd) ?
  			intel_get_drm_devid(data.drm_fd) : 0;
  		igt_require(data.display.is_atomic);
+
+		data.has_4tile = is_i915_device(data.drm_fd) &&
+				 intel_get_device_info(intel_get_drm_devid(data.drm_fd))->has_4tile;
  	}
 
  	igt_subtest_group {