Skip to contentSkip to conversation

drm/amdgpu: only check for _PR3 on dGPUs

PATCH In review Alex Deucher 2 participants 2 messages Mar 9, 2022

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu: only check for _PR3 on dGPUs

We don't support runtime pm on APUs. They support more dynamic power savings using clock and powergating.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4 -2
index ddc5cd61af58..1b313a95c7e5 100644
@@ -2159,8 +2159,10 @@ static int amdgpu_device_ip_early_init(struct amdgpu_device *adev)
 	    !pci_is_thunderbolt_attached(to_pci_dev(dev->dev)))
 		adev->flags |= AMD_IS_PX;
 
-	parent = pci_upstream_bridge(adev->pdev);
-	adev->has_pr3 = parent ? pci_pr3_present(parent) : false;
+	if (!(adev->flags & AMD_IS_APU)) {
+		parent = pci_upstream_bridge(adev->pdev);
+		adev->has_pr3 = parent ? pci_pr3_present(parent) : false;
+	}
 
 	amdgpu_amdkfd_device_probe(adev);
 
Signature · 1 line
2.35.1
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 15 lines · Alex Deucher

We don't support runtime pm on APUs. They support more dynamic power savings using clock and powergating.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -0
index ddc5cd61af58..1b313a95c7e5 100644
@@ -2159,8 +2159,10 @@ static int amdgpu_device_ip_early_init(struct amdgpu_device *adev)
  	    !pci_is_thunderbolt_attached(to_pci_dev(dev->dev)))
  		adev->flags |= AMD_IS_PX;

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static int amdgpu_device_ip_early_init(struct amdgpu_device *adev) · line 2168

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4 -2
 
-	parent = pci_upstream_bridge(adev->pdev);
-	adev->has_pr3 = parent ? pci_pr3_present(parent) : false;
+	if (!(adev->flags & AMD_IS_APU)) {
+		parent = pci_upstream_bridge(adev->pdev);
+		adev->has_pr3 = parent ? pci_pr3_present(parent) : false;
+	}
 
  	amdgpu_amdkfd_device_probe(adev);
 

I also confirmed this fixes the smartshift bias attribute from exporting on an APU program it shouldn't.