tools: feature/test-libperl.c: Sync PERL_EMBED_CCOPTS with perf
PATCH 1/1 tools: feature/test-libperl.c: Sync PERL_EMBED_CCOPTS with perf
When trying to build perf with a LLVM/Clang toolchain people see errors when testing for libperl feature.
Jiri reports:
Quoted 5 lines
I'm getting some other lto related error:
$ cat test-libperl.make.output clang-13: error: optimization flag '-ffat-lto-objects' is not supported [-Werror,-Wignored-optimization-argument]
The reason is PERL_EMBED_CCOPTS is defined in two places:
tools/build/feature/Makefiletools/perf/Makefile.config
As an result FLAGS_PERL_EMBED is set differently.
For building perf '-ffat-lto-objects' is filtered-out:
$ git grep ffat-lto-objects tools/perf/ tools/perf/Makefile.config: PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))
Sync PERL_EMBED_CCOPTS in tools/build/feature/Makefile to fix this.
For a minimal fix for Linux v5.17 this here was preferred by Arnaldo.
--- tools/build/feature/Makefile | 1 + 1 file changed, 1 insertion(+)
tools/build/feature/Makefile +1 -0
@@ -218,6 +218,7 @@ PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) $(OUTPUT)test-libperl.bin:
Signature · 1 line
2.35.1
Quoted 12 lines · Sedat Dilek
When trying to build perf with a LLVM/Clang toolchain people see errors when testing for libperl feature.
Jiri reports:
Quoted 5 lines
I'm getting some other lto related error:
$ cat test-libperl.make.output clang-13: error: optimization flag '-ffat-lto-objects' is not supported [-Werror,-Wignored-optimization-argument]
Quoted 6 lines
The reason is
PERL_EMBED_CCOPTSis defined in two places:
tools/build/feature/Makefiletools/perf/Makefile.configAs an result
FLAGS_PERL_EMBEDis set differently.
s/an/a/
Quoted 11 lines
For building perf '-ffat-lto-objects' is filtered-out:
$ git grep ffat-lto-objects tools/perf/ tools/perf/Makefile.config: PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))Sync
PERL_EMBED_CCOPTSintools/build/feature/Makefileto fix this.For a minimal fix for Linux v5.17 this here was preferred by Arnaldo.
Hey Sedat, we prefer lore links now to external mirrors!
Quoted 5 lines
Reported-by Jiri Olsa <[email protected]>Reported-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Sedat Dilek <[email protected]>
Thanks for the patch!
Quoted 19 lines
--- tools/build/feature/Makefile | 1 + 1 file changed, 1 insertion(+)tools/build/feature/Makefile +1
-1@@ -218,6 +218,7 @@ PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) $(OUTPUT)test-libperl.bin: --2.35.1
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 42 lines · Sedat Dilek
When trying to build perf with a LLVM/Clang toolchain people see errors when testing for libperl feature.
Jiri reports:
Quoted 5 lines
I'm getting some other lto related error:
$ cat test-libperl.make.output clang-13: error: optimization flag '-ffat-lto-objects' is not supported [-Werror,-Wignored-optimization-argument]The reason is
PERL_EMBED_CCOPTSis defined in two places:
tools/build/feature/Makefiletools/perf/Makefile.configAs an result
FLAGS_PERL_EMBEDis set differently.For building perf '-ffat-lto-objects' is filtered-out:
$ git grep ffat-lto-objects tools/perf/ tools/perf/Makefile.config: PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))Sync
PERL_EMBED_CCOPTSintools/build/feature/Makefileto fix this.For a minimal fix for Linux v5.17 this here was preferred by Arnaldo.
Reported-by Jiri Olsa <[email protected]>Reported-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Sedat Dilek <[email protected]>--- tools/build/feature/Makefile | 1 + 1 file changed, 1 insertion(+)tools/build/feature/Makefile +0
-0
tools/build/feature/Makefile PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) · line 221
Quoted 4 lines
tools/build/feature/Makefile +1
-0@@ -218,6 +218,7 @@ PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS))
it looks like this is not enough, at least on fedora 35
I had to add changes below on top of your patch, it fixed the perl feature detection and perf build itself, but I'm still getting error with perf/python.so:
$ CC=clang make JOBS=1 ... GEN python/perf.so python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: file not recognized: file format not recognized clang-13: error: linker command failed with exit code 1 (use -v to see invocation) error: command 'clang' failed with exit status 1 cp: cannot stat 'python_ext_build/lib/perf*.so': No such file or directory
with:
$ file python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: LLVM IR bitcode
do you get clean compile with python lang enabled?
jirka
---
tools/build/feature/Makefile +2 -2
@@ -217,9 +217,9 @@ strip-libs = $(filter-out -l%,$(1)) PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) -PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) +FLAGS_PERL_EMBED := $(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro $(OUTPUT)test-libperl.bin: $(BUILD) $(FLAGS_PERL_EMBED)
tools/perf/Makefile.config +1 -1
@@ -778,7 +778,7 @@ else PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -specs=%,$(PERL_EMBED_CCOPTS)) - PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) + PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro PERL_EMBED_LDOPTS := $(filter-out -specs=%,$(PERL_EMBED_LDOPTS)) FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)
tools/perf/util/setup.py +1 -1
@@ -43,7 +43,7 @@ class install_lib(_install_lib): cflags = getenv('CFLAGS', '').split() # switch off several checks (need to be at the end of cflags list) -cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-DPYTHON_PERF' ] +cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-Wno-ignored-optimization-argument', '-DPYTHON_PERF' ] if not cc_is_clang: cflags += ['-Wno-cast-function-type' ]
Quoted 51 lines · Jiri Olsa
Quoted 42 lines · Sedat Dilek
When trying to build perf with a LLVM/Clang toolchain people see errors when testing for libperl feature.
Jiri reports:
Quoted 5 lines
I'm getting some other lto related error:
$ cat test-libperl.make.output clang-13: error: optimization flag '-ffat-lto-objects' is not supported [-Werror,-Wignored-optimization-argument]The reason is
PERL_EMBED_CCOPTSis defined in two places:
tools/build/feature/Makefiletools/perf/Makefile.configAs an result
FLAGS_PERL_EMBEDis set differently.For building perf '-ffat-lto-objects' is filtered-out:
$ git grep ffat-lto-objects tools/perf/ tools/perf/Makefile.config: PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))Sync
PERL_EMBED_CCOPTSintools/build/feature/Makefileto fix this.For a minimal fix for Linux v5.17 this here was preferred by Arnaldo.
Reported-by Jiri Olsa <[email protected]>Reported-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Sedat Dilek <[email protected]>--- tools/build/feature/Makefile | 1 + 1 file changed, 1 insertion(+)tools/build/feature/Makefile +0
-0tools/build/feature/Makefile PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) · line 221
Quoted 4 lines
tools/build/feature/Makefile +1
-0@@ -218,6 +218,7 @@ PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS))it looks like this is not enough, at least on fedora 35
Quoted 4 lines
I had to add changes below on top of your patch, it fixed the perl feature detection and perf build itself, but I'm still getting error with perf/python.so:
Correct. This patch simply fixes the perl feature detection.
Quoted 40 lines
$ CC=clang make JOBS=1 ... GEN python/perf.so python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: file not recognized: file format not recognized clang-13: error: linker command failed with exit code 1 (use -v to see invocation) error: command 'clang' failed with exit status 1 cp: cannot stat 'python_ext_build/lib/perf*.so': No such file or directorywith:
$ file python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: LLVM IR bitcodedo you get clean compile with python lang enabled?
jirka
---
tools/build/feature/Makefile +2
-2@@ -217,9 +217,9 @@ strip-libs = $(filter-out -l%,$(1)) PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) -PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) +FLAGS_PERL_EMBED := $(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro $(OUTPUT)test-libperl.bin: $(BUILD) $(FLAGS_PERL_EMBED)tools/perf/Makefile.config +0
-0
tools/perf/Makefile.config else · line 784
Quoted 8 lines
tools/perf/Makefile.config +1
-1@@ -778,7 +778,7 @@ else PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -specs=%,$(PERL_EMBED_CCOPTS)) - PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) + PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro PERL_EMBED_LDOPTS := $(filter-out -specs=%,$(PERL_EMBED_LDOPTS)) FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)
I fixed that differently by (see [1]),
tools/perf/Makefile.config +0 -0
@@ -213,7 +213,7 @@ endif
# Treat warnings as errors unless directed not to ifneq ($(WERROR),0)
- CORE_CFLAGS += -Werror
+ CORE_CFLAGS += -Werror -Wno-compound-token-split-by-macro CXXFLAGS += -Werror
HOSTCFLAGS += -Werror
endif
This was sufficient here to build perf successfully. And maybe ifdef-ed for clang?
But all this is a follow-up?
[1] https://lore.kernel.org/lkml/CA+icZUUCO+gOPLZumu_rTOJz1_v7gRRYVzzEZ+RZPOZBmkqCQg@mail.gmail.com/
tools/perf/util/setup.py class install_lib(_install_lib): · line 49
Quoted 13 lines
tools/perf/util/setup.py +1
-1@@ -43,7 +43,7 @@ class install_lib(_install_lib): cflags = getenv('CFLAGS', '').split() # switch off several checks (need to be at the end of cflags list) -cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-DPYTHON_PERF' ] +cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-Wno-ignored-optimization-argument', '-DPYTHON_PERF' ] if not cc_is_clang: cflags += ['-Wno-cast-function-type' ]
Cannot say much to that.
Do we want to fix perf building with LLVM/Clang for Linux v5.17 final or later? Arnaldo?
- Sedat -
Quoted 146 lines · Sedat Dilek
Quoted 51 lines · Jiri Olsa
Quoted 42 lines · Sedat Dilek
When trying to build perf with a LLVM/Clang toolchain people see errors when testing for libperl feature.
Jiri reports:
Quoted 5 lines
I'm getting some other lto related error:
$ cat test-libperl.make.output clang-13: error: optimization flag '-ffat-lto-objects' is not supported [-Werror,-Wignored-optimization-argument]The reason is
PERL_EMBED_CCOPTSis defined in two places:
tools/build/feature/Makefiletools/perf/Makefile.configAs an result
FLAGS_PERL_EMBEDis set differently.For building perf '-ffat-lto-objects' is filtered-out:
$ git grep ffat-lto-objects tools/perf/ tools/perf/Makefile.config: PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))Sync
PERL_EMBED_CCOPTSintools/build/feature/Makefileto fix this.For a minimal fix for Linux v5.17 this here was preferred by Arnaldo.
Reported-by Jiri Olsa <[email protected]>Reported-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Sedat Dilek <[email protected]>--- tools/build/feature/Makefile | 1 + 1 file changed, 1 insertion(+)tools/build/feature/Makefile +0
-0tools/build/feature/Makefile PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) · line 221
Quoted 4 lines
tools/build/feature/Makefile +1
-0@@ -218,6 +218,7 @@ PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS))it looks like this is not enough, at least on fedora 35
Quoted 4 lines
I had to add changes below on top of your patch, it fixed the perl feature detection and perf build itself, but I'm still getting error with perf/python.so:
Correct. This patch simply fixes the perl feature detection.
Quoted 40 lines
$ CC=clang make JOBS=1 ... GEN python/perf.so python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: file not recognized: file format not recognized clang-13: error: linker command failed with exit code 1 (use -v to see invocation) error: command 'clang' failed with exit status 1 cp: cannot stat 'python_ext_build/lib/perf*.so': No such file or directorywith:
$ file python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: LLVM IR bitcodedo you get clean compile with python lang enabled?
jirka
---
tools/build/feature/Makefile +2
-2@@ -217,9 +217,9 @@ strip-libs = $(filter-out -l%,$(1)) PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) -PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) +FLAGS_PERL_EMBED := $(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro $(OUTPUT)test-libperl.bin: $(BUILD) $(FLAGS_PERL_EMBED)tools/perf/Makefile.config +0
-0tools/perf/Makefile.config else · line 784
Quoted 8 lines
tools/perf/Makefile.config +1
-1@@ -778,7 +778,7 @@ else PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -specs=%,$(PERL_EMBED_CCOPTS)) - PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) + PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro PERL_EMBED_LDOPTS := $(filter-out -specs=%,$(PERL_EMBED_LDOPTS)) FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)I fixed that differently by (see [1]),
tools/perf/Makefile.config +1
-1@@ -213,7 +213,7 @@ endif # Treat warnings as errors unless directed not to ifneq ($(WERROR),0) - CORE_CFLAGS += -Werror + CORE_CFLAGS += -Werror -Wno-compound-token-split-by-macro CXXFLAGS += -Werror HOSTCFLAGS += -Werrorendif
This was sufficient here to build perf successfully. And maybe ifdef-ed for clang?
But all this is a follow-up?
[1] https://lore.kernel.org/lkml/CA+icZUUCO+gOPLZumu_rTOJz1_v7gRRYVzzEZ+RZPOZBmkqCQg@mail.gmail.com/
tools/perf/util/setup.py class install_lib(_install_lib): · line 49
Quoted 13 lines
tools/perf/util/setup.py +1
-1@@ -43,7 +43,7 @@ class install_lib(_install_lib): cflags = getenv('CFLAGS', '').split() # switch off several checks (need to be at the end of cflags list) -cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-DPYTHON_PERF' ] +cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-Wno-ignored-optimization-argument', '-DPYTHON_PERF' ] if not cc_is_clang: cflags += ['-Wno-cast-function-type' ]Cannot say much to that.
Quoted 3 lines
Do we want to fix perf building with LLVM/Clang for Linux v5.17 final or later? Arnaldo?
Attached is the patch I use to build perf.
( As said in the initial report I wanted to test perf with -std=gnu11. ) ( Cannot say much if this related to perl v5.34 only. )
- Sedat -
[1] https://lore.kernel.org/lkml/CA+icZUWHd4VTKNwBtuxt9-fHoiYV+Q7tQ809Cn83k8sbQ_uNHw@mail.gmail.com/
From 316a1917ec05772ab0f99dad534fabdd74547865 Mon Sep 17 00:00:00 2001
From: Sedat Dilek <[email protected]>
Date: Sun, 6 Mar 2022 11:29:50 +0100
Subject: [PATCH] perf: Fix libperl support with clang and perl v5.34
--- tools/build/feature/Makefile | 2 +- tools/perf/Makefile.config | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
tools/build/feature/Makefile +1 -1
@@ -81,7 +81,7 @@ PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config all: $(FILES) -__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS) +__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -Wno-compound-token-split-by-macro -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS) BUILD = $(__BUILD) > $(@:.bin=.make.output) 2>&1 __BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
tools/perf/Makefile.config +1 -1
@@ -213,7 +213,7 @@ endif # Treat warnings as errors unless directed not to ifneq ($(WERROR),0) - CORE_CFLAGS += -Werror + CORE_CFLAGS += -Werror -Wno-compound-token-split-by-macro CXXFLAGS += -Werror HOSTCFLAGS += -Werror endif
Signature · 1 line
2.35.1
Quoted 152 lines · Sedat Dilek
Quoted 146 lines · Sedat Dilek
Quoted 51 lines · Jiri Olsa
Quoted 42 lines · Sedat Dilek
When trying to build perf with a LLVM/Clang toolchain people see errors when testing for libperl feature.
Jiri reports:
Quoted 5 lines
I'm getting some other lto related error:
$ cat test-libperl.make.output clang-13: error: optimization flag '-ffat-lto-objects' is not supported [-Werror,-Wignored-optimization-argument]The reason is
PERL_EMBED_CCOPTSis defined in two places:
tools/build/feature/Makefiletools/perf/Makefile.configAs an result
FLAGS_PERL_EMBEDis set differently.For building perf '-ffat-lto-objects' is filtered-out:
$ git grep ffat-lto-objects tools/perf/ tools/perf/Makefile.config: PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))Sync
PERL_EMBED_CCOPTSintools/build/feature/Makefileto fix this.For a minimal fix for Linux v5.17 this here was preferred by Arnaldo.
Reported-by Jiri Olsa <[email protected]>Reported-by Arnaldo Carvalho de Melo <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Sedat Dilek <[email protected]>--- tools/build/feature/Makefile | 1 + 1 file changed, 1 insertion(+)tools/build/feature/Makefile +0
-0tools/build/feature/Makefile PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) · line 221
Quoted 4 lines
tools/build/feature/Makefile +1
-0@@ -218,6 +218,7 @@ PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS))it looks like this is not enough, at least on fedora 35
Quoted 4 lines
I had to add changes below on top of your patch, it fixed the perl feature detection and perf build itself, but I'm still getting error with perf/python.so:
Correct. This patch simply fixes the perl feature detection.
Quoted 40 lines
$ CC=clang make JOBS=1 ... GEN python/perf.so python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: file not recognized: file format not recognized clang-13: error: linker command failed with exit code 1 (use -v to see invocation) error: command 'clang' failed with exit status 1 cp: cannot stat 'python_ext_build/lib/perf*.so': No such file or directorywith:
$ file python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o python_ext_build/tmp/home/jolsa/kernel/linux-perf/tools/perf/util/python.o: LLVM IR bitcodedo you get clean compile with python lang enabled?
jirka
---
tools/build/feature/Makefile +2
-2@@ -217,9 +217,9 @@ strip-libs = $(filter-out -l%,$(1)) PERL_EMBED_LDOPTS = $(shell perl -MExtUtils::Embed -e ldopts 2>/dev/null) PERL_EMBED_LDFLAGS = $(call strip-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) -PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` +PERL_EMBED_CCOPTS := $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) +FLAGS_PERL_EMBED := $(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro $(OUTPUT)test-libperl.bin: $(BUILD) $(FLAGS_PERL_EMBED)tools/perf/Makefile.config +0
-0tools/perf/Makefile.config else · line 784
Quoted 8 lines
tools/perf/Makefile.config +1
-1@@ -778,7 +778,7 @@ else PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS)) PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null) PERL_EMBED_CCOPTS := $(filter-out -specs=%,$(PERL_EMBED_CCOPTS)) - PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) + PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS)) -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro PERL_EMBED_LDOPTS := $(filter-out -specs=%,$(PERL_EMBED_LDOPTS)) FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)I fixed that differently by (see [1]),
tools/perf/Makefile.config +1
-1@@ -213,7 +213,7 @@ endif # Treat warnings as errors unless directed not to ifneq ($(WERROR),0) - CORE_CFLAGS += -Werror + CORE_CFLAGS += -Werror -Wno-compound-token-split-by-macro CXXFLAGS += -Werror HOSTCFLAGS += -Werrorendif
This was sufficient here to build perf successfully. And maybe ifdef-ed for clang?
But all this is a follow-up?
[1] https://lore.kernel.org/lkml/CA+icZUUCO+gOPLZumu_rTOJz1_v7gRRYVzzEZ+RZPOZBmkqCQg@mail.gmail.com/
tools/perf/util/setup.py class install_lib(_install_lib): · line 49
Quoted 13 lines
tools/perf/util/setup.py +1
-1@@ -43,7 +43,7 @@ class install_lib(_install_lib): cflags = getenv('CFLAGS', '').split() # switch off several checks (need to be at the end of cflags list) -cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-DPYTHON_PERF' ] +cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls', '-Wno-ignored-optimization-argument', '-DPYTHON_PERF' ] if not cc_is_clang: cflags += ['-Wno-cast-function-type' ]Cannot say much to that.
Quoted 3 lines
Do we want to fix perf building with LLVM/Clang for Linux v5.17 final or later? Arnaldo?
Quoted 7 lines
Attached is the patch I use to build perf.
( As said in the initial report I wanted to test perf with -std=gnu11. ) ( Cannot say much if this related to perl v5.34 only. )- Sedat -
[1] https://lore.kernel.org/lkml/CA+icZUWHd4VTKNwBtuxt9-fHoiYV+Q7tQ809Cn83k8sbQ_uNHw@mail.gmail.com/
I am not familiar with your Red Hat / Fedore LLVM toolchain environment as I use Debian/unstable AMD64.
Also, I am not a perl expert.
Again, tools/ has its own build-system and rules other than top-level Makefile.
By building with...
CC=clang ...
You simply use the clang compiler, but *GNU binutils*.
My reproducer uses clang + LLVM (bin)utils by setting also for HOSTXX:
make V=1 -j4
HOSTCC=clang HOSTLD=ld.lld HOSTAR=llvm-ar
CC=clang LD=ld.lld AR=llvm-ar STRIP=llvm-strip
-C tools/perf
PYTHON=python3.10 install-bin
I highly suggest testing this first.
Please, have a look into:
[ tools/scripts/Makefile.include ]
ifneq ($(LLVM),)
$(call allow-override,CC,clang)
$(call allow-override,AR,llvm-ar)
$(call allow-override,LD,ld.lld)
$(call allow-override,CXX,clang++)
$(call allow-override,STRIP,llvm-strip)
...
endif
...
ifneq ($(LLVM),)
HOSTAR ?= llvm-ar HOSTCC ?= clang HOSTLD ?= ld.lld
...
endif
Furthermore, to pass unused compiler flags for clang we use in top-level Makefile:
[ Makefile ]
ifdef CONFIG_CC_IS_CLANGKBUILD_CPPFLAGS += -Qunused-arguments
...
endif
Again, tools/ ECO build-system is different. No nothing -Qunused-arguments passed to any (CPP)FLAGS.
The other possibility is to do this for perf like here (as you did):
[ tools/testing/selftests/bpf/Makefile ]
ifneq ($(LLVM),)
CFLAGS += -Wno-unused-command-line-argument
endif
NOTE: Cannot say to use "ifneq ($(LLVM),)" or check for CC_NO_CLANG or "ifeq ($(USE_CLANG), 1)" (see tools/perf/Makefile.perf).
Or even better in tools/scripts/Makefile.include. That's sort of "tools/ top-level Make(file) include".
But I guess the problem with perf and LLVM/Clang and specific versions of perl is the usage of -Werror.
I did:
[ tools/build/feature/Makefile ]
__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -Wno-compound-token-split-by-macro -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
[ tools/perf/Makefile.config ]
CORE_CFLAGS += -WerrorCORE_CFLAGS += -Werror -Wno-compound-token-split-by-macro
With those changes I am able to build perf with:
1. LLVM/Clang v13 and v14
2. LLVM (bin)utils v13 and v14
3. perf v5.34
4. -std=gnu11 (with some additional patches to tools/)
Might be worth testing with (UNTESTED):
[ tools/build/feature/Makefile ]
[ tools/perf/Makefile.config ]
ifneq ($(LLVM),)
CFLAGS += -Wno-unused-command-line-argument
CFLAGS += -Wno-compound-token-split-by-macro
CFLAGS += -Wno-ignored-optimization-argument
endif
The tools/ build-system is a mess and needs to be cleaned up.
And as Arnaldo pointed out:
Consolidate PERL_EMBED_XXX and XXX_PERL_EMBED in a single place.
Happy hacking!
- sed@ -