Some more bits for small BAR enabling
Subsystems (3)
v2 cover Some more bits for small BAR enabling
The leftover bits around dealing with stolen-local memory + small BAR, plus some related fixes.
v2: some tweaks based on feedback from Ville
Signature · 1 line
2.34.1
PATCH v2 1/8 drm/i915/lmem: don't treat small BAR as an error
Just pass along the probed io_size. The backend should be able to utilize the entire range here, even if some of it is non-mappable.
It does leave open with what to do with stolen local-memory.
--- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_region_lmem.c +4 -2
@@ -93,6 +93,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)struct intel_memory_region *mem;resource_size_t min_page_size;resource_size_t io_start; +resource_size_t io_size;resource_size_t lmem_size;int err;
@@ -124,7 +125,8 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) io_start =pci_resource_start (pdev,2 ); -if (GEM_WARN_ON (lmem_size >pci_resource_len (pdev,2 ))) + io_size =min (pci_resource_len (pdev,2 ), lmem_size); +if (!io_size)return ERR_PTR (-ENODEV ); min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K :
@@ -134,7 +136,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) lmem_size, min_page_size, io_start, - lmem_size, + io_size,INTEL_MEMORY_LOCAL ,0 , &intel_region_lmem_ops);
Signature · 1 line
2.34.1
PATCH v2 2/8 drm/i915/stolen: don't treat small BAR as an error
In reply to Matthew AuldFrom: Akeem G Abodunrin <[email protected]>
On client platforms with reduced LMEM BAR, we should be able to continue with driver load with reduced io_size. Instead of using the BAR size to determine the how large stolen should be, we should instead use the ADDR_RANGE register to figure this out(at least on platforms like DG2). For simplicity we don't attempt to support partially mappable stolen.
--- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 48 ++++++++++++++++------ drivers/gpu/drm/i915/i915_reg.h | 3 ++ 2 files changed, 38 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +35 -13
@@ -12,6 +12,8 @@#include "gem/i915_gem_lmem.h" #include "gem/i915_gem_region.h" +#include "gt/intel_gt.h" +#include "gt/intel_region_lmem.h" #include "i915_drv.h" #include "i915_gem_stolen.h" #include "i915_reg.h"
@@ -750,9 +752,9 @@ static int init_stolen_lmem(struct intel_memory_region *mem)if (GEM_WARN_ON (resource_size (&mem->region) ==0 ))return -ENODEV ; -if (!io_mapping_init_wc (&mem->iomap, - mem->io_start, - mem->io_size)) +if (mem->io_size && !io_mapping_init_wc (&mem->iomap, + mem->io_start, + mem->io_size))return -EIO ;/*
@@ -773,7 +775,8 @@ static int init_stolen_lmem(struct intel_memory_region *mem)static int release_stolen_lmem (struct intel_memory_region *mem) { -io_mapping_fini (&mem->iomap); +if (mem->io_size) +io_mapping_fini (&mem->iomap);i915_gem_cleanup_stolen (mem->i915);return 0 ; }
@@ -790,25 +793,43 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, {struct intel_uncore *uncore = &i915->uncore;struct pci_dev *pdev =to_pci_dev (i915->drm.dev); +resource_size_t dsm_size, dsm_base, lmem_size;struct intel_memory_region *mem; +resource_size_t io_start, io_size;resource_size_t min_page_size; -resource_size_t io_start; -resource_size_t lmem_size; -u64 lmem_base; - lmem_base =intel_uncore_read64 (uncore,GEN12_DSMBASE ); -if (GEM_WARN_ON (lmem_base >=pci_resource_len (pdev,2 ))) +if (WARN_ON_ONCE (instance))return ERR_PTR (-ENODEV ); - lmem_size =pci_resource_len (pdev,2 ) - lmem_base; - io_start =pci_resource_start (pdev,2 ) + lmem_base; +/* Use DSM base address instead for stolen memory */ + dsm_base =intel_uncore_read64 (uncore,GEN12_DSMBASE ); +if (IS_DG1 (uncore->i915)) { + lmem_size =pci_resource_len (pdev,2 ); +if (WARN_ON (lmem_size < dsm_base)) +return ERR_PTR (-ENODEV ); + }else { +resource_size_t lmem_range; + + lmem_range =intel_gt_read_register (&i915->gt0,XEHPSDV_TILE0_ADDR_RANGE ) &0xFFFF ; + lmem_size = lmem_range >>XEHPSDV_TILE_LMEM_RANGE_SHIFT ; + lmem_size *=SZ_1G ; + } + + dsm_size = lmem_size - dsm_base; +if (pci_resource_len (pdev,2 ) < lmem_size) { + io_start =0 ; + io_size =0 ; + }else { + io_start =pci_resource_start (pdev,2 ) + dsm_base; + io_size = dsm_size; + } min_page_size =HAS_64K_PAGES (i915) ?I915_GTT_PAGE_SIZE_64K :I915_GTT_PAGE_SIZE_4K ; - mem =intel_memory_region_create (i915, lmem_base, lmem_size, + mem =intel_memory_region_create (i915, dsm_base, dsm_size, min_page_size, - io_start, lmem_size, + io_start, io_size, type, instance, &i915_region_stolen_lmem_ops);if (IS_ERR (mem))
@@ -822,6 +843,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,drm_dbg (&i915->drm,"Stolen Local memory IO start: %pa\n" , &mem->io_start); +drm_dbg (&i915->drm,"Stolen Local DSM base: %pa\n" , &dsm_base);intel_memory_region_set_name (mem,"stolen-local" );
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -8466,6 +8466,9 @@ enum skl_power_gate {#define SGGI_DIS REG_BIT(15)#define SGR_DIS REG_BIT(13) +#define XEHPSDV_TILE0_ADDR_RANGE _MMIO(0x4900) +#define XEHPSDV_TILE_LMEM_RANGE_SHIFT 8 +#define XEHPSDV_FLAT_CCS_BASE_ADDR _MMIO(0x4910)#define XEHPSDV_CCS_BASE_SHIFT 8
Signature · 1 line
2.34.1
PATCH v2 3/8 drm/i915/stolen: consider I915_BO_ALLOC_GPU_ONLY
In reply to Matthew AuldKeep the behaviour consistent with normal lmem, where we assume CPU access if by default required.
--- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +8 -0
@@ -695,6 +695,14 @@ static int _i915_gem_object_stolen_init(struct intel_memory_region *mem,if (size ==0 )return -EINVAL ; +/* +* With discrete devices, where we lack a mappable aperture there is no +* possible way to ever access this memory on the CPU side. +*/ +if (mem->type ==INTEL_MEMORY_STOLEN_LOCAL && !mem->io_size && + !(flags &I915_BO_ALLOC_GPU_ONLY )) +return -ENOSPC ; + stolen =kzalloc (sizeof (*stolen),GFP_KERNEL );if (!stolen)return -ENOMEM ;
Signature · 1 line
2.34.1
PATCH v2 4/8 drm/i915: add i915_gem_object_create_region_at()
In reply to Matthew AuldAdd a generic interface for allocating an object at some specific offset, and convert stolen over. Later we will want to hook this up to different backends.
--- .../drm/i915/display/intel_plane_initial.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_create.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_region.c | 47 ++++++++++-- drivers/gpu/drm/i915/gem/i915_gem_region.h | 7 ++ drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 74 ++++--------------- drivers/gpu/drm/i915/gem/i915_gem_stolen.h | 4 - drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 1 + drivers/gpu/drm/i915/gt/intel_rc6.c | 8 +- drivers/gpu/drm/i915/intel_memory_region.h | 1 + drivers/gpu/drm/i915/selftests/mock_region.c | 1 + 12 files changed, 77 insertions(+), 74 deletions(-)
drivers/gpu/drm/i915/display/intel_plane_initial.c +3 -1
@@ -3,6 +3,7 @@* Copyright © 2021 Intel Corporation */ +#include "gem/i915_gem_region.h" #include "i915_drv.h" #include "intel_atomic_plane.h" #include "intel_display.h"
@@ -69,7 +70,8 @@ initial_plane_vma(struct drm_i915_private *i915, size * 2 > i915->stolen_usable_size)return NULL ; - obj =i915_gem_object_create_stolen_for_preallocated (i915, base, size); + obj =i915_gem_object_create_region_at (i915->mm.stolen_region, + base, size,0 );if (IS_ERR (obj))return NULL ;
drivers/gpu/drm/i915/gem/i915_gem_create.c +1 -1
@@ -123,7 +123,7 @@ __i915_gem_object_create_user_ext(struct drm_i915_private *i915, u64 size,*/ flags =I915_BO_ALLOC_USER ; - ret = mr->ops->init_object (mr, obj, size,0 , flags); + ret = mr->ops->init_object (mr, obj,I915_BO_INVALID_OFFSET , size,0 , flags);if (ret) goto object_free;
drivers/gpu/drm/i915/gem/i915_gem_region.c +41 -6
65 lines not on this page · raw message
drivers/gpu/drm/i915/gem/i915_gem_region.h +7 -0
@@ -14,6 +14,8 @@ struct sg_table;struct i915_gem_apply_to_region ; +#define I915_BO_INVALID_OFFSET ((resource_size_t)-1) +/** * struct i915_gem_apply_to_region_ops - ops to use when iterating over all * region objects.
@@ -56,6 +58,11 @@ i915_gem_object_create_region(struct intel_memory_region *mem,resource_size_t size, resource_size_t page_size, unsigned int flags); +struct drm_i915_gem_object * +i915_gem_object_create_region_at (struct intel_memory_region *mem, +resource_size_t offset, +resource_size_t size, +unsigned int flags);int i915_gem_process_region (struct intel_memory_region *mr,struct i915_gem_apply_to_region *apply);
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +1 -0
@@ -552,6 +552,7 @@ static int __create_shmem(struct drm_i915_private *i915,static int shmem_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj, +resource_size_t offset,resource_size_t size,resource_size_t page_size,unsigned int flags)
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +15 -59
92 lines not on this page · raw message
drivers/gpu/drm/i915/gem/i915_gem_stolen.h +0 -4
@@ -31,10 +31,6 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,struct drm_i915_gem_object *i915_gem_object_create_stolen (struct drm_i915_private *dev_priv,resource_size_t size); -struct drm_i915_gem_object * -i915_gem_object_create_stolen_for_preallocated (struct drm_i915_private *dev_priv, -resource_size_t stolen_offset, -resource_size_t size);bool i915_gem_object_is_stolen (const struct drm_i915_gem_object *obj);
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -0
@@ -1142,6 +1142,7 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)*/ int __i915_gem_ttm_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj, +resource_size_t offset,resource_size_t size,resource_size_t page_size,unsigned int flags)
drivers/gpu/drm/i915/gem/i915_gem_ttm.h +1 -0
@@ -45,6 +45,7 @@ i915_ttm_to_gem(struct ttm_buffer_object *bo)int __i915_gem_ttm_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj, +resource_size_t offset,resource_size_t size,resource_size_t page_size,unsigned int flags);
drivers/gpu/drm/i915/gt/intel_rc6.c +5 -3
@@ -6,6 +6,7 @@#include <linux/pm_runtime.h> #include <linux/string_helpers.h> +#include "gem/i915_gem_region.h" #include "i915_drv.h" #include "i915_reg.h" #include "i915_vgpu.h"
@@ -325,9 +326,10 @@ static int vlv_rc6_init(struct intel_rc6 *rc6)resource_size_t pcbr_offset; pcbr_offset = (pcbr & ~4095 ) - i915->dsm.start; - pctx =i915_gem_object_create_stolen_for_preallocated (i915, - pcbr_offset, - pctx_size); + pctx =i915_gem_object_create_region_at (i915->mm.stolen_region, + pcbr_offset, + pctx_size, +0 );if (IS_ERR (pctx))return PTR_ERR (pctx);
drivers/gpu/drm/i915/intel_memory_region.h +1 -0
@@ -54,6 +54,7 @@ struct intel_memory_region_ops {int (*init_object)(struct intel_memory_region *mem,struct drm_i915_gem_object *obj, +resource_size_t offset,resource_size_t size,resource_size_t page_size,unsigned int flags);
drivers/gpu/drm/i915/selftests/mock_region.c +1 -0
@@ -57,6 +57,7 @@ static const struct drm_i915_gem_object_ops mock_region_obj_ops = {static int mock_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj, +resource_size_t offset,resource_size_t size,resource_size_t page_size,unsigned int flags)
Signature · 1 line
2.34.1
PATCH v2 5/8 drm/i915/ttm: wire up the object offset
In reply to Matthew AuldFor the ttm backend we can use existing placements fpfn and lpfn to force the allocator to place the object at the requested offset, potentially evicting stuff if the spot is currently occupied.
--- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 ++ drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 18 ++++++++++++++---- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 3 ++- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++++++- drivers/gpu/drm/i915/intel_region_ttm.h | 1 + drivers/gpu/drm/i915/selftests/mock_region.c | 3 +++ 6 files changed, 28 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +2 -0
@@ -631,6 +631,8 @@ struct drm_i915_gem_object {struct drm_mm_node *stolen; +resource_size_t bo_offset; +unsigned long scratch;u64 encode;
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +14 -4
@@ -126,6 +126,8 @@ i915_ttm_select_tt_caching(const struct drm_i915_gem_object *obj)static void i915_ttm_place_from_region (const struct intel_memory_region *mr,struct ttm_place *place, +resource_size_t offset, +resource_size_t size,unsigned int flags) {memset (place,0 ,sizeof (*place));
@@ -133,7 +135,10 @@ i915_ttm_place_from_region(const struct intel_memory_region *mr,if (flags &I915_BO_ALLOC_CONTIGUOUS ) place->flags |=TTM_PL_FLAG_CONTIGUOUS ; -if (mr->io_size && mr->io_size < mr->total) { +if (offset !=I915_BO_INVALID_OFFSET ) { + place->fpfn = offset >>PAGE_SHIFT ; + place->lpfn = place->fpfn + (size >>PAGE_SHIFT ); + }else if (mr->io_size && mr->io_size < mr->total) {if (flags &I915_BO_ALLOC_GPU_ONLY ) { place->flags |=TTM_PL_FLAG_TOPDOWN ; }else {
@@ -155,12 +160,14 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj, placement->num_placement =1 ;i915_ttm_place_from_region (num_allowed ? obj->mm.placements[0 ] : - obj->mm.region, requested, flags); + obj->mm.region, requested, obj->bo_offset, + obj->base.size, flags);/* Cache this on object? */ placement->num_busy_placement = num_allowed;for (i =0 ; i < placement->num_busy_placement; ++i) -i915_ttm_place_from_region (obj->mm.placements[i], busy + i, flags); +i915_ttm_place_from_region (obj->mm.placements[i], busy + i, + obj->bo_offset, obj->base.size, flags);if (num_allowed ==0 ) { *busy = *requested;
@@ -802,7 +809,8 @@ static int __i915_ttm_migrate(struct drm_i915_gem_object *obj,struct ttm_placement placement;int ret; -i915_ttm_place_from_region (mr, &requested, flags); +i915_ttm_place_from_region (mr, &requested, obj->bo_offset, + obj->base.size, flags); placement.num_placement =1 ; placement.num_busy_placement =1 ; placement.placement = &requested;
@@ -1159,6 +1167,8 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,drm_gem_private_object_init (&i915->drm, &obj->base, size);i915_gem_object_init (obj, &i915_gem_ttm_obj_ops, &lock_class, flags); + obj->bo_offset = offset; +/* Don't put on a region list until we're either locked or fully initialized. */ obj->mm.region = mem;INIT_LIST_HEAD (&obj->mm.region_link);
drivers/gpu/drm/i915/i915_ttm_buddy_manager.c +2 -1
@@ -71,7 +71,8 @@ static int i915_ttm_buddy_man_alloc(struct ttm_resource_manager *man,GEM_BUG_ON (min_page_size < mm->chunk_size); -if (place->flags &TTM_PL_FLAG_CONTIGUOUS ) { +if (place->fpfn + bman_res->base.num_pages != place->lpfn && + place->flags &TTM_PL_FLAG_CONTIGUOUS ) {unsigned long pages; size =roundup_pow_of_two (size);
drivers/gpu/drm/i915/intel_region_ttm.c +6 -1
@@ -12,6 +12,7 @@#include "intel_region_ttm.h" +#include "gem/i915_gem_region.h" #include "gem/i915_gem_ttm.h" /* For the funcs/ops export only */ /** * DOC: TTM support structure
@@ -191,6 +192,7 @@ intel_region_ttm_resource_to_rsgt(struct intel_memory_region *mem,*/ struct ttm_resource *intel_region_ttm_resource_alloc (struct intel_memory_region *mem, +resource_size_t offset,resource_size_t size,unsigned int flags) {
@@ -202,7 +204,10 @@ intel_region_ttm_resource_alloc(struct intel_memory_region *mem,if (flags &I915_BO_ALLOC_CONTIGUOUS ) place.flags |=TTM_PL_FLAG_CONTIGUOUS ; -if (mem->io_size && mem->io_size < mem->total) { +if (offset !=I915_BO_INVALID_OFFSET ) { + place.fpfn = offset >>PAGE_SHIFT ; + place.lpfn = place.fpfn + (size >>PAGE_SHIFT ); + }else if (mem->io_size && mem->io_size < mem->total) {if (flags &I915_BO_ALLOC_GPU_ONLY ) { place.flags |=TTM_PL_FLAG_TOPDOWN ; }else {
drivers/gpu/drm/i915/intel_region_ttm.h +1 -0
@@ -36,6 +36,7 @@ struct ttm_device_funcs *i915_ttm_driver(void);#ifdef CONFIG_DRM_I915_SELFTEST struct ttm_resource *intel_region_ttm_resource_alloc (struct intel_memory_region *mem, +resource_size_t offset,resource_size_t size,unsigned int flags);#endif
drivers/gpu/drm/i915/selftests/mock_region.c +3 -0
@@ -26,6 +26,7 @@ static int mock_region_get_pages(struct drm_i915_gem_object *obj)int err; obj->mm.res =intel_region_ttm_resource_alloc (obj->mm.region, + obj->bo_offset, obj->base.size, obj->flags);if (IS_ERR (obj->mm.res))
@@ -71,6 +72,8 @@ static int mock_object_init(struct intel_memory_region *mem,drm_gem_private_object_init (&i915->drm, &obj->base, size);i915_gem_object_init (obj, &mock_region_obj_ops, &lock_class, flags); + obj->bo_offset = offset; + obj->read_domains =I915_GEM_DOMAIN_CPU |I915_GEM_DOMAIN_GTT ;i915_gem_object_set_cache_coherency (obj,I915_CACHE_NONE );
Signature · 1 line
2.34.1
PATCH v2 6/8 drm/i915/display: Check mappable aperture when pinning preallocated vma
In reply to Matthew AuldFrom: CQ Tang <[email protected]>
When system does not have mappable aperture, ggtt->mappable_end=0. In this case if we pass PIN_MAPPABLE when pinning vma, the pinning code will return -ENOSPC. So conditionally set PIN_MAPPABLE if HAS_GMCH().
--- drivers/gpu/drm/i915/display/intel_plane_initial.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_plane_initial.c +5 -1
@@ -51,6 +51,7 @@ initial_plane_vma(struct drm_i915_private *i915,struct drm_i915_gem_object *obj;struct i915_vma *vma;u32 base, size; +u64 pinctl;if (!mem || plane_config->size ==0 )return NULL ;
@@ -101,7 +102,10 @@ initial_plane_vma(struct drm_i915_private *i915,if (IS_ERR (vma)) goto err_obj; -if (i915_ggtt_pin (vma,NULL ,0 ,PIN_MAPPABLE |PIN_OFFSET_FIXED | base)) + pinctl =PIN_GLOBAL |PIN_OFFSET_FIXED | base; +if (HAS_GMCH (i915)) + pinctl |=PIN_MAPPABLE ; +if (i915_vma_pin (vma,0 ,0 , pinctl)) goto err_obj; if (i915_gem_object_is_tiled(obj) &&
Signature · 1 line
2.34.1
PATCH v2 7/8 drm/i915: fixup the initial fb base on DG1
In reply to Matthew AuldThe offset we get looks to be the exact start of DSM, but the inital_plane_vma expects the address to be relative.
v2(Ville):
- The base is actually the pre-programmed GGTT address, which is then meant to 1:1 map to somewhere inside dsm. In the case of dgpu the base looks to just be some offset within lmem, but this also happens to be the exact dsm start, on dg1. Therefore we should only need to fudge the physical address, before allocating from stolen.
- Bail if it's not located in dsm.
--- .../drm/i915/display/intel_plane_initial.c | 21 +++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_plane_initial.c +19 -2
@@ -50,7 +50,7 @@ initial_plane_vma(struct drm_i915_private *i915,struct intel_memory_region *mem = i915->mm.stolen_region;struct drm_i915_gem_object *obj;struct i915_vma *vma; -u32 base, size; +u32 base, phys_base, size;u64 pinctl;if (!mem || plane_config->size ==0 )
@@ -71,8 +71,25 @@ initial_plane_vma(struct drm_i915_private *i915, size * 2 > i915->stolen_usable_size)return NULL ; +/* +* On discrete, it looks like the GGTT base address should 1:1 map to +* somewhere in lmem. On DG1 for some reason this intersects with the +* exact start of DSM(possibly due to small lmem size), in which case we +* need to allocate it directly from stolen, which means fudging the +* physical address to be relative to the start of DSM. In such cases +* we might also need to choose between initial fb vs fbc, if space is +* limited. +*/ + phys_base = base; +if (IS_DG1 (i915)) { +if (WARN_ON (phys_base < i915->dsm.start)) +return NULL ; + + phys_base -= i915->dsm.start; + } + obj =i915_gem_object_create_region_at (i915->mm.stolen_region, - base, size,0 ); + phys_base, size,0 );if (IS_ERR (obj))return NULL ;
Signature · 1 line
2.34.1
PATCH v2 8/8 drm/i915: fixup the initial fb on DG2
In reply to Matthew AuldOn DG2+ the initial fb shouldn't be placed anywhere close to DSM, and so should just be allocated directly from LMEM.
--- .../drm/i915/display/intel_plane_initial.c | 46 +++++++++++-------- 1 file changed, 27 insertions(+), 19 deletions(-)
drivers/gpu/drm/i915/display/intel_plane_initial.c +27 -19
@@ -58,6 +58,31 @@ initial_plane_vma(struct drm_i915_private *i915, base =round_down (plane_config->base,I915_GTT_MIN_ALIGNMENT ); + phys_base = base; +if (IS_DGFX (i915)) { +/* +* On discrete, it looks like the GGTT base address should 1:1 +* map to somewhere in lmem. On DG1 for some reason this +* intersects with the exact start of DSM(possibly due to small +* lmem size), in which case we need to allocate it directly +* from stolen, which means fudging the physical address to be +* relative to the start of DSM. In such cases we might also +* need to choose between initial fb vs fbc, if space is +* limited. +* +* On future discrete HW, like DG2, we should be able to just +* allocate directly from lmem it seems. +*/ +if (IS_DG1 (i915)) { +if (WARN_ON (phys_base < i915->dsm.start)) +return NULL ; + + phys_base -= i915->dsm.start; + }else { + mem = i915->mm.regions[INTEL_REGION_LMEM ]; + } + } + size =round_up (plane_config->base + plane_config->size, mem->min_page_size); size -= base;
@@ -68,28 +93,11 @@ initial_plane_vma(struct drm_i915_private *i915,* features. */ if (IS_ENABLED (CONFIG_FRAMEBUFFER_CONSOLE ) && + mem == i915->mm.stolen_region && size *2 > i915->stolen_usable_size)return NULL ; -/* -* On discrete, it looks like the GGTT base address should 1:1 map to -* somewhere in lmem. On DG1 for some reason this intersects with the -* exact start of DSM(possibly due to small lmem size), in which case we -* need to allocate it directly from stolen, which means fudging the -* physical address to be relative to the start of DSM. In such cases -* we might also need to choose between initial fb vs fbc, if space is -* limited. -*/ - phys_base = base; -if (IS_DG1 (i915)) { -if (WARN_ON (phys_base < i915->dsm.start)) -return NULL ; - - phys_base -= i915->dsm.start; - } - - obj =i915_gem_object_create_region_at (i915->mm.stolen_region, - phys_base, size,0 ); + obj =i915_gem_object_create_region_at (mem, phys_base, size,0 );if (IS_ERR (obj))return NULL ;
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Some more bits for small BAR enabling (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: Some more bits for small BAR enabling (rev2)
URL : https://patchwork.freedesktop.org/series/101052/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for Some more bits for small BAR enabling (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: Some more bits for small BAR enabling (rev2)
URL : https://patchwork.freedesktop.org/series/101052/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11348 -> Patchwork_22530
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22530 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_22530, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/index.html
Participating hosts (45 -> 43)
------------------------------
Additional (2): fi-kbl-soraka bat-adlp-4
Missing (4): fi-bsw-cyan shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22530:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- fi-icl-u2: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/fi-icl-u2/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-icl-u2/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_22530 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-kbl-soraka/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-adlp-4: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-kbl-soraka/igt@[email protected]
* igt@kms_chamelium@vga-hpd-fast:
- bat-adlp-4: NOTRUN -> [SKIP][10] ([fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-4: NOTRUN -> [SKIP][11] ([i915#4103]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- bat-adlp-4: NOTRUN -> [DMESG-WARN][12] ([i915#3576])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@kms_flip@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-kbl-soraka/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#3555])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-adlp-4: NOTRUN -> [SKIP][16] ([i915#3291] / [i915#3708]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][17] ([i915#3301] / [i915#3708])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-adlp-4/igt@[email protected]
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][18] ([i915#2426] / [i915#4312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-bdw-5557u/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: [FAIL][19] ([i915#4032]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/bat-dg1-6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-dg1-6/igt@[email protected]
* igt@i915_selftest@live@guc_multi_lrc:
- {bat-rpls-2}: [DMESG-WARN][21] ([i915#4391]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/bat-rpls-2/igt@i915_selftest@live@guc_multi_lrc.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/bat-rpls-2/igt@i915_selftest@live@guc_multi_lrc.html
#### Warnings ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-rkl-guc: [SKIP][23] ([i915#4103]) -> [SKIP][24] ([i915#4070] / [i915#4103]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/fi-rkl-guc/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-rkl-guc/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-rkl-guc: [SKIP][25] ([i915#533]) -> [SKIP][26] ([i915#4070] / [i915#533])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11348/fi-rkl-guc/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/fi-rkl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5195]: https://gitlab.freedesktop.org/drm/intel/issues/5195
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11348 -> Patchwork_22530
CI-20190529: 20190529
CI_DRM_11348: 896acee3ca564ae87ab881c4805a600271a128b2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6373: 82306f1903c0fee8371f43a156d8b63163ca61c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22530: df36cd523c332c53dd33e990e86bdb064f948fd3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
df36cd523c33 drm/i915: fixup the initial fb on DG2865eb667480e drm/i915: fixup the initial fb base on DG114d92eec8c61 drm/i915/display: Check mappable aperture when pinning preallocated vma d649be32b4a9 drm/i915/ttm: wire up the object offsetae90e08b508f drm/i915: add i915_gem_object_create_region_at() 7c691e037d8b drm/i915/stolen: consider I915_BO_ALLOC_GPU_ONLY 0e78208ae76f drm/i915/stolen: don't treat small BAR as an error 84af38f3cbd9 drm/i915/lmem: don't treat small BAR as an error
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22530/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Some more bits for small BAR enabling (rev3)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: Some more bits for small BAR enabling (rev3)
URL : https://patchwork.freedesktop.org/series/101052/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Some more bits for small BAR enabling (rev3)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: Some more bits for small BAR enabling (rev3)
URL : https://patchwork.freedesktop.org/series/101052/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11349 -> Patchwork_22532
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/index.html
Participating hosts (51 -> 44)
------------------------------
Additional (1): bat-jsl-2
Missing (8): fi-ilk-m540 shard-tglu fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 shard-rkl shard-dg1 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_22532 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-bsw-n3050/igt@amdgpu/[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][2] -> [INCOMPLETE][3] ([i915#3921])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/fi-snb-2600/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-snb-2600/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][4] -> [DMESG-FAIL][5] ([i915#4528])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/fi-blb-e6850/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-blb-e6850/igt@i915_selftest@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#4269])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/fi-cml-u2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-cml-u2/igt@[email protected]
* igt@runner@aborted:
- fi-blb-e6850: NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#2403] / [i915#4312])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-blb-e6850/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@active:
- {bat-rpls-2}: [DMESG-WARN][9] ([i915#4391]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/bat-rpls-2/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [INCOMPLETE][11] ([i915#2940]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/fi-bsw-n3050/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-bsw-n3050/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@hugepages:
- {bat-rpls-2}: [DMESG-WARN][13] ([i915#5278]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/bat-rpls-2/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [INCOMPLETE][15] ([i915#4983]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/bat-rpls-2/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@flip:
- {bat-adlp-6}: [DMESG-WARN][17] ([i915#3576]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/bat-adlp-6/igt@kms_busy@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/bat-adlp-6/igt@kms_busy@[email protected]
- {bat-dg2-9}: [DMESG-WARN][19] ([i915#5195]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/bat-dg2-9/igt@kms_busy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/bat-dg2-9/igt@kms_busy@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][21] ([i915#295]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/fi-cfl-8109u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-cfl-8109u/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][23] ([i915#295]) -> [PASS][24] +10 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/fi-cfl-8109u/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/fi-cfl-8109u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5068]: https://gitlab.freedesktop.org/drm/intel/issues/5068
[i915#5195]: https://gitlab.freedesktop.org/drm/intel/issues/5195
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11349 -> Patchwork_22532
CI-20190529: 20190529
CI_DRM_11349: 47cea122bb4617b37f3974d066b9bea91b5c6581 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6374: f187d4eb6c765e3b2b5a7acf22522fc6a22a9254 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22532: 31d01e024a585ef79da323a6a992ce648359d59d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
31d01e024a58 drm/i915: fixup the initial fb on DG2b3304011c642 drm/i915: fixup the initial fb base on DG119531e7c9f2a drm/i915/display: Check mappable aperture when pinning preallocated vma 523a78601113 drm/i915/ttm: wire up the object offsetd835c469d785 drm/i915: add i915_gem_object_create_region_at() d305e3a5d7f7 drm/i915/stolen: consider I915_BO_ALLOC_GPU_ONLY 72cc1359cc1d drm/i915/stolen: don't treat small BAR as an error 84865b4fed7c drm/i915/lmem: don't treat small BAR as an error
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for Some more bits for small BAR enabling (rev3)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: Some more bits for small BAR enabling (rev3)
URL : https://patchwork.freedesktop.org/series/101052/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11349_full -> Patchwork_22532_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22532_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_22532_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22532_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_vblank@pipe-b-ts-continuation-idle:
- shard-apl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-apl4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl8/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_22532_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][3] ([i915#4991])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl1/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- shard-skl: NOTRUN -> [SKIP][4] ([fdo#109271]) +61 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl9/igt@gem_ctx_persistence@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-kbl: NOTRUN -> [DMESG-WARN][5] ([i915#5076]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl1/igt@[email protected]
* igt@gem_exec_capture@pi@bcs0:
- shard-skl: [PASS][6] -> [INCOMPLETE][7] ([i915#4547])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl6/igt@gem_exec_capture@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl7/igt@gem_exec_capture@[email protected]
* igt@gem_exec_capture@pi@vcs1:
- shard-iclb: NOTRUN -> [INCOMPLETE][8] ([i915#3371])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb4/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][9] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl9/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-iclb6/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-kbl7/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-glk1/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: NOTRUN -> [FAIL][16] ([i915#2842]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-normal:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#118]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-glk9/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk4/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl3/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl7/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#4613])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-iclb: NOTRUN -> [SKIP][22] ([i915#4270])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@gem_render_copy@y-tiled-to-vebox-x-tiled:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#768])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][24] ([i915#4991])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl3/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#3297])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-kbl: NOTRUN -> [FAIL][26] ([i915#3318])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl1/igt@[email protected]
* igt@gen9_exec_parse@bb-start-cmd:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#2856])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: NOTRUN -> [FAIL][28] ([i915#454])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109289])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271]) +30 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl1/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#110892])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [PASS][32] -> [DMESG-WARN][33] ([i915#180])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-kbl4/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl4/igt@[email protected]
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][34] ([i915#4272])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl3/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#5286])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3777]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#110723])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278] / [i915#3886]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl2/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl9/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3886]) +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615] / [i915#3689])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb1/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_chamelium@dp-frame-dump:
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +5 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk1/igt@[email protected]
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl9/igt@[email protected]
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +7 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl7/igt@[email protected]
* igt@kms_color@pipe-d-degamma:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278] / [i915#1149])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-gamma:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl8/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109279] / [i915#3359])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278] / [fdo#109279])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-random:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#3319])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x85-random:
- shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271]) +43 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk5/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge:
- shard-skl: [PASS][54] -> [DMESG-WARN][55] ([i915#1982])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl9/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl1/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278]) +16 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109274] / [fdo#109278])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#2346] / [i915#533])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled:
- shard-iclb: NOTRUN -> [SKIP][60] ([i915#5287])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#5287])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][62] -> [INCOMPLETE][63] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-apl2/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl4/igt@[email protected]
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109274]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-edp1:
- shard-skl: [PASS][65] -> [FAIL][66] ([i915#2122]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl7/igt@kms_flip@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [PASS][67] -> [INCOMPLETE][68] ([i915#1982] / [i915#4839])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl10/igt@kms_flip@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +66 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#109280] / [fdo#111825]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109280]) +8 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-dp-1-pipe-a:
- shard-apl: [PASS][72] -> [DMESG-WARN][73] ([i915#180]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-apl4/igt@kms_hdr@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl8/igt@kms_hdr@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-glk: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#533]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk5/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#533])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl3/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#533])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][77] ([fdo#108145] / [i915#265])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][78] -> [FAIL][79] ([fdo#108145] / [i915#265])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl4/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][80] ([fdo#108145] / [i915#265])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][81] ([fdo#108145] / [i915#265]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][82] ([fdo#108145] / [i915#265])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk5/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#3536])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#5288])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109441])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109441]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@invalid-clone-single-crtc:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#3555])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [PASS][90] -> [FAIL][91] ([i915#43])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-glk8/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-glk1/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2437])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl3/igt@[email protected]
* igt@nouveau_crc@pipe-c-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#2530])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@[email protected]
* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109278] / [i915#2530])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@[email protected]
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109291])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb5/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@prime_vgem@fence-write-hang:
- shard-tglb: NOTRUN -> [SKIP][96] ([fdo#109295])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@[email protected]
* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl7/igt@[email protected]
* igt@sysfs_preempt_timeout@timeout@vecs0:
- shard-skl: [PASS][98] -> [FAIL][99] ([i915#3259])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl7/igt@sysfs_preempt_timeout@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-skl2/igt@sysfs_preempt_timeout@[email protected]
* igt@tools_test@sysfs_l3_parity:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109307])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb8/igt@tools_test@sysfs_l3_parity.html
#### Possible fixes ####
* igt@drm_read@short-buffer-nonblock:
- {shard-rkl}: [SKIP][101] ([i915#4098]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-5/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-6/igt@[email protected]
* igt@gem_exec_capture@pi@vcs0:
- shard-iclb: [INCOMPLETE][103] ([i915#3371]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-iclb1/igt@gem_exec_capture@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb4/igt@gem_exec_capture@[email protected]
* igt@gem_exec_capture@pi@vcs1:
- shard-tglb: [INCOMPLETE][105] ([i915#3371]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-tglb3/igt@gem_exec_capture@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][107] ([i915#2842]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-tglb2/igt@gem_exec_fair@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][109] ([i915#2842]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-kbl7/igt@gem_exec_fair@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][111] ([i915#2842]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-apl7/igt@gem_exec_fair@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][113] ([i915#2849]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-iclb5/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][115] ([i915#2190]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-tglb7/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglb3/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][117] ([i915#180]) -> [PASS][118] +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-apl1/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-apl1/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- {shard-tglu}: [DMESG-WARN][119] ([i915#402]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-tglu-5/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-tglu-1/igt@[email protected]
* igt@kms_big_fb@linear-max-hw-stride-64bpp-rotate-180:
- {shard-rkl}: [SKIP][121] ([i915#1845]) -> [PASS][122] +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-5/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-6/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][123] ([i915#1845] / [i915#4098]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-5/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-6/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-c-invalid-degamma-lut-sizes:
- {shard-rkl}: [SKIP][125] ([i915#4070]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-1/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
- {shard-rkl}: [SKIP][127] ([fdo#112022] / [i915#4070]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-5/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge:
- {shard-rkl}: [SKIP][129] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][130] +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-5/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@all-pipes-forked-bo:
- {shard-rkl}: [INCOMPLETE][131] -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-rkl-5/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/shard-rkl-1/igt@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-skl: [FAIL][133] ([i915#3927]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11349/shard-skl2/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[134]: h
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22532/index.html
The series is Acked-by: Nirmoy Das <[email protected]>
Quoted 5 lines · Matthew Auld
The leftover bits around dealing with stolen-local memory + small BAR, plus some related fixes.
v2: some tweaks based on feedback from Ville
Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/display: Check mappable aperture when pinning preallocated vma
In reply to Matthew AuldQuoted 7 lines · Matthew Auld
From: CQ Tang <[email protected]>
When system does not have mappable aperture, ggtt->mappable_end=0. In this case if we pass
PIN_MAPPABLEwhen pinning vma, the pinning code will return-ENOSPC. So conditionally setPIN_MAPPABLEifHAS_GMCH().
Quoted 7 lines
Suggested-by Chris P Wilson <[email protected]>Signed-off-by CQ Tang <[email protected]>Cc Radhakrishna Sripada <[email protected]>Cc Ap Kamal <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>Cc Ville Syrjälä <[email protected]>
This at least prevents incorrectly using PIN_MAPPABLE on discrete,
Quoted 31 lines
--- drivers/gpu/drm/i915/display/intel_plane_initial.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_plane_initial.c +5
-2@@ -51,6 +51,7 @@ initial_plane_vma(struct drm_i915_private *i915,struct drm_i915_gem_object *obj;struct i915_vma *vma;u32 base, size; +u64 pinctl;if (!mem || plane_config->size ==0 )return NULL ;@@ -101,7 +102,10 @@ initial_plane_vma(struct drm_i915_private *i915,if (IS_ERR (vma)) goto err_obj; -if (i915_ggtt_pin (vma,NULL ,0 ,PIN_MAPPABLE |PIN_OFFSET_FIXED | base)) + pinctl =PIN_GLOBAL |PIN_OFFSET_FIXED | base; +if (HAS_GMCH (i915)) + pinctl |=PIN_MAPPABLE ; +if (i915_vma_pin (vma,0 ,0 , pinctl)) goto err_obj; if (i915_gem_object_is_tiled(obj) && --2.34.1