firmware: qcom_scm: Add compatible for ipq806x
PATCH 1/1 firmware: qcom_scm: Add compatible for ipq806x
Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require Core, Iface or Bus clock.
--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)
drivers/firmware/qcom_scm.c +1 -0
@@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {SCM_HAS_IFACE_CLK | SCM_HAS_BUS_CLK) }, + { .compatible = "qcom,scm-ipq806x" }, { .compatible = "qcom,scm-ipq4019" }, { .compatible = "qcom,scm-mdm9607", .data = (void *)(SCM_HAS_CORE_CLK | SCM_HAS_IFACE_CLK |
Signature · 1 line
2.34.1
Quoted 13 lines · Ansuel Smith
Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require Core, Iface or Bus clock.
Signed-off-by Ansuel Smith <[email protected]>--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom_scm.c +0
-0
drivers/firmware/qcom_scm.c static const struct of_device_id qcom_scm_dt_match[] = { · line 1341
Quoted 4 lines
drivers/firmware/qcom_scm.c +1
-0@@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {SCM_HAS_IFACE_CLK | SCM_HAS_BUS_CLK) }, + { .compatible = "qcom,scm-ipq806x" },
If you in your dt do:
compatible = "qcom,scm-ipq806x", "qcom,scm";
Then we don't need to update the driver for each platform, only the DT binding.
And if we some day need to quirk something off qcom,scm-ipq806x we have that option.
Thanks,
Bjorn
Quoted 6 lines
drivers/firmware/qcom_scm.c +0
-0{ .compatible = "qcom,scm-ipq4019" }, { .compatible = "qcom,scm-mdm9607", .data = (void *)(SCM_HAS_CORE_CLK | SCM_HAS_IFACE_CLK |Signature · 1 line
2.34.1
Quoted 23 lines · Bjorn Andersson
Quoted 13 lines · Ansuel Smith
Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require Core, Iface or Bus clock.
Signed-off-by Ansuel Smith <[email protected]>--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom_scm.c +0
-0drivers/firmware/qcom_scm.c static const struct of_device_id qcom_scm_dt_match[] = { · line 1341
Quoted 4 lines
drivers/firmware/qcom_scm.c +1
-0@@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {SCM_HAS_IFACE_CLK | SCM_HAS_BUS_CLK) }, + { .compatible = "qcom,scm-ipq806x" },If you in your dt do:
Quoted 7 lines
compatible = "qcom,scm-ipq806x", "qcom,scm";Then we don't need to update the driver for each platform, only the DT binding.
And if we some day need to quirk something off qcom,scm-ipq806x we have that option.
I suppose that ipq806x might need SCM_HAS_CORE_CLK. Or, more likely, an interconnect vote, once we have interconnect drivers for ipq/apq8064 platforms.
Quoted 10 lines
Thanks,
BjornQuoted 6 lines
drivers/firmware/qcom_scm.c +0
-1{ .compatible = "qcom,scm-ipq4019" }, { .compatible = "qcom,scm-mdm9607", .data = (void *)(SCM_HAS_CORE_CLK | SCM_HAS_IFACE_CLK | --2.34.1
Signature · 2 lines
With best wishes Dmitry
Quoted 30 lines · Dmitry Baryshkov
Quoted 28 lines · Bjorn Andersson
Quoted 13 lines · Ansuel Smith
Add compatible for ipq806x. Just like ipq4019, ipq806x doesn't require Core, Iface or Bus clock.
Signed-off-by Ansuel Smith <[email protected]>--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom_scm.c +0
-0drivers/firmware/qcom_scm.c static const struct of_device_id qcom_scm_dt_match[] = { · line 1341
Quoted 4 lines
drivers/firmware/qcom_scm.c +1
-0@@ -1338,6 +1338,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {SCM_HAS_IFACE_CLK | SCM_HAS_BUS_CLK) }, + { .compatible = "qcom,scm-ipq806x" },If you in your dt do:
compatible = "qcom,scm-ipq806x", "qcom,scm";Then we don't need to update the driver for each platform, only the DT binding.
Quoted 7 lines
Quoted 2 lines
And if we some day need to quirk something off qcom,scm-ipq806x we have that option.
I suppose that ipq806x might need
SCM_HAS_CORE_CLK. Or, more likely, an interconnect vote, once we have interconnect drivers for ipq/apq8064 platforms.
From an old source I found that scm core clock comes from dfab_clk (DAYTONA_FABRIC). I notice there is an interconnect driver for rpm (bw is handled by rpm on ipq/apq8064) but why this should be related to scm core clk? To handle the clock voter stuff? (I assume a voter logic is not supported upstream)
But it does seems an interesting project adding interconnect support for ipq8064 also considering I have a fab scaling driver present from ages that I hane no idea how to handle.
Quoted 16 lines
Quoted 10 lines
Thanks,
BjornQuoted 6 lines
drivers/firmware/qcom_scm.c +0
-1{ .compatible = "qcom,scm-ipq4019" }, { .compatible = "qcom,scm-mdm9607", .data = (void *)(SCM_HAS_CORE_CLK | SCM_HAS_IFACE_CLK | --2.34.1
Signature · 2 lines
With best wishes Dmitry
Signature · 1 line
Ansuel