mm: remove unneeded local variable follflags
Subsystems (3)
PATCH v2 1/1 mm: remove unneeded local variable follflags
We can pass FOLL_GET | FOLL_DUMP to follow_page directly to simplify the code a bit in add_page_for_migration and split_huge_pages_pid.
Reviewed-by Anshuman Khandual <[email protected]>
Signed-off-by Miaohe Lin <[email protected]>
---v1->v2:
do similar instance in add_page_for_migration per Anshuman collect Reviewed-by tag. Thanks Anshuman for review.
--- mm/huge_memory.c | 4 +--- mm/migrate.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)
mm/huge_memory.c +1 -3
@@ -2840,7 +2840,6 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start,*/ for (addr = vaddr_start; addr < vaddr_end; addr +=PAGE_SIZE ) {struct vm_area_struct *vma =find_vma (mm, addr); -unsigned int follflags;struct page *page;if (!vma || addr < vma->vm_start)
@@ -2853,8 +2852,7 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, }/* FOLL_DUMP to ignore special (like zero) pages */ - follflags =FOLL_GET |FOLL_DUMP ; - page =follow_page (vma, addr, follflags); + page =follow_page (vma, addr,FOLL_GET |FOLL_DUMP );if (IS_ERR (page))continue ;
mm/migrate.c +1 -3
@@ -1604,7 +1604,6 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, {struct vm_area_struct *vma;struct page *page; -unsigned int follflags;int err;mmap_read_lock (mm);
@@ -1614,8 +1613,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, goto out;/* FOLL_DUMP to ignore special (like zero) pages */ - follflags =FOLL_GET |FOLL_DUMP ; - page =follow_page (vma, addr, follflags); + page =follow_page (vma, addr,FOLL_GET |FOLL_DUMP ); err =PTR_ERR (page);if (IS_ERR (page))
Signature · 1 line
2.23.0