Skip to contentSkip to conversation

vdpa: Update man page with added support to configure max vq pair

PATCH Applied Eli Cohen 4 participants 5 messages Mar 15, 2022 – Mar 18, 2022

Subsystems (3)
lore
Share & tools
lore

Eli Cohen

author
#0 lore raw

PATCH 1/1 vdpa: Update man page with added support to configure max vq pair

Update man page to include information how to configure the max virtqueue pairs for a vdpa device when creating one.

---
 man/man8/vdpa-dev.8 | 6 ++++++
 1 file changed, 6 insertions(+)
man/man8/vdpa-dev.8 +6 -0
index aa21ae3acbd8..432867c65182 100644
@@ -33,6 +33,7 @@ vdpa-dev \- vdpa device configuration
 .I MGMTDEV
 .RI "[ mac " MACADDR " ]"
 .RI "[ mtu " MTU " ]"
+.RI "[ max_vqp " MAX_VQ_PAIRS " ]"
 
 .ti -8
 .B vdpa dev del
@@ -119,6 +120,11 @@ vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000
 Add the vdpa device named foo on the management device vdpa_sim_net with mac address of 00:11:22:33:44:55 and mtu of 9000 bytes.
 .RE
 .PP
+vdpa dev add name foo mgmtdev auxiliary/mlx5_core.sf.1 mac 00:11:22:33:44:55 max_vqp 8
+.RS 4
+Add the vdpa device named foo on the management device auxiliary/mlx5_core.sf.1 with mac address of 00:11:22:33:44:55 and max 8 virtqueue pairs
+.RE
+.PP
 vdpa dev del foo
 .RS 4
 Delete the vdpa device named foo which was previously created.
Signature · 1 line
2.35.1
#1 lore raw
This patch was applied to iproute2/iproute2-next.git (main) by David Ahern <[email protected]>:

Hello:

This patch was applied to iproute2/iproute2-next.git (main) by David Ahern <[email protected]>:

Quoted 7 lines · On Tue, 15 Mar 2022 15:13:58 +0200 you wrote:

Update man page to include information how to configure the max virtqueue pairs for a vdpa device when creating one.

---
 man/man8/vdpa-dev.8 | 6 ++++++
 1 file changed, 6 insertions(+)

Here is the summary with links:
- vdpa: Update man page with added support to configure max vq pair

    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=8130653dabe6

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Acked-by on v1 1/1
#2 lore raw
In reply to Eli Cohen
Quoted 5 lines · Eli Cohen

Update man page to include information how to configure the max virtqueue pairs for a vdpa device when creating one.

Quoted 29 lines
---
 man/man8/vdpa-dev.8 | 6 ++++++
 1 file changed, 6 insertions(+)
man/man8/vdpa-dev.8 +6 -1
index aa21ae3acbd8..432867c65182 100644
@@ -33,6 +33,7 @@ vdpa-dev \- vdpa device configuration
 .I MGMTDEV
 .RI "[ mac " MACADDR " ]"
 .RI "[ mtu " MTU " ]"
+.RI "[ max_vqp " MAX_VQ_PAIRS " ]"
 
 .ti -8
 .B vdpa dev del
@@ -119,6 +120,11 @@ vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000
 Add the vdpa device named foo on the management device vdpa_sim_net with mac address of 00:11:22:33:44:55 and mtu of 9000 bytes.
 .RE
 .PP
+vdpa dev add name foo mgmtdev auxiliary/mlx5_core.sf.1 mac 00:11:22:33:44:55 max_vqp 8
+.RS 4
+Add the vdpa device named foo on the management device auxiliary/mlx5_core.sf.1 with mac address of 00:11:22:33:44:55 and max 8 virtqueue pairs
+.RE
+.PP
 vdpa dev del foo
 .RS 4
 Delete the vdpa device named foo which was previously created.
--
Quoted 2 lines

2.35.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reviewed-by on v1 1/1
#3 lore raw
In reply to Eli Cohen
Quoted 13 lines · Eli Cohen

Update man page to include information how to configure the max virtqueue pairs for a vdpa device when creating one.

---
  man/man8/vdpa-dev.8 | 6 ++++++
  1 file changed, 6 insertions(+)
man/man8/vdpa-dev.8 +0 -0
index aa21ae3acbd8..432867c65182 100644

man/man8/vdpa-dev.8 vdpa-dev \- vdpa device configuration · line 36

Quoted 4 lines
man/man8/vdpa-dev.8 +1 -0
@@ -33,6 +33,7 @@ vdpa-dev \- vdpa device configuration
  .I MGMTDEV
  .RI "[ mac " MACADDR " ]"
  .RI "[ mtu " MTU " ]"
+.RI "[ max_vqp " MAX_VQ_PAIRS " ]"

Here it introduces the max_vqp option to the SYNOPSIS. I would be nice to describe what it means and which device type is applicable in the below section:

Quoted 9 lines

.PP
.BI mac " MACADDR"
- specifies the mac address for the new vdpa device.
This is applicable only for the network type of vdpa device. This is optional.

.BI mtu " MTU"
- specifies the mtu for the new vdpa device.
This is applicable only for the network type of vdpa device. This is optional.

Otherwise looks good to me.

Thanks,
-Siwei

Quoted 5 lines

.ti -8
.B vdpa dev del

man/man8/vdpa-dev.8 +0 -0
@@ -119,6 +120,11 @@ vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000
  Add the vdpa device named foo on the management device vdpa_sim_net with mac address of 00:11:22:33:44:55 and mtu of 9000 bytes.

man/man8/vdpa-dev.8 vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000 · line 130

Quoted 10 lines
man/man8/vdpa-dev.8 +5 -0
  .RE
  .PP
+vdpa dev add name foo mgmtdev auxiliary/mlx5_core.sf.1 mac 00:11:22:33:44:55 max_vqp 8
+.RS 4
+Add the vdpa device named foo on the management device auxiliary/mlx5_core.sf.1 with mac address of 00:11:22:33:44:55 and max 8 virtqueue pairs
+.RE
+.PP
  vdpa dev del foo
  .RS 4
  Delete the vdpa device named foo which was previously created.

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reviewed-by on v1 1/1
#4 lore raw
In reply to Eli Cohen
Quoted 13 lines · Eli Cohen

Update man page to include information how to configure the max virtqueue pairs for a vdpa device when creating one.

---
  man/man8/vdpa-dev.8 | 6 ++++++
  1 file changed, 6 insertions(+)
man/man8/vdpa-dev.8 +0 -0
index aa21ae3acbd8..432867c65182 100644

man/man8/vdpa-dev.8 vdpa-dev \- vdpa device configuration · line 37

Quoted 5 lines
man/man8/vdpa-dev.8 +1 -0
@@ -33,6 +33,7 @@ vdpa-dev \- vdpa device configuration
  .I MGMTDEV
  .RI "[ mac " MACADDR " ]"
  .RI "[ mtu " MTU " ]"
+.RI "[ max_vqp " MAX_VQ_PAIRS " ]"
 

Here it introduces the max_vqp option to the SYNOPSIS. I would be nice to describe what it means and which device type is applicable in the below section:

Quoted 9 lines

.PP
.BI mac " MACADDR"
- specifies the mac address for the new vdpa device.
This is applicable only for the network type of vdpa device. This is optional.

.BI mtu " MTU"
- specifies the mtu for the new vdpa device.
This is applicable only for the network type of vdpa device. This is optional.

Otherwise looks good to me.

Thanks,
-Siwei

Quoted 4 lines

.ti -8
.B vdpa dev del

man/man8/vdpa-dev.8 +0 -0
@@ -119,6 +120,11 @@ vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000
  Add the vdpa device named foo on the management device vdpa_sim_net with mac address of 00:11:22:33:44:55 and mtu of 9000 bytes.

man/man8/vdpa-dev.8 vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000 · line 130

Quoted 10 lines
man/man8/vdpa-dev.8 +5 -0
  .RE
  .PP
+vdpa dev add name foo mgmtdev auxiliary/mlx5_core.sf.1 mac 00:11:22:33:44:55 max_vqp 8
+.RS 4
+Add the vdpa device named foo on the management device auxiliary/mlx5_core.sf.1 with mac address of 00:11:22:33:44:55 and max 8 virtqueue pairs
+.RE
+.PP
  vdpa dev del foo
  .RS 4
  Delete the vdpa device named foo which was previously created.

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization