nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH
Subsystems (2)
Christoph Hellwig
maintainerPATCH 1/1 nvme: warn about shared namespaces without CONFIG_NVME_MULTIPATH
Start warning about exposing a namespace as multiple block devices, and set a fixed deprecation release.
--- drivers/block/loop.c | 1 + drivers/nvme/host/core.c | 8 ++++++++ 2 files changed, 9 insertions(+)
drivers/block/loop.c +1 -0
@@ -2092,6 +2092,7 @@ static void loop_remove(struct loop_device *lo)del_gendisk (lo->lo_disk);blk_cleanup_disk (lo->lo_disk);blk_mq_free_tag_set (&lo->tag_set); +mutex_lock (&loop_ctl_mutex);idr_remove (&loop_index_idr, lo->lo_number);mutex_unlock (&loop_ctl_mutex);
drivers/nvme/host/core.c +8 -0
@@ -3879,6 +3879,14 @@ static int nvme_init_ns_head(struct nvme_ns *ns, unsigned nsid, nsid); goto out_put_ns_head; } + +if (!multipath && !list_empty (&head->list)) { +dev_warn (ctrl->device, +"Found shared namespace %d, but multipathing not supported.\n" , + nsid); +dev_warn_once (ctrl->device, +"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n." ); + } }list_add_tail_rcu (&ns->siblings, &head->list);
Signature · 1 line
2.30.2
Keith Busch
maintainerdrivers/block/loop.c static void loop_remove(struct loop_device *lo) · line 2098
Quoted 12 lines · Christoph Hellwig
drivers/block/loop.c +1
-0@@ -2092,6 +2092,7 @@ static void loop_remove(struct loop_device *lo)del_gendisk (lo->lo_disk);blk_cleanup_disk (lo->lo_disk);blk_mq_free_tag_set (&lo->tag_set); +mutex_lock (&loop_ctl_mutex);idr_remove (&loop_index_idr, lo->lo_number);mutex_unlock (&loop_ctl_mutex);
This unrelated change sneaked into your patch. :)
Quoted 6 lines
drivers/nvme/host/core.c +0
-0@@ -3879,6 +3879,14 @@ static int nvme_init_ns_head(struct nvme_ns *ns, unsigned nsid, nsid);
drivers/nvme/host/core.c static int nvme_init_ns_head(struct nvme_ns *ns, unsigned nsid, · line 3889
Quoted 10 lines
drivers/nvme/host/core.c +8
-0goto out_put_ns_head; } + +if (!multipath && !list_empty (&head->list)) { +dev_warn (ctrl->device, +"Found shared namespace %d, but multipathing not supported.\n" , + nsid); +dev_warn_once (ctrl->device, +"Support for shared namespaces without CONFIG_NVME_MULTIPATH is deprecated and will be removed in Linux 6.0\n." ); + }
The recent release pattern suggests 5.20 will be the last of the 5.x tags before seeing 6.0, but my understanding is that's at the discretion of Chief Penguin. Unless you know already, perhaps warning with 5.21 is more clear that removing this capability happens after 3 more releases.
Christoph Hellwig
maintainerQuoted 15 lines · Keith Busch
drivers/block/loop.c static void loop_remove(struct loop_device *lo) · line 2098
Quoted 12 lines · Christoph Hellwig
drivers/block/loop.c +1
-0@@ -2092,6 +2092,7 @@ static void loop_remove(struct loop_device *lo)del_gendisk (lo->lo_disk);blk_cleanup_disk (lo->lo_disk);blk_mq_free_tag_set (&lo->tag_set); +mutex_lock (&loop_ctl_mutex);idr_remove (&loop_index_idr, lo->lo_number);mutex_unlock (&loop_ctl_mutex);This unrelated change sneaked into your patch. :)
Ooops.
Quoted 4 lines
The recent release pattern suggests 5.20 will be the last of the 5.x tags before seeing 6.0, but my understanding is that's at the discretion of Chief Penguin. Unless you know already, perhaps warning with 5.21 is more clear that removing this capability happens after 3 more releases.
Sounds good to me - we are not in a crazy urge right now, but we need to settle this eventually.
BTW, I don't think the legacy multipath should be supported going forward, so I'm okay with deprecating it: