Skip to contentSkip to conversation

KVM: VMX: Prepare VMCS setting for posted interrupt enabling when APICv is available

PATCH Applied Zeng Guang 2 participants 3 messages Mar 15, 2022

Subsystems (3)
lore
Share & tools
lore

Zeng Guang

author
#0 lore raw

PATCH 1/1 KVM: VMX: Prepare VMCS setting for posted interrupt enabling when APICv is available

Currently KVM setup posted interrupt VMCS only depending on per-vcpu APICv activation status at the vCPU creation time. However, this status can be toggled dynamically under some circumstance. So potentially, later posted interrupt enabling may be problematic without VMCS readiness.

To fix this, always settle the VMCS setting for posted interrupt as long as APICv is available and lapic locates in kernel.

---
 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx/vmx.c +1 -1
index b730d799c26e..d6e42d37bb61 100644
@@ -4388,7 +4388,7 @@ static void init_vmcs(struct vcpu_vmx *vmx)
 	if (cpu_has_secondary_exec_ctrls())
 		secondary_exec_controls_set(vmx, vmx_secondary_exec_control(vmx));
 
-	if (kvm_vcpu_apicv_active(&vmx->vcpu)) {
+	if (enable_apicv && lapic_in_kernel(&vmx->vcpu)) {
 		vmcs_write64(EOI_EXIT_BITMAP0, 0);
 		vmcs_write64(EOI_EXIT_BITMAP1, 0);
 		vmcs_write64(EOI_EXIT_BITMAP2, 0);
Signature · 1 line
2.27.0