perf/stat: Fix perf stat for forked applications
PATCH 1/1 perf/stat: Fix perf stat for forked applications
I have run into the following issue:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7
Performance counter stats for 'system wide':
0 new_pmu/INSTRUCTION_7/
0.000366428 seconds time elapsed#
The new PMU for s390 counts the execution of certain CPU instructions. The root cause is the extremely small run time of the mytest program. It just executes some assembly instructions and then exits. In above invocation the instruction is executed exactly one time (-c1 option). The PMU is expected to report this one time execution by a counter value of one, but fails to do so in some cases, not all.
Debugging reveals the invocation of the child process is done *before* the counter events are installed and enabled. Tracing reveals that sometimes the child process starts and exits before the event is installed on all CPUs. The more CPUs the machine has, the more often this miscount happens.
Fix this by reversing the start of the work load after the events have been installed on the specified CPUs. Now the comment also matches the code.
Output after:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7
Performance counter stats for 'system wide':
1 new_pmu/INSTRUCTION_7/
0.000366428 seconds time elapsed#
Now the correct result is reported rock solid all the time regardless how many CPUs are online.
--- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-stat.c +1 -1
@@ -955,10 +955,10 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)* Enable counters and exec the command: */ if (forks) { -evlist__start_workload (evsel_list); err =enable_counters ();if (err)return -1 ; +evlist__start_workload (evsel_list); t0 =rdclock ();clock_gettime (CLOCK_MONOTONIC , &ref_time);
Signature · 1 line
2.35.1
Quoted 56 lines · Thomas Richter
I have run into the following issue:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7Performance counter stats for 'system wide':
0 new_pmu/INSTRUCTION_7/ 0.000366428 seconds time elapsed#
The new PMU for s390 counts the execution of certain CPU instructions. The root cause is the extremely small run time of the mytest program. It just executes some assembly instructions and then exits. In above invocation the instruction is executed exactly one time (-c1 option). The PMU is expected to report this one time execution by a counter value of one, but fails to do so in some cases, not all.
Debugging reveals the invocation of the child process is done *before* the counter events are installed and enabled. Tracing reveals that sometimes the child process starts and exits before the event is installed on all CPUs. The more CPUs the machine has, the more often this miscount happens.
Fix this by reversing the start of the work load after the events have been installed on the specified CPUs. Now the comment also matches the code.
Output after:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7Performance counter stats for 'system wide':
1 new_pmu/INSTRUCTION_7/ 0.000366428 seconds time elapsed#
Now the correct result is reported rock solid all the time regardless how many CPUs are online.
Fixes acf2892270dc ("perf stat: Use perf_evlist__prepare/start_workload())Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Namhyung Kim <[email protected]>--- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-stat.c +0
-0
tools/perf/builtin-stat.c static int __run_perf_stat(int argc, const char **argv, int run_idx) · line 961
Quoted 8 lines
tools/perf/builtin-stat.c +1
-1@@ -955,10 +955,10 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)* Enable counters and exec the command: */ if (forks) { -evlist__start_workload (evsel_list); err =enable_counters ();if (err)return -1 ; +evlist__start_workload (evsel_list);
right, without -a the event has enable_on_exec so the race does not matter, but it's a problem for system wide with fork
thanks,
jirka
Quoted 6 lines
tools/perf/builtin-stat.c +0
-0t0 =rdclock ();clock_gettime (CLOCK_MONOTONIC , &ref_time);Signature · 1 line
2.35.1
Quoted 53 lines · Jiri Olsa
Quoted 51 lines · Thomas Richter
I have run into the following issue:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7Performance counter stats for 'system wide':
0 new_pmu/INSTRUCTION_7/ 0.000366428 seconds time elapsed#
The new PMU for s390 counts the execution of certain CPU instructions. The root cause is the extremely small run time of the mytest program. It just executes some assembly instructions and then exits. In above invocation the instruction is executed exactly one time (-c1 option). The PMU is expected to report this one time execution by a counter value of one, but fails to do so in some cases, not all.
Debugging reveals the invocation of the child process is done *before* the counter events are installed and enabled. Tracing reveals that sometimes the child process starts and exits before the event is installed on all CPUs. The more CPUs the machine has, the more often this miscount happens.
Fix this by reversing the start of the work load after the events have been installed on the specified CPUs. Now the comment also matches the code.
Output after:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7Performance counter stats for 'system wide':
1 new_pmu/INSTRUCTION_7/ 0.000366428 seconds time elapsed#
Now the correct result is reported rock solid all the time regardless how many CPUs are online.
Fixes acf2892270dc ("perf stat: Use perf_evlist__prepare/start_workload())Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Namhyung Kim <[email protected]>--- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
tools/perf/builtin-stat.c static int __run_perf_stat(int argc, const char **argv, int run_idx) · line 961
Quoted 13 lines
tools/perf/builtin-stat.c +1
-1@@ -955,10 +955,10 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)* Enable counters and exec the command: */ if (forks) { -evlist__start_workload (evsel_list); err =enable_counters ();if (err)return -1 ; +evlist__start_workload (evsel_list);right, without -a the event has
enable_on_execso the race does not matter, but it's a problem for system wide with fork
Agreed. Also we may move the enable_counters() and the clock code out of the if block to be shared with the else block.
Thanks,
Namhyung
Em Wed, Mar 23, 2022 at 01:54:23PM -0700, Namhyung Kim escreveu:
Quoted 71 lines · Jiri Olsa
Quoted 53 lines · Thomas Richter
Quoted 51 lines
I have run into the following issue:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7Performance counter stats for 'system wide':
0 new_pmu/INSTRUCTION_7/ 0.000366428 seconds time elapsed#
The new PMU for s390 counts the execution of certain CPU instructions. The root cause is the extremely small run time of the mytest program. It just executes some assembly instructions and then exits. In above invocation the instruction is executed exactly one time (-c1 option). The PMU is expected to report this one time execution by a counter value of one, but fails to do so in some cases, not all.
Debugging reveals the invocation of the child process is done *before* the counter events are installed and enabled. Tracing reveals that sometimes the child process starts and exits before the event is installed on all CPUs. The more CPUs the machine has, the more often this miscount happens.
Fix this by reversing the start of the work load after the events have been installed on the specified CPUs. Now the comment also matches the code.
Output after:
# perf stat -a -e new_pmu/INSTRUCTION_7/ -- mytest -c1 7Performance counter stats for 'system wide':
1 new_pmu/INSTRUCTION_7/ 0.000366428 seconds time elapsed#
Now the correct result is reported rock solid all the time regardless how many CPUs are online.
Fixes acf2892270dc ("perf stat: Use perf_evlist__prepare/start_workload())Signed-off-by Thomas Richter <[email protected]>Acked-by Sumanth Korikkar <[email protected]>Cc Namhyung Kim <[email protected]>--- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 16 lines
tools/perf/builtin-stat.c static int __run_perf_stat(int argc, const char **argv, int run_idx) · line 961
Quoted 13 lines
tools/perf/builtin-stat.c +1
-1@@ -955,10 +955,10 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)* Enable counters and exec the command: */ if (forks) { -evlist__start_workload (evsel_list); err =enable_counters ();if (err)return -1 ; +evlist__start_workload (evsel_list);right, without -a the event has
enable_on_execso the race does not matter, but it's a problem for system wide with fork
Quoted 4 lines
Agreed. Also we may move the
enable_counters()and the clock code out of the if block to be shared with the else block.Acked-by Namhyung Kim <[email protected]>
Thanks, applied and added your comments as "Reviewer notes", and please consider using the Reviewed-by tag instead of the Acked-by ones.
Thanks anyways, as always!
- Arnaldo