Skip to contentSkip to conversation

EDAC/altera: Remove unnecessary print function dev_err()

PATCH In review Yang Li 2 participants 2 messages Mar 17, 2022 – Mar 21, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 EDAC/altera: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because platform_get_irq() already prints an error ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because platform_get_irq() already prints an error

---
 drivers/edac/altera_edac.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/edac/altera_edac.c +2 -6
index e7e8e624a436..47dc35938fa8 100644
@@ -2149,10 +2149,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 	}
 
 	edac->sb_irq = platform_get_irq(pdev, 0);
-	if (edac->sb_irq < 0) {
-		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
+	if (edac->sb_irq < 0)
 		return edac->sb_irq;
-	}
 
 	irq_set_chained_handler_and_data(edac->sb_irq,
 					 altr_edac_a10_irq_handler,
@@ -2184,10 +2182,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
 	}
 #else
 	edac->db_irq = platform_get_irq(pdev, 1);
-	if (edac->db_irq < 0) {
-		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
+	if (edac->db_irq < 0)
 		return edac->db_irq;
-	}
 	irq_set_chained_handler_and_data(edac->db_irq,
 					 altr_edac_a10_irq_handler, edac);
 #endif
Signature · 1 line
2.20.1.7.g153144c
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 33 lines · Yang Li

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because platform_get_irq() already prints an error ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because platform_get_irq() already prints an error

---
  drivers/edac/altera_edac.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)
drivers/edac/altera_edac.c +1 -3
index e7e8e624a436..47dc35938fa8 100644
@@ -2149,10 +2149,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
  	}
 
  	edac->sb_irq = platform_get_irq(pdev, 0);
-	if (edac->sb_irq < 0) {
-		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
+	if (edac->sb_irq < 0)
  		return edac->sb_irq;
-	}
 
  	irq_set_chained_handler_and_data(edac->sb_irq,
  					 altr_edac_a10_irq_handler,
@@ -2184,10 +2182,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
  	}

drivers/edac/altera_edac.c static int altr_edac_a10_probe(struct platform_device *pdev) · line 2189

Quoted 10 lines
drivers/edac/altera_edac.c +1 -3
  #else
  	edac->db_irq = platform_get_irq(pdev, 1);
-	if (edac->db_irq < 0) {
-		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
+	if (edac->db_irq < 0)
  		return edac->db_irq;
-	}
  	irq_set_chained_handler_and_data(edac->db_irq,
  					 altr_edac_a10_irq_handler, edac);
  #endif