Skip to contentSkip to conversation

gdb: Add malloc and free symbols to kernel.exec to improve gdb functionality

PATCH In review Glenn Washburn 2 participants 2 messages Mar 18, 2022 – Mar 22, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gdb: Add malloc and free symbols to kernel.exec to improve gdb functionality

Add linker flags when linking kernel.exec to have malloc and free point to grub_malloc and grub_free respectively. Some gdb functionality depends on gdb locating the symbols "malloc" and "free", such as dynamically creating strings for arguments to injected function calls. A trivial example would the gdb command 'p strlen("astring")'. Make sure not to do this on emu platforms, or an infinite loop occurs because emu has a special grub_malloc() that calls malloc().

---
 conf/Makefile.common | 7 +++++++
 1 file changed, 7 insertions(+)
conf/Makefile.common +7 -0
index b343a038ee..2d8f1bf2e8 100644
@@ -39,6 +39,13 @@ LDFLAGS_KERNEL = $(LDFLAGS_PLATFORM) -nostdlib $(TARGET_LDFLAGS_OLDMAGIC)
 CPPFLAGS_KERNEL = $(CPPFLAGS_CPU) $(CPPFLAGS_PLATFORM) -DGRUB_KERNEL=1
 CCASFLAGS_KERNEL = $(CCASFLAGS_CPU) $(CCASFLAGS_PLATFORM)
 STRIPFLAGS_KERNEL = -R .rel.dyn -R .reginfo -R .note -R .comment -R .drectve -R .note.gnu.gold-version -R .MIPS.abiflags -R .ARM.exidx
+if !COND_emu
+if COND_HAVE_ASM_USCORE
+  LDFLAGS_KERNEL += -Wl,--defsym=_malloc=_grub_malloc -Wl,--defsym=_free=_grub_free
+else
+  LDFLAGS_KERNEL += -Wl,--defsym=malloc=grub_malloc -Wl,--defsym=free=grub_free
+endif
+endif
 
 CFLAGS_MODULE = $(CFLAGS_PLATFORM) -ffreestanding
 LDFLAGS_MODULE = $(LDFLAGS_PLATFORM) -nostdlib $(TARGET_LDFLAGS_OLDMAGIC) -Wl,-r
Signature · 1 line
2.27.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Glenn Washburn

Add linker flags when linking kernel.exec to have malloc and free point to grub_malloc and grub_free respectively. Some gdb functionality depends on gdb locating the symbols "malloc" and "free", such as dynamically creating strings for arguments to injected function calls. A trivial example would the gdb command 'p strlen("astring")'. Make sure not to do this on emu platforms, or an infinite loop occurs because emu has a special grub_malloc() that calls malloc().

Daniel