Skip to contentSkip to conversation

n64cart: convert bi_disk to bi_bdev->bd_disk fix build

PATCH Applied Jackie Liu 3 participants 3 messages Mar 21, 2022 Block layer

lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH 1/1 n64cart: convert bi_disk to bi_bdev->bd_disk fix build

From: Jackie Liu <[email protected]>

My kernel robot report below:

drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’

     91 |  struct device *dev = bio->bi_disk->private_data;
        |                          ^~
    CC      drivers/slimbus/qcom-ctrl.o
    CC      drivers/auxdisplay/hd44780.o
    CC      drivers/watchdog/watchdog_core.o
    CC      drivers/nvme/host/fault_inject.o
    AR      drivers/accessibility/braille/built-in.a

make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1

Fixes 309dca309fc3 ("block: store a block_device pointer in struct bio");
---
 drivers/block/n64cart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/n64cart.c +1 -1
index 4db9a8c244af..e094d2b8b5a9 100644
@@ -88,7 +88,7 @@ static void n64cart_submit_bio(struct bio *bio)
 {
 	struct bio_vec bvec;
 	struct bvec_iter iter;
-	struct device *dev = bio->bi_disk->private_data;
+	struct device *dev = bio->bi_bdev->bd_disk->private_data;
 	u32 pos = bio->bi_iter.bi_sector << SECTOR_SHIFT;
 
 	bio_for_each_segment(bvec, bio, iter) {
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Jackie Liu

From: Jackie Liu <[email protected]>

My kernel robot report below:

drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:

   drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
      91 |  struct device *dev = bio->bi_disk->private_data;
         |                          ^~
     CC      drivers/slimbus/qcom-ctrl.o
     CC      drivers/auxdisplay/hd44780.o
     CC      drivers/watchdog/watchdog_core.o
     CC      drivers/nvme/host/fault_inject.o
     AR      drivers/accessibility/braille/built-in.a
   make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
Quoted 4 lines
Fixes 309dca309fc3 ("block: store a block_device pointer in struct bio");

---

Looks good.

-ck

maintainer Applied
#2 lore raw
In reply to Jackie Liu
Quoted 13 lines · Jackie Liu

From: Jackie Liu <[email protected]>

My kernel robot report below:

drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’

     91 |  struct device *dev = bio->bi_disk->private_data;
        |                          ^~
    CC      drivers/slimbus/qcom-ctrl.o
    CC      drivers/auxdisplay/hd44780.o
    CC      drivers/watchdog/watchdog_core.o
    CC      drivers/nvme/host/fault_inject.o
    AR      drivers/accessibility/braille/built-in.a
Quoted 3 lines

make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1

[...]

Applied, thanks!

[1/1] n64cart: convert bi_disk to bi_bdev->bd_disk fix build

      commit: b2479de38d8fc7ef13d5c78ff5ded6e5a1a4eac0

Best regards,

Signature · 1 line
Jens Axboe