Skip to contentSkip to conversation

Add support for sam9x60_curiosity

PATCH Superseded Durai Manickam KR 2 participants 6 messages Mar 22, 2022

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Add support for sam9x60_curiosity

This patch series adds support for sam9x60_curiosity.

Durai Manickam KR (4):
board: Add sam9x60_curiosity support
ARM: dts: Add device tree files for sam9x60_curiosity
configs: Add sam9x60_curiosity_mmc_defconfig
configs: Add sam9x60_curiosity_nandflash_defconfig

 arch/arm/dts/Makefile                         |   2 +
 .../dts/at91-sam9x60_curiosity-u-boot.dtsi    |  79 ++++++++++
 arch/arm/dts/at91-sam9x60_curiosity.dts       |  74 ++++++++++
 arch/arm/mach-at91/Kconfig                    |   7 +
 board/atmel/sam9x60_curiosity/Kconfig         |  15 ++
 board/atmel/sam9x60_curiosity/MAINTAINERS     |   8 +
 board/atmel/sam9x60_curiosity/Makefile        |   7 +
 .../sam9x60_curiosity/sam9x60_curiosity.c     | 139 ++++++++++++++++++
 configs/sam9x60_curiosity_mmc_defconfig       |  82 +++++++++++
 configs/sam9x60_curiosity_nandflash_defconfig |  82 +++++++++++
 include/configs/sam9x60_curiosity.h           |  67 +++++++++
 11 files changed, 562 insertions(+)
 create mode 100644 arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi
 create mode 100644 arch/arm/dts/at91-sam9x60_curiosity.dts
 create mode 100644 board/atmel/sam9x60_curiosity/Kconfig
 create mode 100644 board/atmel/sam9x60_curiosity/MAINTAINERS
 create mode 100644 board/atmel/sam9x60_curiosity/Makefile
 create mode 100644 board/atmel/sam9x60_curiosity/sam9x60_curiosity.c
 create mode 100644 configs/sam9x60_curiosity_mmc_defconfig
 create mode 100644 configs/sam9x60_curiosity_nandflash_defconfig
 create mode 100644 include/configs/sam9x60_curiosity.h
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/4 board: Add sam9x60_curiosity support

Add board files, Kconfig, Makefile and MAINTAINERS.

---
 arch/arm/mach-at91/Kconfig                    |   7 +
 board/atmel/sam9x60_curiosity/Kconfig         |  15 ++
 board/atmel/sam9x60_curiosity/MAINTAINERS     |   6 +
 board/atmel/sam9x60_curiosity/Makefile        |   7 +
 .../sam9x60_curiosity/sam9x60_curiosity.c     | 139 ++++++++++++++++++
 include/configs/sam9x60_curiosity.h           |  67 +++++++++
 6 files changed, 241 insertions(+)
 create mode 100644 board/atmel/sam9x60_curiosity/Kconfig
 create mode 100644 board/atmel/sam9x60_curiosity/MAINTAINERS
 create mode 100644 board/atmel/sam9x60_curiosity/Makefile
 create mode 100644 board/atmel/sam9x60_curiosity/sam9x60_curiosity.c
 create mode 100644 include/configs/sam9x60_curiosity.h
arch/arm/mach-at91/Kconfig +7 -0
index fc193b935e..8b3356edcb 100644
@@ -161,6 +161,12 @@ config TARGET_SAM9X60EK
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 
+config TARGET_SAM9X60_CURIOSITY
+        bool "SAM9X60 CURIOSITY board"
+        select SAM9X60
+        select BOARD_EARLY_INIT_F
+        select BOARD_LATE_INIT
+
 config TARGET_SAMA5D2_PTC_EK
 	bool "SAMA5D2 PTC EK board"
 	select BOARD_EARLY_INIT_F
@@ -326,6 +332,7 @@ source "board/atmel/at91sam9n12ek/Kconfig"
 source "board/atmel/at91sam9rlek/Kconfig"
 source "board/atmel/at91sam9x5ek/Kconfig"
 source "board/atmel/sam9x60ek/Kconfig"
+source "board/atmel/sam9x60_curiosity/Kconfig"
 source "board/atmel/sama7g5ek/Kconfig"
 source "board/atmel/sama5d2_ptc_ek/Kconfig"
 source "board/atmel/sama5d2_xplained/Kconfig"
board/atmel/sam9x60_curiosity/Kconfig new file +15 -0
new file mode 100644
index 0000000000..ae84e0f32c
@@ -0,0 +1,15 @@
+if TARGET_SAM9X60_CURIOSITY
+
+config SYS_BOARD
+	default "sam9x60_curiosity"
+
+config SYS_VENDOR
+	default "atmel"
+
+config SYS_SOC
+        default "at91"
+
+config SYS_CONFIG_NAME
+	default "sam9x60_curiosity"
+
+endif
board/atmel/sam9x60_curiosity/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..84a3a9f186
@@ -0,0 +1,6 @@
+SAM9X60 CURIOSITY BOARD
+M:	Durai Manickam KR <[email protected]>
+M:	Eugen Hristev <[email protected]>
+S:	Maintained
+F:	board/atmel/sam9x60_curiosity/
+F:	include/configs/sam9x60_curiosity.h
board/atmel/sam9x60_curiosity/Makefile new file +7 -0
new file mode 100644
index 0000000000..c4d17e66d4
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
+#
+# Author: Durai Manickam KR <[email protected]>
+
+obj-y += sam9x60_curiosity.o
board/atmel/sam9x60_curiosity/sam9x60_curiosity.c new file +139 -0

139 lines not on this page · raw message

include/configs/sam9x60_curiosity.h new file +67 -0

67 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/4 ARM: dts: Add device tree files for sam9x60_curiosity

In reply to Durai Manickam KR

Add dts and dtsi files.

---
 arch/arm/dts/Makefile                         |  2 +
 .../dts/at91-sam9x60_curiosity-u-boot.dtsi    | 79 +++++++++++++++++++
 arch/arm/dts/at91-sam9x60_curiosity.dts       | 74 +++++++++++++++++
 3 files changed, 155 insertions(+)
 create mode 100644 arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi
 create mode 100644 arch/arm/dts/at91-sam9x60_curiosity.dts
arch/arm/dts/Makefile +2 -0
index 770a51955e..f0b3219734 100644
@@ -1006,6 +1006,8 @@ dtb-$(CONFIG_TARGET_AT91SAM9X5EK) += \
 
 dtb-$(CONFIG_TARGET_SAM9X60EK) += sam9x60ek.dtb
 
+dtb-$(CONFIG_TARGET_SAM9X60_CURIOSITY) += at91-sam9x60_curiosity.dtb
+
 dtb-$(CONFIG_TARGET_AT91SAM9N12EK) += at91sam9n12ek.dtb
 
 dtb-$(CONFIG_TARGET_GARDENA_SMART_GATEWAY_AT91SAM) += \
arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi new file +79 -0

79 lines not on this page · raw message

arch/arm/dts/at91-sam9x60_curiosity.dts new file +74 -0

74 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw

PATCH 3/4 configs: Add sam9x60_curiosity_mmc_defconfig

In reply to Durai Manickam KR

Add boot from SDMMC (sdcard) support for sam9x60_curiosity.

---
 board/atmel/sam9x60_curiosity/MAINTAINERS |  1 +
 configs/sam9x60_curiosity_mmc_defconfig   | 82 +++++++++++++++++++++++
 2 files changed, 83 insertions(+)
 create mode 100644 configs/sam9x60_curiosity_mmc_defconfig
board/atmel/sam9x60_curiosity/MAINTAINERS +1 -0
index 84a3a9f186..3e1dce2980 100644
@@ -4,3 +4,4 @@ M:	Eugen Hristev <[email protected]>
 S:	Maintained
 F:	board/atmel/sam9x60_curiosity/
 F:	include/configs/sam9x60_curiosity.h
+F:	configs/sam9x60_curiosity_mmc_defconfig
configs/sam9x60_curiosity_mmc_defconfig new file +82 -0

82 lines not on this page · raw message

Signature · 1 line
2.25.1
#4 lore raw

PATCH 4/4 configs: Add sam9x60_curiosity_nandflash_defconfig

In reply to Durai Manickam KR

Add boot from NAND flash support for sam9x60_curiosity.

---
 board/atmel/sam9x60_curiosity/MAINTAINERS     |  1 +
 configs/sam9x60_curiosity_nandflash_defconfig | 82 +++++++++++++++++++
 2 files changed, 83 insertions(+)
 create mode 100644 configs/sam9x60_curiosity_nandflash_defconfig
board/atmel/sam9x60_curiosity/MAINTAINERS +1 -0
index 3e1dce2980..63e34cee07 100644
@@ -5,3 +5,4 @@ S:	Maintained
 F:	board/atmel/sam9x60_curiosity/
 F:	include/configs/sam9x60_curiosity.h
 F:	configs/sam9x60_curiosity_mmc_defconfig
+F:	configs/sam9x60_curiosity_nandflash_defconfig
configs/sam9x60_curiosity_nandflash_defconfig new file +82 -0

82 lines not on this page · raw message

Signature · 1 line
2.25.1
#5 lore raw
In reply to Durai Manickam KR
Quoted 20 lines · Durai Manickam KR

This patch series adds support for sam9x60_curiosity.

Durai Manickam KR (4):
board: Add sam9x60_curiosity support
ARM: dts: Add device tree files for sam9x60_curiosity
configs: Add sam9x60_curiosity_mmc_defconfig
configs: Add sam9x60_curiosity_nandflash_defconfig

  arch/arm/dts/Makefile                         |   2 +
  .../dts/at91-sam9x60_curiosity-u-boot.dtsi    |  79 ++++++++++
  arch/arm/dts/at91-sam9x60_curiosity.dts       |  74 ++++++++++
  arch/arm/mach-at91/Kconfig                    |   7 +
  board/atmel/sam9x60_curiosity/Kconfig         |  15 ++
  board/atmel/sam9x60_curiosity/MAINTAINERS     |   8 +
  board/atmel/sam9x60_curiosity/Makefile        |   7 +
  .../sam9x60_curiosity/sam9x60_curiosity.c     | 139 ++++++++++++++++++
  configs/sam9x60_curiosity_mmc_defconfig       |  82 +++++++++++
  configs/sam9x60_curiosity_nandflash_defconfig |  82 +++++++++++
  include/configs/sam9x60_curiosity.h           |  67 +++++++++
  11 files changed, 562 insertions(+)
Quoted 10 lines

create mode 100644 arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi create mode 100644 arch/arm/dts/at91-sam9x60_curiosity.dts create mode 100644 board/atmel/sam9x60_curiosity/Kconfig create mode 100644 board/atmel/sam9x60_curiosity/MAINTAINERS create mode 100644 board/atmel/sam9x60_curiosity/Makefile create mode 100644 board/atmel/sam9x60_curiosity/sam9x60_curiosity.c create mode 100644 configs/sam9x60_curiosity_mmc_defconfig create mode 100644 configs/sam9x60_curiosity_nandflash_defconfig create mode 100644 include/configs/sam9x60_curiosity.h

Hello Durai,

Please send incremental versions of your patches from now on. This is the version 2, and also include changes from previous versions in the cover letter or the patch itself under the three dashes (---) .

Other than that, running your patches through the automated CI/CD loop, it looks like unmigrated symbols are no longer accepted into U-boot. (symbols that are defined in board files with '#define CONFIG_***' instead of having them as Kconfig symbols and selected through defconfig or other symbols)

The problem is in the header sam9x60_curiosity.h header file. I tried to chop it down to see which of the symbols are unaccepted, and I have come up with the following file with looks to be accepted by the script:

/* start of file */

#ifndef __CONFIG_H__

#define __CONFIG_H__

#define CONFIG_SYS_AT91_SLOW_CLOCK 32768

#define CONFIG_SYS_AT91_MAIN_CLOCK 24000000 /* 24 MHz
crystal */

#define CONFIG_USART_BASE ATMEL_BASE_DBGU

#define CONFIG_USART_ID 0 /* ignored in arm */

/* SDRAM */

#define CONFIG_SYS_SDRAM_BASE 0x20000000

#define CONFIG_SYS_SDRAM_SIZE 0x8000000 /* 128 MB */

#ifdef CONFIG_SPL_BUILD

#define CONFIG_SYS_INIT_SP_ADDR 0x218000

#else

#define CONFIG_SYS_INIT_SP_ADDR \

         (CONFIG_SYS_SDRAM_BASE + 16 * 1024 + CONFIG_SYS_MALLOC_F_LEN - 

\
GENERATED_GBL_DATA_SIZE)

#endif

#endif

/* end of file */

So the other symbols you are defining in this file are no longer accepted. So you have to find some solution to use migrated symbols instead of defining them in the board file. If some are mandatory for board operations, they would require migration first (I have not checked if some others are already migrated )
Otherwise, the board cannot go into u-boot mainline at the moment.

Eugen