Skip to contentSkip to conversation

sandbox: sdl: Add stub sandbox_sdl_remove_display()

PATCH In review Andrew Scull 2 participants 4 messages Mar 23, 2022 – Jun 25, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 sandbox: sdl: Add stub sandbox_sdl_remove_display()

Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.

---
 arch/sandbox/include/asm/sdl.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/sandbox/include/asm/sdl.h +5 -0
index e271a849af..56dcb84803 100644
@@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp,
 	return -ENODEV;
 }
 
+static inline int sandbox_sdl_remove_display(void)
+{
+	return -ENODEV;
+}
+
 static inline int sandbox_sdl_sync(void *lcd_base)
 {
 	return -ENODEV;
Signature · 1 line
2.35.1.894.gb6a874cedc-goog
#1 lore raw

Friendly ping on this patch as I've seen a few others being accepted recently and wanted to make sure this fix hasn't fallen by the wayside.

Quoted 32 lines · Andrew Scull

Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.

---
 arch/sandbox/include/asm/sdl.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/sandbox/include/asm/sdl.h +5 -1
index e271a849af..56dcb84803 100644
@@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp,
        return -ENODEV;
 }
 
+static inline int sandbox_sdl_remove_display(void)
+{
+       return -ENODEV;
+}
+
 static inline int sandbox_sdl_sync(void *lcd_base)
 {
        return -ENODEV;
--

2.35.1.894.gb6a874cedc-goog

#2 lore raw

It's been a while, so pinging again.

Quoted 40 lines · Andrew Scull

Friendly ping on this patch as I've seen a few others being accepted recently and wanted to make sure this fix hasn't fallen by the wayside.

Quoted 9 lines · Andrew Scull

Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.

Review

Quoted 5 lines
---
 arch/sandbox/include/asm/sdl.h | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/arch/sandbox/include/asm/sdl.h

arch/sandbox/include/asm/sdl.h static inline int sandbox_sdl_init_display(int width,

Quoted 4 lines

index e271a849af..56dcb84803 100644

arch/sandbox/include/asm/sdl.h +0 -0
@@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width,

int height, int log2_bpp,

Quoted 14 lines
arch/sandbox/include/asm/sdl.h +5 -1
        return -ENODEV;
 }
 
+static inline int sandbox_sdl_remove_display(void)
+{
+       return -ENODEV;
+}
+
 static inline int sandbox_sdl_sync(void *lcd_base)
 {
        return -ENODEV;
--

2.35.1.894.gb6a874cedc-goog

#3 lore raw
In reply to Andrew Scull
Quoted 11 lines · On Wed, 23 Mar 2022 20:20:37 +0000 Andrew Scull [email protected] wrote:

Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs of the other similar functions.

---
 arch/sandbox/include/asm/sdl.h | 5 +++++
 1 file changed, 5 insertions(+)

applied to u-boot-video/master, thanks!

--
Anatolij