Skip to contentSkip to conversation

minix-fix-bug-when-opening-a-file-with-o_direct.patch removed from -mm tree

merged Andrew Morton 1 participant 1 message Mar 25, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The patch titled
Subject: minix: fix bug when opening a file with O_DIRECT
has been removed from the -mm tree. Its filename was
minix-fix-bug-when-opening-a-file-with-o_direct.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Qinghua Jin <[email protected]>
Subject: minix: fix bug when opening a file with O_DIRECT

Testcase:
1. create a minix file system and mount it
2. open a file on the file system with O_RDWR|O_CREAT|O_TRUNC|O_DIRECT
3. open fails with -EINVAL but leaves an empty file behind. All other open() failures don't leave the failed open files behind.

It is hard to check the direct_IO op before creating the inode. Just as ext4 and btrfs do, this patch will resolve the issue by allowing to create the file with O_DIRECT but returning error when writing the file.

---

 fs/minix/inode.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/minix/inode.c renamed from fs/minix/inode.c~minix-fix-bug-when-opening-a-file-with-o_direct +2 -1
@@ -447,7 +447,8 @@ static const struct address_space_operat
 	.writepage = minix_writepage,
 	.write_begin = minix_write_begin,
 	.write_end = generic_write_end,
-	.bmap = minix_bmap
+	.bmap = minix_bmap,
+	.direct_IO = noop_direct_IO
 };
 
 static const struct inode_operations minix_symlink_inode_operations = {

_

Patches currently in -mm which might be from [email protected] are