media: uvc_video: fix bit overflow in uvc_probe_video
Subsystems (2)
PATCH v2 1/1 media: uvc_video: fix bit overflow in uvc_probe_video
probe->dwMaxPayloadTransferSize is a 32bit value, but bandwidth is 16bit. This may lead to a bit overflow.
Fix this by using probe->dwMaxPayloadTransferSize directly.
Signed-off-by Hangyu Hua <[email protected]>
---
v2:
Use probe->dwMaxPayloadTransferSize directly instead of changing temporary variable.
drivers/media/usb/uvc/uvc_video.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/usb/uvc/uvc_video.c +1 -3
@@ -383,7 +383,6 @@ int uvc_probe_video(struct uvc_streaming *stream, struct uvc_streaming_control *probe) {struct uvc_streaming_control probe_min, probe_max; -u16 bandwidth;unsigned int i;int ret;
@@ -421,8 +420,7 @@ int uvc_probe_video(struct uvc_streaming *stream,if (stream->intf->num_altsetting ==1 )break ; - bandwidth = probe->dwMaxPayloadTransferSize; -if (bandwidth <= stream->maxpsize) +if (probe->dwMaxPayloadTransferSize <= stream->maxpsize)break ;if (stream->dev->quirks &UVC_QUIRK_PROBE_MINMAX ) {
Signature · 1 line
2.25.1
Quoted 7 lines · Hangyu Hua
probe->dwMaxPayloadTransferSizeis a 32bit value, but bandwidth is 16bit. This may lead to a bit overflow.Fix this by using
probe->dwMaxPayloadTransferSizedirectly.Signed-off-by Hangyu Hua <[email protected]>
Reviewed-by Ricardo Ribalda <[email protected]>
Quoted 34 lines
---
v2:
Useprobe->dwMaxPayloadTransferSizedirectly instead of changing temporary variable.drivers/media/usb/uvc/uvc_video.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/media/usb/uvc/uvc_video.c +1
-4@@ -383,7 +383,6 @@ int uvc_probe_video(struct uvc_streaming *stream, struct uvc_streaming_control *probe) {struct uvc_streaming_control probe_min, probe_max; -u16 bandwidth;unsigned int i;int ret;@@ -421,8 +420,7 @@ int uvc_probe_video(struct uvc_streaming *stream,if (stream->intf->num_altsetting ==1 )break ; - bandwidth = probe->dwMaxPayloadTransferSize; -if (bandwidth <= stream->maxpsize) +if (probe->dwMaxPayloadTransferSize <= stream->maxpsize)break ;if (stream->dev->quirks &UVC_QUIRK_PROBE_MINMAX ) { --2.25.1
Signature · 1 line
Ricardo Ribalda