mtd: rawnand: print offset instead of page number for bad blocks
Subsystems (2)
PATCH 1/1 mtd: rawnand: print offset instead of page number for bad blocks
From: Rafał Miłecki <[email protected]>
This makes printed info consistent with other kernel messages. After scanning NAND BBT create_bbt() prints offset of each bad block. This change makes is easy to verify nand_erase_nand() failure reason.
---
I noticed this inconsistency while using "flash_erase" tool.
--- drivers/mtd/nand/raw/nand_base.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/mtd/nand/raw/nand_base.c +5 -4
@@ -4502,11 +4502,13 @@ int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr, len = instr->len;while (len) { +loff_t ofs = (loff_t )page << chip->page_shift; +/* Check if we have a bad block, we do not erase bad blocks! */ if (nand_block_checkbad (chip, ((loff_t ) page) << chip->page_shift, allowbbt)) { -pr_warn ("%s: attempt to erase a bad block at page 0x%08x\n" , - __func__, page); +pr_warn ("%s: attempt to erase a bad block at 0x%08llx\n" , + __func__, (unsigned long long )ofs); ret = -EIO ; goto erase_exit; }
@@ -4524,8 +4526,7 @@ int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,if (ret) {pr_debug ("%s: failed erase, page 0x%08x\n" , __func__, page); - instr->fail_addr = - ((loff_t )page << chip->page_shift); + instr->fail_addr = ofs; goto erase_exit; }
Signature · 6 lines
2.34.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 7 lines · On Sat, 2022-03-26 at 16:33:04 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote:
From: Rafał Miłecki <[email protected]>
This makes printed info consistent with other kernel messages. After scanning NAND BBT
create_bbt()prints offset of each bad block. This change makes is easy to verifynand_erase_nand()failure reason.Signed-off-by Rafał Miłecki <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/