kexec: Remove redundant assignments
Subsystems (3)
PATCH 1/1 kexec: Remove redundant assignments
Get rid of redundant assignments which end up in values not being read either because they are overwritten or the function ends.
Reported by clang-tidy [deadcode.DeadStores]
Signed-off-by Michal Orzel <[email protected]>
--- kernel/kexec_core.c | 2 -- 1 file changed, 2 deletions(-)
kernel/kexec_core.c +0 -2
@@ -768,7 +768,6 @@ static struct page *kimage_alloc_page(struct kimage *image,kimage_free_pages (old_page);continue ; } - addr = old_addr; page = old_page;break ; }
@@ -788,7 +787,6 @@ static int kimage_load_normal_segment(struct kimage *image,unsigned char __user *buf =NULL ;unsigned char *kbuf =NULL ; - result =0 ;if (image->file_mode) kbuf = segment->kbuf;else
Signature · 1 line
2.25.1
Quoted 23 lines · Michal Orzel
Get rid of redundant assignments which end up in values not being read either because they are overwritten or the function ends.
Reported by clang-tidy [deadcode.DeadStores]
Signed-off-by Michal Orzel <[email protected]>--- kernel/kexec_core.c | 2 -- 1 file changed, 2 deletions(-)kernel/kexec_core.c +0
-1@@ -768,7 +768,6 @@ static struct page *kimage_alloc_page(struct kimage *image,kimage_free_pages (old_page);continue ; } - addr = old_addr; page = old_page;break ; }
kernel/kexec_core.c static int kimage_load_normal_segment(struct kimage *image, · line 792
Quoted 7 lines
kernel/kexec_core.c +0
-1@@ -788,7 +787,6 @@ static int kimage_load_normal_segment(struct kimage *image,unsigned char __user *buf =NULL ;unsigned char *kbuf =NULL ; - result =0 ;if (image->file_mode) kbuf = segment->kbuf;else
LGTM, thx
Acked-by Baoquan He <[email protected]>