correct tls-groups for OpenSSL3
PATCH 1/1 correct tls-groups for OpenSSL3
From: Michael <[email protected]...>
--- src/openvpn/ssl_openssl.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
src/openvpn/ssl_openssl.c +10 -1
@@ -572,13 +572,15 @@ void tls_ctx_set_tls_groups(struct tls_root_ctx *ctx, const char *groups) {ASSERT (ctx); +#if OPENSSL_VERSION_NUMBER <0x30000000L struct gc_arena gc =gc_new ();/* This method could be as easy as * SSL_CTX_set1_groups_list(ctx->ctx, groups) -* but OpenSSL does not like the name secp256r1 for prime256v1 +* but OpenSSL (< 3.0) does not like the name secp256r1 for prime256v1 * This is one of the important curves. * To support the same name for OpenSSL and mbedTLS, we do * this dance. +* Also note that the code is wrong in the presence of OpenSSL3 providers. */ int groups_count =get_num_elements (groups,':' );
@@ -617,6 +619,13 @@ tls_ctx_set_tls_groups(struct tls_root_ctx *ctx, const char *groups) groups); }gc_free (&gc); +#else +if (!SSL_CTX_set1_groups_list (ctx->ctx, groups)) + { +crypto_msg (M_FATAL ,"Failed to set allowed TLS group list: %s" , + groups); + } +#endif }void
Signature · 1 line
2.17.1