Skip to contentSkip to conversation

block: move lower_48_bits() to block

PATCH Applied [email protected] 3 participants 5 messages Mar 27, 2022 – Apr 12, 2022 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: move lower_48_bits() to block

From: Keith Busch <[email protected]>

The function is not generally applicable enough to be included in the core kernel header. Move it to block since it's the only subsystem using it.

---
 include/linux/kernel.h | 9 ---------
 include/linux/t10-pi.h | 9 +++++++++
 2 files changed, 9 insertions(+), 9 deletions(-)
include/linux/kernel.h +0 -9
index 08ba5995aa8b..a890428bcc1a 100644
@@ -63,15 +63,6 @@
 }					\
 )
 
-/**
- * lower_48_bits() - return bits 0-47 of a number
- * @n: the number we're accessing
- */
-static inline u64 lower_48_bits(u64 n)
-{
-	return n & ((1ull << 48) - 1);
-}
-
 /**
  * upper_32_bits - return bits 32-63 of a number
  * @n: the number we're accessing
include/linux/t10-pi.h +9 -0
index a4b1af581f69..248f4ac95642 100644
@@ -59,6 +59,15 @@ struct crc64_pi_tuple {
 	__u8   ref_tag[6];
 };
 
+/**
+ * lower_48_bits() - return bits 0-47 of a number
+ * @n: the number we're accessing
+ */
+static inline u64 lower_48_bits(u64 n)
+{
+	return n & ((1ull << 48) - 1);
+}
+
 static inline u64 ext_pi_ref_tag(struct request *rq)
 {
 	unsigned int shift = ilog2(queue_logical_block_size(rq->q));
Signature · 1 line
2.17.2
#1 lore raw
In reply to [email protected]
Quoted 3 lines · On Sun, Mar 27, 2022 at 10:33 AM <[email protected]> wrote:

The function is not generally applicable enough to be included in the core kernel header. Move it to block since it's the only subsystem using it.

Thanks.

Btw - replying on the list too, because at least last time you were on the participants list, I got bounces about "mailbox too large".

WTH? Are you living in some hut in the wilderness in the good old nineties using AOL for email?

Because admittedly the 21st century has been all that great so far, but at least we got rid of mailbox limits.

Linus

#3 lore raw
Quoted 5 lines · Linus Torvalds
Quoted 3 lines · On Sun, Mar 27, 2022 at 10:33 AM <[email protected]> wrote:

The function is not generally applicable enough to be included in the core kernel header. Move it to block since it's the only subsystem using it.

Quoted 7 lines

Thanks.

Btw - replying on the list too, because at least last time you were on the participants list, I got bounces about "mailbox too large".

WTH? Are you living in some hut in the wilderness in the good old nineties using AOL for email?

Hah, my kernel.org had an entry pointing to a recently defunct forwarding address. I think that was the problem, and should be fixed now.

maintainer Applied
#4 lore raw
In reply to [email protected]
Quoted 6 lines · On Sun, 27 Mar 2022 11:33:16 -0600, [email protected] wrote:

From: Keith Busch <[email protected]>

The function is not generally applicable enough to be included in the core kernel header. Move it to block since it's the only subsystem using it.

Applied, thanks!

[1/1] block: move lower_48_bits() to block

      commit: 868e6139c5212e7d9de8332806aacfeafb349320

Best regards,

Signature · 1 line
Jens Axboe