drm/dp_mst: Lower down debug info level when receive NAK
Subsystems (2)
PATCH 1/1 drm/dp_mst: Lower down debug info level when receive NAK
[Why]
It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. Downstream device might reply NAK with the reason and source should react accordingly.
e.g.
1. When downstream device can't handle corresponding message in time, it then replies NAK as reason been set as DEFER.
2. When multi-function branch-sink device doesn't enumerate virtual DP peer devices for those multi-function down facing ports. Without virtual DPCD, branch device might reply NAK with reason as BAD_PARAM indicating this port can't do aux DPCD read.
It's expected result. Not an error.
[How]
Use drm_dbg_kms() to replace drm_err() when receive NAK.
--- drivers/gpu/drm/dp/drm_dp_mst_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/dp/drm_dp_mst_topology.c +1 -2
@@ -3557,9 +3557,8 @@ static int drm_dp_send_dpcd_read(struct drm_dp_mst_topology_mgr *mgr,if (ret <0 ) goto fail_free; -/* DPCD read should never be NACKed */ if (txmsg->reply.reply_type ==1 ) { -drm_err (mgr->dev,"mstb %p port %d: DPCD read on addr 0x%x for %d bytes NAKed\n" , +drm_dbg_kms (mgr->dev,"mstb %p port %d: DPCD read on addr 0x%x for %d bytes NAKed\n" , mstb, port->port_num, offset, size); ret = -EIO ; goto fail_free;
Signature · 1 line
2.35.1
Quoted 13 lines · Wayne Lin
[Why]
It's reasonable that we receive NAK while doingDP_REMOTE_DPCD_READ. Downstream device might reply NAK with the reason and source should react accordingly.e.g.
1. When downstream device can't handle corresponding message in time, it then replies NAK as reason been set as DEFER.
2. When multi-function branch-sink device doesn't enumerate virtual DP peer devices for those multi-function down facing ports. Without virtual DPCD, branch device might reply NAK with reason asBAD_PARAMindicating this port can't do aux DPCD read.
Quoted 6 lines
It's expected result. Not an error.
[How]
Usedrm_dbg_kms()to replacedrm_err()when receive NAK.Signed-off-by Wayne Lin <[email protected]>
Harry
Quoted 19 lines
--- drivers/gpu/drm/dp/drm_dp_mst_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/dp/drm_dp_mst_topology.c +1
-2@@ -3557,9 +3557,8 @@ static int drm_dp_send_dpcd_read(struct drm_dp_mst_topology_mgr *mgr,if (ret <0 ) goto fail_free; -/* DPCD read should never be NACKed */ if (txmsg->reply.reply_type ==1 ) { -drm_err (mgr->dev,"mstb %p port %d: DPCD read on addr 0x%x for %d bytes NAKed\n" , +drm_dbg_kms (mgr->dev,"mstb %p port %d: DPCD read on addr 0x%x for %d bytes NAKed\n" , mstb, port->port_num, offset, size); ret = -EIO ; goto fail_free;