Skip to contentSkip to conversation

soc/tegra: pmc: update Tegra234 reset sources

PATCH Superseded Sandipan Patra 2 participants 3 messages Mar 30, 2022 – Apr 1, 2022 Tegra architecture support

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc/tegra: pmc: update Tegra234 reset sources

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

---
 drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)
drivers/soc/tegra/pmc.c +25 -8
index fdf508e03400..d9129b940e3b 100644
@@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
 };
 
 static const char * const tegra234_reset_sources[] = {
-	"SYS_RESET_N",
+	"SYS_RESET_N",	/*0*/
 	"AOWDT",
 	"BCCPLEXWDT",
 	"BPMPWDT",
@@ -3775,18 +3775,35 @@ static const char * const tegra234_reset_sources[] = {
 	"APEWDT",
 	"LCCPLEXWDT",
 	"SENSOR",
-	"AOTAG",
-	"VFSENSOR",
+	NULL,
+	NULL,		/*10*/
 	"MAINSWRST",
 	"SC7",
 	"HSM",
-	"CSITE",
+	NULL,
 	"RCEWDT",
-	"PVA0WDT",
-	"PVA1WDT",
-	"L1A_ASYNC",
+	NULL,
+	NULL,
+	NULL,
 	"BPMPBOOT",
-	"FUSECRC",
+	"FUSECRC",	/*20*/
+	"DCEWDT",
+	"PSCWDT",
+	"PSC",
+	"CSITE_SW",
+	"POD",
+	"SCPM",
+	"VREFRO_POWERBAD",
+	"VMON",
+	"FMON",
+	"FSI_R5WDT",	/*30*/
+	"FSI_THERM",
+	"FSI_R52C0WDT",
+	"FSI_R52C1WDT",
+	"FSI_R52C2WDT",
+	"FSI_R52C3WDT",
+	"FSI_FMON",
+	"FSI_VMON"	/*37*/
 };
 
 static const struct tegra_wake_event tegra234_wake_events[] = {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Sandipan Patra

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

...

drivers/soc/tegra/pmc.c static const struct tegra_pmc_regs tegra234_pmc_regs = { · line 3769

Quoted 1 line
drivers/soc/tegra/pmc.c +1 -0
+	"SYS_RESET_N",	/*0*/

Missed spaces in the comment here and everywhere else.

Not sure about indices. If it's going to be a part of the hardware programming interface it may make sense to use hexadecimal rather than decimal.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Thanks Andy for reviewing the patch.

Quoted 14 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Wednesday, March 30, 2022 2:46 PM
To: Sandipan Patra <[email protected]>
Cc: Thierry Reding <[email protected]>; Jonathan Hunter <[email protected]>; [email protected]; [email protected]; [email protected]; Bibek Basu <[email protected]>; linux- [email protected]; [email protected]
Subject: Re: [PATCH] soc/tegra: pmc: update Tegra234 reset sources

External email: Use caution opening links or attachments

On Wed, Mar 30, 2022 at 12:06:35PM +0530, Sandipan Patra wrote:

Quoted 8 lines
Quoted 2 lines

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

...

Quoted 1 line

+ "SYS_RESET_N", /*0*/

Missed spaces in the comment here and everywhere else.

ACK

Quoted 4 lines

Not sure about indices. If it's going to be a part of the hardware programming interface it may make sense to use hexadecimal rather than decimal.

Agree. That's a better suggestion for readability too, I will modify it to have hexadecimal in next patch.

Thanks & Regards,
Sandipan

Quoted 5 lines

--
With Best Regards,
Andy Shevchenko