Skip to contentSkip to conversation

arm: kdump: add invalid input check for 'crashkernel=0'

PATCH In review Austin Kim 2 participants 3 messages Mar 31, 2022 Arm (32-bit)

lore
Share & tools
lore

Austin Kim

author
#0 lore raw

PATCH v2 1/1 arm: kdump: add invalid input check for 'crashkernel=0'

From: Austin Kim <[email protected]>

Add invalid input check expression when 'crashkernel=0' is specified running kdump.

---
 arch/arm/kernel/setup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/kernel/setup.c +2 -1
index 039feb7cd590..1e8a50a97edf 100644
@@ -1004,7 +1004,8 @@ static void __init reserve_crashkernel(void)
 	total_mem = get_total_mem();
 	ret = parse_crashkernel(boot_command_line, total_mem,
 				&crash_size, &crash_base);
-	if (ret)
+	/* invalid value specified or crashkernel=0 */
+	if (ret || !crash_size)
 		return;
 
 	if (crash_base <= 0) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 6 lines · Austin Kim

From: Austin Kim <[email protected]>

Add invalid input check expression when 'crashkernel=0' is specified running kdump.

Thanks, this looks fine. Please send it to the patch system, link in my signature below. Thanks.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
author
#2 lore raw

2022년 3월 31일 (목) 오후 10:05, Russell King (Oracle) <[email protected]>님이 작성:

Quoted 11 lines · Austin Kim
Quoted 6 lines

From: Austin Kim <[email protected]>

Add invalid input check expression when 'crashkernel=0' is specified running kdump.

Thanks, this looks fine. Please send it to the patch system, link in my signature below. Thanks.

Will send it to the patch system(https://www.armlinux.org.uk/developer/patches/), thanks!

BR,
Austin Kim

Quoted 4 lines

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!