ASoC: SOF: ipc3-topology: Set scontrol->priv to NULL after freeing it
Subsystems (3)
Peter Ujfalusi
maintainerPATCH 1/1 ASoC: SOF: ipc3-topology: Set scontrol->priv to NULL after freeing it
Since the scontrol->priv is freed up during load operation it should be set to NULL to be safe against double freeing attempt.
--- sound/soc/sof/ipc3-topology.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/sof/ipc3-topology.c +1 -0
@@ -1592,6 +1592,7 @@ static int sof_ipc3_control_load_bytes(struct snd_sof_dev *sdev, struct snd_sof_if (scontrol->priv_size >0 ) {memcpy (cdata->data, scontrol->priv, scontrol->priv_size);kfree (scontrol->priv); + scontrol->priv =NULL ;if (cdata->data->magic !=SOF_ABI_MAGIC ) {dev_err (sdev->dev,"Wrong ABI magic 0x%08x.\n" , cdata->data->magic);
Signature · 1 line
2.35.1
Mark Brown
maintainerQuoted 4 lines · Peter Ujfalusi
Since the
scontrol->privis freed up during load operation it should be set to NULL to be safe against double freeing attempt.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: ipc3-topology: Set scontrol->priv to NULL after freeing it
commit: a403993ce98fb401f696da7c4f374739a7609cff
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark