Skip to contentSkip to conversation

Add Mesh functionality to net/bluetooth

PATCH Superseded Brian Gix 3 participants 6 messages Mar 31, 2022 – Apr 1, 2022

Subsystems (2)

v1 of 7 Superseded 1 of 3 applied Latest is v7 →

lore
Share & tools
lore

Brian Gix

author
#0 lore raw

cover Add Mesh functionality to net/bluetooth

Housekeeping and implementation.

Brian Gix (3):
Bluetooth: Keep MGMT pending queue ordered FIFO
Bluetooth: Implement support for Mesh
Bluetooth: Add experimental wrapper for MGMT based mesh

 include/net/bluetooth/hci.h      |   4 +
 include/net/bluetooth/hci_core.h |  18 +-
 include/net/bluetooth/hci_sync.h |   3 +
 include/net/bluetooth/mgmt.h     |  51 +++
 net/bluetooth/hci_conn.c         |   2 +-
 net/bluetooth/hci_core.c         |   1 +
 net/bluetooth/hci_event.c        |  61 ++--
 net/bluetooth/hci_request.c      | 115 +++++--
 net/bluetooth/hci_sync.c         | 104 ++++--
 net/bluetooth/mgmt.c             | 532 ++++++++++++++++++++++++++++++-
 net/bluetooth/mgmt_util.c        |  60 +++-
 net/bluetooth/mgmt_util.h        |  17 +
 12 files changed, 884 insertions(+), 84 deletions(-)
Signature · 1 line
2.35.1
author
#1 lore raw

PATCH 1/3 Bluetooth: Keep MGMT pending queue ordered FIFO

Small change to add new commands to tail of the list, and find/remove them from the head of the list.

---
 net/bluetooth/mgmt_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/mgmt_util.c +1 -1
index 37eef2ce55ae..b69cfed62088 100644
@@ -297,7 +297,7 @@ struct mgmt_pending_cmd *mgmt_pending_add(struct sock *sk, u16 opcode,
 	if (!cmd)
 		return NULL;
 
-	list_add(&cmd->list, &hdev->mgmt_pending);
+	list_add_tail(&cmd->list, &hdev->mgmt_pending);
 
 	return cmd;
 }
Signature · 1 line
2.35.1
#2 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=627934

---Test result---

Test Summary:

CheckPatch                    FAIL      8.65 seconds
GitLint                       PASS      3.18 seconds
SubjectPrefix                 PASS      2.83 seconds
BuildKernel                   PASS      37.04 seconds
BuildKernel32                 PASS      34.36 seconds
Incremental Build with patchesPASS      107.50 seconds
TestRunner: Setup             PASS      556.09 seconds
TestRunner: l2cap-tester      PASS      18.26 seconds
TestRunner: bnep-tester       PASS      7.21 seconds
TestRunner: mgmt-tester       FAIL      116.15 seconds
TestRunner: rfcomm-tester     PASS      9.51 seconds
TestRunner: sco-tester        PASS      9.22 seconds
TestRunner: smp-tester        PASS      9.13 seconds
TestRunner: userchan-tester   PASS      7.74 seconds

Details
##############################
Test: CheckPatch - FAIL - 8.65 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
[2/3] Bluetooth: Implement support for Mesh\WARNING:TYPO_SPELLING: 'recieving' may be misspelled - perhaps 'receiving'? #67:
and recieving Bluetooth Mesh advertising packets, and delivery to

    ^^^^^^^^^

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #687: FILE: net/bluetooth/hci_request.c:2122:
+ if (!hci_dev_test_flag(hdev, HCI_LE_SCAN) ||
+ hci_dev_test_flag(hdev, HCI_MESH))

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #747: FILE: net/bluetooth/hci_request.c:2336:
+ * with no filtering */

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #766: FILE: net/bluetooth/hci_request.c:2400:
+ hci_req_sync(hdev, mesh_scan, DISCOV_LE_SCAN_INT,
+ HCI_CMD_TIMEOUT, status);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #770: FILE: net/bluetooth/hci_request.c:2404:
+ hci_req_sync(hdev, active_scan,
+ hdev->le_scan_int_discovery,

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #839: FILE: net/bluetooth/hci_sync.c:1146:
+int hci_mesh_send_sync(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 bdaddr_type,
+ u8 *data, u8 len)

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #862: FILE: net/bluetooth/hci_sync.c:1169:
+ __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_ADV_PARAM,
+ sizeof(cp_param), &cp_param,

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #866: FILE: net/bluetooth/hci_sync.c:1173:
+ err = __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_ADV_DATA,
+ sizeof(cp_data), &cp_data, HCI_CMD_TIMEOUT);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1088: FILE: net/bluetooth/mgmt.c:1033:
+static void mesh_send_complete(struct hci_dev *hdev,
+ struct mgmt_mesh_tx *mesh_tx)

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1093: FILE: net/bluetooth/mgmt.c:1038:
+ mgmt_event(MGMT_EV_MESH_PACKET_CMPLT, hdev, &handle, sizeof(handle),
+ NULL);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1122: FILE: net/bluetooth/mgmt.c:1067:
+ err = hci_cmd_sync_queue(hdev, mesh_send_sync, mesh_tx,
+ mesh_send_start_complete);

CHECK:LINE_SPACING: Please don't use multiple blank lines #1158: FILE: net/bluetooth/mgmt.c:2095:

+

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1184: FILE: net/bluetooth/mgmt.c:2140:
+ mgmt_pending_foreach(MGMT_OP_SET_MESH_RECEIVER, hdev,
+ cmd_status_rsp, &status);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1195: FILE: net/bluetooth/mgmt.c:2151:
+ mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_MESH_RECEIVER, 0,
+ &slots, 1);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1244: FILE: net/bluetooth/mgmt.c:2200:
+ err = hci_cmd_sync_queue(hdev, set_mesh_sync, cmd,
+ set_mesh_complete);

CHECK:LINE_SPACING: Please don't use multiple blank lines #1246: FILE: net/bluetooth/mgmt.c:2202:
+
+

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1249: FILE: net/bluetooth/mgmt.c:2205:
+ err = mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_MESH_RECEIVER,
+ MGMT_STATUS_FAILED);

CHECK:SPACING: No space is necessary after a cast
#1262: FILE: net/bluetooth/mgmt.c:2218:
+ struct mgmt_cp_mesh_send *send = (void *) mesh_tx->param;

CHECK:SPACING: No space is necessary after a cast
#1283: FILE: net/bluetooth/mgmt.c:2239:
+ struct mgmt_cp_mesh_send *send = (void *) mesh_tx->param;

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1304: FILE: net/bluetooth/mgmt.c:2260:
+static int mesh_features(struct sock *sk, struct hci_dev *hdev,
+ void *data, u16 len)

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1323: FILE: net/bluetooth/mgmt.c:2279:
+ mgmt_cmd_complete(sk, hdev->id, MGMT_OP_MESH_READ_FEATURES, 0, &rp,
+ rp.used_handles + sizeof(rp) - MESH_HANDLES_MAX);

CHECK:SPACING: No space is necessary after a cast
#1332: FILE: net/bluetooth/mgmt.c:2288:
+ struct mgmt_cp_mesh_send_cancel *cancel = (void *) cmd->param;

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1350: FILE: net/bluetooth/mgmt.c:2306:
+ mgmt_cmd_complete(cmd->sk, hdev->id, MGMT_OP_MESH_SEND_CANCEL,
+ 0, NULL, 0);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1357: FILE: net/bluetooth/mgmt.c:2313:
+static int mesh_send_cancel(struct sock *sk, struct hci_dev *hdev,
+ void *data, u16 len)

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1394: FILE: net/bluetooth/mgmt.c:2350:
+ if (!hci_dev_test_flag(hdev, HCI_LE_ENABLED) ||
+ len <= MGMT_MESH_SEND_SIZE ||

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1408: FILE: net/bluetooth/mgmt.c:2364:
+ err = mgmt_cmd_status(sk, hdev->id, MGMT_OP_MESH_SEND,
+ MGMT_STATUS_BUSY);

CHECK:LINE_SPACING: Please don't use multiple blank lines #1412: FILE: net/bluetooth/mgmt.c:2368:
+
+

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1420: FILE: net/bluetooth/mgmt.c:2376:
+ err = hci_cmd_sync_queue(hdev, mesh_send_sync, mesh_tx,
+ mesh_send_start_complete);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1425: FILE: net/bluetooth/mgmt.c:2381:
+ err = mgmt_cmd_status(sk, hdev->id, MGMT_OP_MESH_SEND,
+ MGMT_STATUS_FAILED);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hdev->adv_tx_power != HCI_TX_POWER_INVALID' #1477: FILE: net/bluetooth/mgmt.c:8166:
+ if ((hdev->adv_tx_power != HCI_TX_POWER_INVALID) || use_ext_adv(hdev))

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1505: FILE: net/bluetooth/mgmt.c:10071:
+static void mesh_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr,
+ u8 addr_type, s8 rssi, u32 flags, u8 *eir, u16 eir_len,

CHECK:LINE_SPACING: Please don't use multiple blank lines #1542: FILE: net/bluetooth/mgmt.c:10108:
+
+

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1582: FILE: net/bluetooth/mgmt.c:10147:
+ mesh_device_found(hdev, bdaddr, addr_type, rssi, flags,
+ eir, eir_len, scan_rsp, scan_rsp_len, instant);

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1597: FILE: net/bluetooth/mgmt_util.c:319:
+void mgmt_mesh_foreach(struct hci_dev *hdev,
+ void (*cb)(struct mgmt_mesh_tx *mesh_tx, void *data),

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1678: FILE: net/bluetooth/mgmt_util.h:72:
+void mgmt_mesh_foreach(struct hci_dev *hdev,
+ void (*cb)(struct mgmt_mesh_tx *mesh_tx, void *data),

total: 0 errors, 2 warnings, 33 checks, 1441 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12797522.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

[3/3] Bluetooth: Add experimental wrapper for MGMT based mesh\CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #121: FILE: net/bluetooth/mgmt.c:2179:
+ if (!lmp_le_capable(hdev) ||
+ !hci_dev_test_flag(hdev, HCI_MESH_EXPERIMENTAL))

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #131: FILE: net/bluetooth/mgmt.c:2259:
+ if (!lmp_le_capable(hdev) ||
+ !hci_dev_test_flag(hdev, HCI_MESH_EXPERIMENTAL))

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #140: FILE: net/bluetooth/mgmt.c:2314:
+ if (!lmp_le_capable(hdev) ||
+ !hci_dev_test_flag(hdev, HCI_MESH_EXPERIMENTAL))

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #152: FILE: net/bluetooth/mgmt.c:2350:
+ if (!lmp_le_capable(hdev) ||
+ !hci_dev_test_flag(hdev, HCI_MESH_EXPERIMENTAL))

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #217: FILE: net/bluetooth/mgmt.c:4372:
+ status = mgmt_cmd_complete(sk, hdev ? hdev->id : MGMT_INDEX_NONE,
MGMT_OP_READ_EXP_FEATURES_INFO,

CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #230: FILE: net/bluetooth/mgmt.c:4504:
+static int set_mgmt_mesh_func(struct sock *sk, struct hci_dev *hdev,
+ struct mgmt_cp_set_exp_feature *cp,

CHECK:BRACES: Unbalanced braces around else statement #266: FILE: net/bluetooth/mgmt.c:4540:
+ else {

CHECK:LINE_SPACING: Please don't use multiple blank lines #272: FILE: net/bluetooth/mgmt.c:4546:
+
+

total: 0 errors, 0 warnings, 8 checks, 204 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12797521.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: TestRunner: mgmt-tester - FAIL - 116.15 seconds Run test-runner with mgmt-tester
Total: 493, Passed: 492 (99.8%), Failed: 1, Not Run: 0

Failed Test Cases
Read Exp Feature - Success Failed 0.120 seconds

---
Regards,
Linux Bluetooth

author
#3 lore raw

PATCH 2/3 Bluetooth: Implement support for Mesh

In reply to Brian Gix

The patch adds state bits, storage and HCI command chains for sending and recieving Bluetooth Mesh advertising packets, and delivery to requesting user space processes. It specifically creates 4 new MGMT commands and 2 new MGMT events:

MGMT_OP_SET_MESH_RECEIVER - Sets passive scan parameters and a list of AD Types which will trigger Mesh Packet Received events

MGMT_OP_MESH_READ_FEATURES - Returns information on how many outbound Mesh packets can be simultaneously queued, and what the currently queued handles are.

MGMT_OP_MESH_SEND - Command to queue a specific outbound Mesh packet, with the number of times it should be sent, and the BD Addr to use.

MGMT_OP_MESH_SEND_CANCEL - Command to cancel a prior outbound message request.

MGMT_EV_MESH_DEVICE_FOUND - Event to deliver entire received Mesh Advertisement packet, along with timing information.

MGMT_EV_MESH_PACKET_CMPLT - Event to indicate that an outbound packet is no longer queued for delivery.

---
 include/net/bluetooth/hci.h      |   3 +
 include/net/bluetooth/hci_core.h |  18 +-
 include/net/bluetooth/hci_sync.h |   3 +
 include/net/bluetooth/mgmt.h     |  51 ++++
 net/bluetooth/hci_conn.c         |   2 +-
 net/bluetooth/hci_core.c         |   1 +
 net/bluetooth/hci_event.c        |  61 +++--
 net/bluetooth/hci_request.c      | 115 ++++++--
 net/bluetooth/hci_sync.c         | 104 ++++++--
 net/bluetooth/mgmt.c             | 432 ++++++++++++++++++++++++++++++-
 net/bluetooth/mgmt_util.c        |  58 +++++
 net/bluetooth/mgmt_util.h        |  17 ++
 12 files changed, 786 insertions(+), 79 deletions(-)
include/net/bluetooth/hci.h +3 -0
index 5cb095b09a94..71ffc8d20e50 100644
@@ -353,6 +353,9 @@ enum {
 	HCI_OFFLOAD_CODECS_ENABLED,
 	HCI_LE_SIMULTANEOUS_ROLES,
 
+	HCI_MESH,
+	HCI_MESH_SENDING,
+
 	__HCI_NUM_FLAGS,
 };
 
include/net/bluetooth/hci_core.h +16 -2
index d5377740e99c..5a32c91f27c7 100644
@@ -357,6 +357,8 @@ struct hci_dev {
 	__u8		le_resolv_list_size;
 	__u8		le_num_of_adv_sets;
 	__u8		le_states[8];
+	__u8		mesh_ad_types[16];
+	__u8		mesh_send_ref;
 	__u8		commands[64];
 	__u8		hci_ver;
 	__u16		hci_rev;
@@ -544,6 +546,7 @@ struct hci_dev {
 
 	struct hci_conn_hash	conn_hash;
 
+	struct list_head	mesh_pending;
 	struct list_head	mgmt_pending;
 	struct list_head	reject_list;
 	struct list_head	accept_list;
@@ -595,6 +598,8 @@ struct hci_dev {
 	struct delayed_work	rpa_expired;
 	bdaddr_t		rpa;
 
+	struct delayed_work	mesh_send_done;
+
 	enum {
 		INTERLEAVE_SCAN_NONE,
 		INTERLEAVE_SCAN_NO_FILTER,
@@ -1497,7 +1502,9 @@ void hci_conn_del_sysfs(struct hci_conn *conn);
 
 /* Use ext scanning if set ext scan param and ext scan enable is supported */
 #define use_ext_scan(dev) (((dev)->commands[37] & 0x20) && \
-			   ((dev)->commands[37] & 0x40))
+			   ((dev)->commands[37] & 0x40) && \
+			   !hci_dev_test_flag(dev, HCI_MESH))
+
 /* Use ext create connection if command is supported */
 #define use_ext_conn(dev) ((dev)->commands[37] & 0x80)
 
@@ -1512,6 +1519,10 @@ void hci_conn_del_sysfs(struct hci_conn *conn);
 #define use_enhanced_conn_complete(dev) (ll_privacy_capable(dev) || \
 					 ext_adv_capable(dev))
 
+/* Use ext advertising if supported and not running Mesh */
+#define use_ext_adv(dev) (ext_adv_capable(dev) && \
+			  !hci_dev_test_flag(dev, HCI_MESH))
+
 /* ----- HCI protocols ----- */
 #define HCI_PROTO_DEFER             0x01
 
@@ -1793,6 +1804,8 @@ void hci_mgmt_chan_unregister(struct hci_mgmt_chan *c);
 #define DISCOV_LE_RESTART_DELAY		msecs_to_jiffies(200)	/* msec */
 #define DISCOV_LE_FAST_ADV_INT_MIN	0x00A0	/* 100 msec */
 #define DISCOV_LE_FAST_ADV_INT_MAX	0x00F0	/* 150 msec */
+#define DISCOV_LE_ADV_MESH_MIN		0x00A0  /* 100 msec */
+#define DISCOV_LE_ADV_MESH_MAX		0x00A0  /* 100 msec */
 
 #define NAME_RESOLVE_DURATION		msecs_to_jiffies(10240)	/* 10.24 sec */
 
@@ -1844,7 +1857,8 @@ void mgmt_start_discovery_complete(struct hci_dev *hdev, u8 status);
 void mgmt_stop_discovery_complete(struct hci_dev *hdev, u8 status);
 void mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
 		       u8 addr_type, u8 *dev_class, s8 rssi, u32 flags,
-		       u8 *eir, u16 eir_len, u8 *scan_rsp, u8 scan_rsp_len);
+		       u8 *eir, u16 eir_len, u8 *scan_rsp, u8 scan_rsp_len,
+		       u32 instant);
 void mgmt_remote_name(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
 		      u8 addr_type, s8 rssi, u8 *name, u8 name_len);
 void mgmt_discovering(struct hci_dev *hdev, u8 discovering);
include/net/bluetooth/hci_sync.h +3 -0
index 2492e3b46a8f..b86a3bcf0814 100644
@@ -85,6 +85,9 @@ int hci_remove_ext_adv_instance_sync(struct hci_dev *hdev, u8 instance,
 struct sk_buff *hci_read_local_oob_data_sync(struct hci_dev *hdev, bool ext,
 					     struct sock *sk);
 
+int hci_mesh_send_sync(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 bdaddr_type,
+							u8 *data, u8 len);
+
 int hci_reset_sync(struct hci_dev *hdev);
 int hci_dev_open_sync(struct hci_dev *hdev);
 int hci_dev_close_sync(struct hci_dev *hdev);
include/net/bluetooth/mgmt.h +51 -0

60 lines not on this page · raw message

net/bluetooth/hci_conn.c +1 -1
index 84312c836549..db4a0c98e231 100644
@@ -638,7 +638,7 @@ static void hci_conn_auto_accept(struct work_struct *work)
 
 static void le_disable_advertising(struct hci_dev *hdev)
 {
-	if (ext_adv_capable(hdev)) {
+	if (use_ext_adv(hdev)) {
 		struct hci_cp_le_set_ext_adv_enable cp;
 
 		cp.enable = 0x00;
net/bluetooth/hci_core.c +1 -0
index b4782a6c1025..66ca5321ef34 100644
@@ -2487,6 +2487,7 @@ struct hci_dev *hci_alloc_dev_priv(int sizeof_priv)
 	mutex_init(&hdev->lock);
 	mutex_init(&hdev->req_lock);
 
+	INIT_LIST_HEAD(&hdev->mesh_pending);
 	INIT_LIST_HEAD(&hdev->mgmt_pending);
 	INIT_LIST_HEAD(&hdev->reject_list);
 	INIT_LIST_HEAD(&hdev->accept_list);
net/bluetooth/hci_event.c +38 -23

195 lines not on this page · raw message

net/bluetooth/hci_request.c +90 -25

252 lines not on this page · raw message

net/bluetooth/hci_sync.c +84 -20

239 lines not on this page · raw message

net/bluetooth/mgmt.c +424 -8

515 lines not on this page · raw message

net/bluetooth/mgmt_util.c +58 -0

61 lines not on this page · raw message

net/bluetooth/mgmt_util.h +17 -0
index 98e40395a383..54930b18038e 100644
@@ -20,6 +20,15 @@
    SOFTWARE IS DISCLAIMED.
 */
 
+struct mgmt_mesh_tx {
+	struct list_head list;
+	int index;
+	size_t param_len;
+	struct sock *sk;
+	u8 handle;
+	u8 param[sizeof(struct mgmt_cp_mesh_send) + 29];
+};
+
 struct mgmt_pending_cmd {
 	struct list_head list;
 	u16 opcode;
@@ -59,3 +68,11 @@ struct mgmt_pending_cmd *mgmt_pending_new(struct sock *sk, u16 opcode,
 					  void *data, u16 len);
 void mgmt_pending_free(struct mgmt_pending_cmd *cmd);
 void mgmt_pending_remove(struct mgmt_pending_cmd *cmd);
+void mgmt_mesh_foreach(struct hci_dev *hdev,
+			  void (*cb)(struct mgmt_mesh_tx *mesh_tx, void *data),
+			  void *data);
+struct mgmt_mesh_tx *mgmt_mesh_find(struct hci_dev *hdev, u8 handle);
+struct mgmt_mesh_tx *mgmt_mesh_next(struct hci_dev *hdev);
+struct mgmt_mesh_tx *mgmt_mesh_add(struct sock *sk, struct hci_dev *hdev,
+				   void *data, u16 len);
+void mgmt_mesh_remove(struct mgmt_mesh_tx *mesh_tx);
Signature · 1 line
2.35.1
author
#4 lore raw

PATCH 3/3 Bluetooth: Add experimental wrapper for MGMT based mesh

In reply to Brian Gix

This introduces a "Mesh UUID" and an Experimental Feature bit to the hdev mask, and depending all underlying Mesh functionality on it.

---
 include/net/bluetooth/hci.h |   1 +
 net/bluetooth/mgmt.c        | 120 +++++++++++++++++++++++++++++++-----
 2 files changed, 107 insertions(+), 14 deletions(-)
include/net/bluetooth/hci.h +1 -0
index 71ffc8d20e50..fee67decb53e 100644
@@ -353,6 +353,7 @@ enum {
 	HCI_OFFLOAD_CODECS_ENABLED,
 	HCI_LE_SIMULTANEOUS_ROLES,
 
+	HCI_MESH_EXPERIMENTAL,
 	HCI_MESH,
 	HCI_MESH_SENDING,
 
net/bluetooth/mgmt.c +106 -14

197 lines not on this page · raw message

Signature · 1 line
2.35.1
#5 lore raw
In reply to Brian Gix
This series was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann <[email protected]>:

Hello:

This series was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann <[email protected]>:

Quoted 8 lines · On Thu, 31 Mar 2022 11:07:46 -0700 you wrote:

Housekeeping and implementation.

Brian Gix (3):
Bluetooth: Keep MGMT pending queue ordered FIFO
Bluetooth: Implement support for Mesh
Bluetooth: Add experimental wrapper for MGMT based mesh

[...]

Here is the summary with links:
- [1/3] Bluetooth: Keep MGMT pending queue ordered FIFO

    https://git.kernel.org/bluetooth/bluetooth-next/c/2598fe7291d8

- [2/3] Bluetooth: Implement support for Mesh
(no matching commit)
- [3/3] Bluetooth: Add experimental wrapper for MGMT based mesh (no matching commit)

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html