Skip to contentSkip to conversation

soc/tegra: pmc: update Tegra234 reset sources

PATCH Superseded Sandipan Patra 2 participants 3 messages Apr 1, 2022 Tegra architecture support

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 soc/tegra: pmc: update Tegra234 reset sources

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

---
Update on V2 patch:
space inside comment and
Changed decimal to hexadecimal notation in the comments.

 drivers/soc/tegra/pmc.c | 31 ++++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)
drivers/soc/tegra/pmc.c +24 -7
index fdf508e03400..3799669813e2 100644
@@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
 };
 
 static const char * const tegra234_reset_sources[] = {
-	"SYS_RESET_N",
+	"SYS_RESET_N",	/* 0x0 */
 	"AOWDT",
 	"BCCPLEXWDT",
 	"BPMPWDT",
@@ -3775,18 +3775,35 @@ static const char * const tegra234_reset_sources[] = {
 	"APEWDT",
 	"LCCPLEXWDT",
 	"SENSOR",
-	"AOTAG",
-	"VFSENSOR",
+	NULL,
+	NULL,
 	"MAINSWRST",
 	"SC7",
 	"HSM",
-	"CSITE",
+	NULL,
 	"RCEWDT",
-	"PVA0WDT",
-	"PVA1WDT",
-	"L1A_ASYNC",
+	NULL,		/* 0x10 */
+	NULL,
+	NULL,
 	"BPMPBOOT",
 	"FUSECRC",
+	"DCEWDT",
+	"PSCWDT",
+	"PSC",
+	"CSITE_SW",
+	"POD",
+	"SCPM",
+	"VREFRO_POWERBAD",
+	"VMON",
+	"FMON",
+	"FSI_R5WDT",
+	"FSI_THERM",
+	"FSI_R52C0WDT",	/* 0x20 */
+	"FSI_R52C1WDT",
+	"FSI_R52C2WDT",
+	"FSI_R52C3WDT",
+	"FSI_FMON",
+	"FSI_VMON"	/* 0x25 */
 };
 
 static const struct tegra_wake_event tegra234_wake_events[] = {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Sandipan Patra

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

...

drivers/soc/tegra/pmc.c static const char * const tegra234_reset_sources[] = { · line 3785

Quoted 1 line
drivers/soc/tegra/pmc.c +1 -0
+	NULL,		/* 0x10 */

I would suggest to add the comments more often, like every 8 entries.

...

drivers/soc/tegra/pmc.c static const char * const tegra234_reset_sources[] = { · line 3806

Quoted 1 line
drivers/soc/tegra/pmc.c +1 -0
+	"FSI_VMON"	/* 0x25 */

It would be good to have comma here as if this ever getting expanded the additional churn may be avoided.

Quoted 1 line

};

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Thank you Andy.
Pushed V3 patch addressing recent comments.
Please help to review.

Thanks & Regards,
Sandipan

Quoted 36 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Friday, April 1, 2022 7:14 PM
To: Sandipan Patra <[email protected]>
Cc: Thierry Reding <[email protected]>; Jonathan Hunter <[email protected]>; [email protected]; [email protected]; [email protected]; Bibek Basu <[email protected]>; linux- [email protected]; [email protected]
Subject: Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources

External email: Use caution opening links or attachments

Quoted 2 lines · Sandipan Patra

Reset_sources list is updated to add all reset sources and removing ones that do not actually exist.

...

Quoted 1 line

+ NULL, /* 0x10 */

I would suggest to add the comments more often, like every 8 entries.

...

Quoted 1 line

+ "FSI_VMON" /* 0x25 */

It would be good to have comma here as if this ever getting expanded the additional churn may be avoided.

Quoted 1 line

};

--
With Best Regards,
Andy Shevchenko