Skip to contentSkip to conversation

drm: bridge: mcde_dsi: Drop explicit bridge remove

PATCH Applied Jagan Teki 3 participants 3 messages Apr 1, 2022 – Apr 4, 2022

Subsystems (3)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 drm: bridge: mcde_dsi: Drop explicit bridge remove

This driver has been changed to use the resource managed devm_drm_of_get_bridge() to get bridge from ->bind(), it's unnecessary to call drm_of_panel_bridge_remove() to remove the bridge from ->unbind() as devm_drm_of_get_bridge() is automatically remove the bridge when @dev is unbound.

Drop it the drm_bridge_remove().

---
 drivers/gpu/drm/mcde/mcde_dsi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/mcde/mcde_dsi.c +0 -1
index 083a4728654d..960b49ea2ee5 100644
@@ -1122,7 +1122,6 @@ static void mcde_dsi_unbind(struct device *dev, struct device *master,
 {
 	struct mcde_dsi *d = dev_get_drvdata(dev);
 
-	drm_bridge_remove(d->bridge_out);
 	regmap_update_bits(d->prcmu, PRCM_DSI_SW_RESET,
 			   PRCM_DSI_SW_RESET_DSI0_SW_RESETN, 0);
 }
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Jagan Teki

This driver has been changed to use the resource managed devm_drm_of_get_bridge() to get bridge from ->bind(), it's unnecessary to call drm_of_panel_bridge_remove() to remove the bridge from ->unbind() as devm_drm_of_get_bridge() is automatically remove the bridge when @dev is unbound.

Drop it the drm_bridge_remove().

Yours,
Linus Walleij