drm: bridge: mcde_dsi: Drop explicit bridge remove
Subsystems (3)
PATCH 1/1 drm: bridge: mcde_dsi: Drop explicit bridge remove
This driver has been changed to use the resource managed devm_drm_of_get_bridge() to get bridge from ->bind(), it's unnecessary to call drm_of_panel_bridge_remove() to remove the bridge from ->unbind() as devm_drm_of_get_bridge() is automatically remove the bridge when @dev is unbound.
Drop it the drm_bridge_remove().
Cc Linus Walleij <[email protected]>
Reported-by Maxime Ripard <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
--- drivers/gpu/drm/mcde/mcde_dsi.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/mcde/mcde_dsi.c +0 -1
@@ -1122,7 +1122,6 @@ static void mcde_dsi_unbind(struct device *dev, struct device *master, {struct mcde_dsi *d =dev_get_drvdata (dev); -drm_bridge_remove (d->bridge_out);regmap_update_bits (d->prcmu,PRCM_DSI_SW_RESET ,PRCM_DSI_SW_RESET_DSI0_SW_RESETN ,0 ); }
Signature · 1 line
2.25.1
Quoted 11 lines · Jagan Teki
This driver has been changed to use the resource managed
devm_drm_of_get_bridge()to get bridge from ->bind(), it's unnecessary to calldrm_of_panel_bridge_remove()to remove the bridge from ->unbind() asdevm_drm_of_get_bridge()is automatically remove the bridge when @dev is unbound.Drop it the
drm_bridge_remove().Cc Linus Walleij <[email protected]>Reported-by Maxime Ripard <[email protected]>Signed-off-by Jagan Teki <[email protected]>
Reviewed-by Linus Walleij <[email protected]>
Yours,
Linus Walleij
Robert Foss
AppliedApplied to drm-misc-next.