Skip to contentSkip to conversation

tools/vm/page_owner_sort.c: remove -c option

PATCH New Andrew Morton 1 participant 1 message Apr 1, 2022 Memory management

lore
Share & tools
lore

Andrew Morton

author maintainer
#0 lore raw

PATCH 13/16 tools/vm/page_owner_sort.c: remove -c option

From: Yinan Zhang <[email protected]>
Subject: tools/vm/page_owner_sort.c: remove -c option

-c option is used to cull by stacktrace. Now, --cull option has been Added in page_owner_sort.c. Culling by stacktrace is one of the function of "--cull". No need to set an extra parameter. So remove -c option.

Remove parsing of -c when parse parameter and remove "-c" from usage.

This work is coauthored by
Shenghong Han
Yixuan Cao
Chongxi Zhao
Jiajian Ye
Yuhong Feng
Yongqiang Liu

Cc Chongxi Zhao <[email protected]>
Cc Georgi Djakov <[email protected]>
Cc Jiajian Ye <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Sean Anderson <[email protected]>
Cc Stephen Rothwell <[email protected]>
Cc Tang Bin <[email protected]>
Cc Yixuan Cao <[email protected]>
Cc Yongqiang Liu <[email protected]>
Cc Yuhong Feng <[email protected]>
Cc Zhenliang Wei <[email protected]>

---

 tools/vm/page_owner_sort.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
tools/vm/page_owner_sort.c renamed from tools/vm/page_owner_sort.c~tools-vm-page_owner_sortc-remove-c-option +1 -5
@@ -441,7 +441,6 @@ static void usage(void)
 		"-n\t\tSort by task command name.\n"
 		"-a\t\tSort by memory allocate time.\n"
 		"-r\t\tSort by memory release time.\n"
-		"-c\t\tCull by comparing stacktrace instead of total block.\n"
 		"-f\t\tFilter out the information of blocks whose memory has been released.\n"
 		"--pid <PID>\tSelect by pid. This selects the information of blocks whose process ID number equals to <PID>.\n"
 		"--tgid <TGID>\tSelect by tgid. This selects the information of blocks whose Thread Group ID number equals to <TGID>.\n"
@@ -466,14 +465,11 @@ int main(int argc, char **argv)
 		{ 0, 0, 0, 0},
 	};
 
-	while ((opt = getopt_long(argc, argv, "acfmnprstP", longopts, NULL)) != -1)
+	while ((opt = getopt_long(argc, argv, "afmnprstP", longopts, NULL)) != -1)
 		switch (opt) {
 		case 'a':
 			cmp = compare_ts;
 			break;
-		case 'c':
-			cull = cull | CULL_STACKTRACE;
-			break;
 		case 'f':
 			filter = filter | FILTER_UNRELEASE;
 			break;

_