Skip to contentSkip to conversation

selftests/bpf: Define SYS_NANOSLEEP_KPROBE_NAME for aarch64

PATCH Applied Ilya Leoshkevich 3 participants 3 messages Apr 4, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Define SYS_NANOSLEEP_KPROBE_NAME for aarch64

attach_probe selftest fails on aarch64 with failed to create kprobe 'sys_nanosleep+0x0' perf event: No such file or directory. This is because, like on several other architectures, nanosleep has a prefix.

---
 tools/testing/selftests/bpf/test_progs.h | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/bpf/test_progs.h +2 -0
index 93c1ff705533..eec4c7385b14 100644
@@ -332,6 +332,8 @@ int trigger_module_test_write(int write_sz);
 #define SYS_NANOSLEEP_KPROBE_NAME "__x64_sys_nanosleep"
 #elif defined(__s390x__)
 #define SYS_NANOSLEEP_KPROBE_NAME "__s390x_sys_nanosleep"
+#elif defined(__aarch64__)
+#define SYS_NANOSLEEP_KPROBE_NAME "__arm64_sys_nanosleep"
 #else
 #define SYS_NANOSLEEP_KPROBE_NAME "sys_nanosleep"
 #endif
Signature · 1 line
2.35.1
Tested-by on v1 1/1
#1 lore raw
Quoted 5 lines · Ilya Leoshkevich

attach_probe selftest fails on aarch64 with failed to create kprobe 'sys_nanosleep+0x0' perf event: No such file or directory. This is because, like on several other architectures, nanosleep has a prefix.

Thanks for adding this! I'm seeing a clean test pass on aarch64 now:

Quoted 21 lines
---
 tools/testing/selftests/bpf/test_progs.h | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/bpf/test_progs.h +2 -0
index 93c1ff705533..eec4c7385b14 100644
@@ -332,6 +332,8 @@ int trigger_module_test_write(int write_sz);
 #define SYS_NANOSLEEP_KPROBE_NAME "__x64_sys_nanosleep"
 #elif defined(__s390x__)
 #define SYS_NANOSLEEP_KPROBE_NAME "__s390x_sys_nanosleep"
+#elif defined(__aarch64__)
+#define SYS_NANOSLEEP_KPROBE_NAME "__arm64_sys_nanosleep"
 #else
 #define SYS_NANOSLEEP_KPROBE_NAME "sys_nanosleep"
 #endif
Signature · 1 line
2.35.1
#2 lore raw
In reply to Ilya Leoshkevich
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 8 lines · On Mon, 4 Apr 2022 16:21:01 +0200 you wrote:

attach_probe selftest fails on aarch64 with failed to create kprobe 'sys_nanosleep+0x0' perf event: No such file or directory. This is because, like on several other architectures, nanosleep has a prefix.

---
 tools/testing/selftests/bpf/test_progs.h | 2 ++
 1 file changed, 2 insertions(+)

Here is the summary with links:
- [bpf-next] selftests/bpf: Define SYS_NANOSLEEP_KPROBE_NAME for aarch64

    https://git.kernel.org/bpf/bpf-next/c/d298761746d5

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html