Skip to contentSkip to conversation

PCI: vmd: Assign VMD IRQ domain before enumeration

PATCH Patel, Nirmal 2 participants 2 messages Apr 28, 2022 1 message not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 30 lines · Nirmal Patel

VMD creates and assigns a separate IRQ domain only when MSI remapping is enabled. For example VMD-MSI. But VMD doesn't assign IRQ domain when MSI remapping is disabled resulting child devices getting default PCI-MSI IRQ domain. Now when interrupt remapping is enabled by intel-iommu all the PCI devices are assigned INTEL-IR-MSI domain including VMD endpoints. But devices behind VMD get PCI-MSI IRQ domain when VMD create a root bus and configures child devices.

As a result DMAR errors were observed when interrupt remapping was enabled on Intel Icelake CPUs. For instance:

DMAR: DRHD: handling fault status reg 2
DMAR: [INTR-REMAP] Request device [0xe2:0x00.0] fault index 0xa00 [fault reason 0x25] Blocked a compatibility format interrupt request

---
v2->v3: Update commit log.
v1->v2: Split patch into two separate patches. One applies the fix and
other reverts the commit 2565e5b69c44 which was added as a workaround.

---
 drivers/pci/controller/vmd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/pci/controller/vmd.c +0 -0
index cc166c683638..3a6570e5b765 100644

drivers/pci/controller/vmd.c static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features) · line 860

Quoted 8 lines
drivers/pci/controller/vmd.c +2 -0
@@ -853,6 +853,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
 	vmd_attach_resources(vmd);
 	if (vmd->irq_domain)
 		dev_set_msi_domain(&vmd->bus->dev, vmd->irq_domain);
+	else
+		dev_set_msi_domain(&vmd->bus->dev, dev_get_msi_domain(&vmd->dev->dev));
 
 	vmd_acpi_begin();
 

Gentle reminder.

Thanks
nirmal

#2 lore raw
Quoted 37 lines · Nirmal
Quoted 36 lines · Nirmal Patel

VMD creates and assigns a separate IRQ domain only when MSI remapping is enabled. For example VMD-MSI. But VMD doesn't assign IRQ domain when MSI remapping is disabled resulting child devices getting default PCI-MSI IRQ domain. Now when interrupt remapping is enabled by intel-iommu all the PCI devices are assigned INTEL-IR-MSI domain including VMD endpoints. But devices behind VMD get PCI-MSI IRQ domain when VMD create a root bus and configures child devices.

As a result DMAR errors were observed when interrupt remapping was enabled on Intel Icelake CPUs. For instance:

DMAR: DRHD: handling fault status reg 2
DMAR: [INTR-REMAP] Request device [0xe2:0x00.0] fault index 0xa00 [fault reason 0x25] Blocked a compatibility format interrupt request

---
v2->v3: Update commit log.
v1->v2: Split patch into two separate patches. One applies the fix and
other reverts the commit 2565e5b69c44 which was added as a workaround.

---
 drivers/pci/controller/vmd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/pci/controller/vmd.c +2 -0
index cc166c683638..3a6570e5b765 100644
@@ -853,6 +853,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
 	vmd_attach_resources(vmd);
 	if (vmd->irq_domain)
 		dev_set_msi_domain(&vmd->bus->dev, vmd->irq_domain);
+	else
+		dev_set_msi_domain(&vmd->bus->dev, dev_get_msi_domain(&vmd->dev->dev));
 
Quoted 4 lines

drivers/pci/controller/vmd.c static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features) · line 860

Quoted 2 lines
drivers/pci/controller/vmd.c +0 -0
 	vmd_acpi_begin();
 

Gentle reminder.

Instead of sending these reminders, could you please, as Bjorn requested, fix your patch posting flow to make sure your patches are logged in lore and patchwork/linux-pci, where I look for patches to review please ?

There is no point in sending reminders for something I don't see, I have no idea you are waiting for me to review this series if it does not show up in patchwork/linux-pci, if it is not there for me it does not exist.

Thanks,
Lorenzo