drm/amdgpu: Unnecessary code in gfx_v7_0.c
Subsystems (2)
PATCH 1/1 drm/amdgpu: Unnecessary code in gfx_v7_0.c
The code is useless and doesn't change the value.
(0 << GB_ADDR_CONFIG__ROW_SIZE__SHIFT) = 0gb_addr_config | 0 = gb_addr_config
Perhaps there could be 1 instead of 0, but this does not correspond with the logic of the switch.
--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +2 -4
@@ -4409,16 +4409,14 @@ static void gfx_v7_0_gpu_early_init(struct amdgpu_device *adev)/* fix up row size */ gb_addr_config &= ~GB_ADDR_CONFIG__ROW_SIZE_MASK ;switch (adev->gfx.config.mem_row_size_in_kb) { -case 1 : -default : - gb_addr_config |= (0 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT ); -break ;case 2 : gb_addr_config |= (1 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT );break ;case 4 : gb_addr_config |= (2 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT );break ; +default : +break ; } adev->gfx.config.gb_addr_config = gb_addr_config; }
Signature · 1 line
2.35.1
Quoted 8 lines · Grigory Vasilyev
The code is useless and doesn't change the value.
(0 <<
GB_ADDR_CONFIG__ROW_SIZE__SHIFT) = 0gb_addr_config| 0 =gb_addr_configPerhaps there could be 1 instead of 0, but this does not correspond with the logic of the switch.
It doesn't do anything, but it helps the developer to understand how the driver state maps to hardware state.
Alex
Quoted 32 lines
Signed-off-by Grigory Vasilyev <[email protected]>--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +2
-5@@ -4409,16 +4409,14 @@ static void gfx_v7_0_gpu_early_init(struct amdgpu_device *adev)/* fix up row size */ gb_addr_config &= ~GB_ADDR_CONFIG__ROW_SIZE_MASK ;switch (adev->gfx.config.mem_row_size_in_kb) { -case 1 : -default : - gb_addr_config |= (0 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT ); -break ;case 2 : gb_addr_config |= (1 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT );break ;case 4 : gb_addr_config |= (2 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT );break ; +default : +break ; } adev->gfx.config.gb_addr_config = gb_addr_config; } --2.35.1
Alex Deucher, Thanks, that's what I thought too. But this code is uninformative, and without it is clear what this code is doing. If you need to provide additional information on how the code works, then for me it's better to leave a comment.
This is actually more like a bug than an explanation of what the code is doing.
ср, 6 апр. 2022 г. в 16:20, Alex Deucher <[email protected]>:
Quoted 48 lines · Grigory Vasilyev
Quoted 8 lines
The code is useless and doesn't change the value.
(0 <<
GB_ADDR_CONFIG__ROW_SIZE__SHIFT) = 0gb_addr_config| 0 =gb_addr_configPerhaps there could be 1 instead of 0, but this does not correspond with the logic of the switch.
It doesn't do anything, but it helps the developer to understand how the driver state maps to hardware state.
Alex
Quoted 32 lines
Signed-off-by Grigory Vasilyev <[email protected]>--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +2
-5@@ -4409,16 +4409,14 @@ static void gfx_v7_0_gpu_early_init(struct amdgpu_device *adev)/* fix up row size */ gb_addr_config &= ~GB_ADDR_CONFIG__ROW_SIZE_MASK ;switch (adev->gfx.config.mem_row_size_in_kb) { -case 1 : -default : - gb_addr_config |= (0 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT ); -break ;case 2 : gb_addr_config |= (1 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT );break ;case 4 : gb_addr_config |= (2 <<GB_ADDR_CONFIG__ROW_SIZE__SHIFT );break ; +default : +break ; } adev->gfx.config.gb_addr_config = gb_addr_config; } --2.35.1