display/qxl-render: fix race condition in qxl_cursor (CVE-2021-4207)
PATCH v2 1/1 display/qxl-render: fix race condition in qxl_cursor (CVE-2021-4207)
Avoid fetching 'width' and 'height' a second time to prevent possible race condition. Refer to security advisory
https://starlabs.sg/advisories/22-4207/ for more information.
Fixes CVE-2021-4207
Signed-off-by Mauro Matteo Cascella <[email protected]>
---
v2:
- fix CVE id (CVE-2021-4207 instead of CVE-2022-4207)
hw/display/qxl-render.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/display/qxl-render.c +1 -1
@@ -266,7 +266,7 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor, }break ;case SPICE_CURSOR_TYPE_ALPHA : - size =sizeof (uint32_t ) * cursor->header.width * cursor->header.height; + size =sizeof (uint32_t ) * c->width * c->height;qxl_unpack_chunks (c->data, size, qxl, &cursor->chunk, group_id);if (qxl->debug >2 ) {cursor_print_ascii_art (c,"qxl/alpha" );
Signature · 1 line
2.35.1
Quoted 7 lines · Mauro Matteo Cascella
Avoid fetching 'width' and 'height' a second time to prevent possible race condition. Refer to security advisory
https://starlabs.sg/advisories/22-4207/ for more information.Fixes CVE-2021-4207Signed-off-by Mauro Matteo Cascella <[email protected]>
Reviewed-by Marc-André Lureau <[email protected]>
Quoted 27 lines
---
v2:
- fix CVE id (CVE-2021-4207 instead of CVE-2022-4207)hw/display/qxl-render.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/display/qxl-render.c +1
-1@@ -266,7 +266,7 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor, }break ;case SPICE_CURSOR_TYPE_ALPHA : - size =sizeof (uint32_t ) * cursor->header.width * cursor->header.height; + size =sizeof (uint32_t ) * c->width * c->height;qxl_unpack_chunks (c->data, size, qxl, &cursor->chunk, group_id);if (qxl->debug > 2) { cursor_print_ascii_art(c, "qxl/alpha");--
2.35.1
Signature · 1 line
Marc-André Lureau