Skip to contentSkip to conversation

vsock: add documentation about len header field

PATCH In review Laura Loghin 3 participants 6 messages Apr 7, 2022 – Apr 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 vsock: add documentation about len header field

---
 virtio-vsock.tex | 5 +++++
 1 file changed, 5 insertions(+)
virtio-vsock.tex +5 -0
index d79984d..1d6579b 100644
@@ -107,6 +107,11 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
 #define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
 \end{lstlisting}
 
+\field{len} is the size of the payload, in bytes. However, the driver may
+provide buffer(s) for the payload that have a total size longer than
+\field{len}, in which case only the first \field{len} bytes will be used for
+the actual data.
+
 \subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
 
 The tx virtqueue carries packets initiated by applications and replies to
Signature · 23 lines
2.17.1




Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Reviewed-by on v3 1/1
#1 lore raw
Quoted 4 lines · Laura Loghin

---
virtio-vsock.tex | 5 +++++

1 file changed, 5 insertions(+)
Quoted 16 lines
virtio-vsock.tex +5 -0
index d79984d..1d6579b 100644
@@ -107,6 +107,11 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
 #define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
 \end{lstlisting}
 
+\field{len} is the size of the payload, in bytes. However, the driver may
+provide buffer(s) for the payload that have a total size longer than
+\field{len}, in which case only the first \field{len} bytes will be used for
+the actual data.
+
 \subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
 
Quoted 26 lines

The tx virtqueue carries packets initiated by applications and replies to

Signature · 23 lines
2.17.1




Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Reviewed-by on v3 1/1
#2 lore raw
In reply to Laura Loghin
Quoted 4 lines · Laura Loghin
---
 virtio-vsock.tex | 5 +++++
 1 file changed, 5 insertions(+)

I guess that needs an issue to be included in 1.3?

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#3 lore raw
Quoted 6 lines · Cornelia Huck

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

On Thu, Apr 07 2022, Laura Loghin<[email protected]> wrote:

Quoted 7 lines
Quoted 4 lines
---
  virtio-vsock.tex | 5 +++++
  1 file changed, 5 insertions(+)

I guess that needs an issue to be included in 1.3?

I already openedhttps://github.com/oasis-tcs/virtio-spec/issues/137, is there anything else I should do?

Laura

Quoted 9 lines

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Quoted 9 lines

Subscribe:[email protected] Unsubscribe:[email protected]
List help:[email protected]
List archive:https://lists.oasis-open.org/archives/virtio-comment/ Feedback License:https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines:https://www.oasis-open.org/policies-guidelines/mailing-lists Committee:https://www.oasis-open.org/committees/virtio/
Join OASIS:https://www.oasis-open.org/join/

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

#4 lore raw
Quoted 11 lines · Laura Loghin
Quoted 10 lines · Cornelia Huck

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

Quoted 4 lines · Laura Loghin
---
  virtio-vsock.tex | 5 +++++
  1 file changed, 5 insertions(+)
Quoted 5 lines
Quoted 3 lines

I guess that needs an issue to be included in 1.3?

I already openedhttps://github.com/oasis-tcs/virtio-spec/issues/137, is there anything else I should do?

The patch should have

in it (no need to resend, we can include that before pushing as long as it sits in a reply to the mail); also, please update the issue to point to the v3 patch.

[We still need to open up the 1.3 branch after some editorial stuff has been done; then we can hopefully flush the queue of outstanding issues.]

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#5 lore raw
Quoted 20 lines · Cornelia Huck

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

Quoted 14 lines · Laura Loghin
Quoted 13 lines · Cornelia Huck

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

Quoted 4 lines · Laura Loghin
---
   virtio-vsock.tex | 5 +++++
   1 file changed, 5 insertions(+)

I guess that needs an issue to be included in 1.3?

Quoted 8 lines
Quoted 1 line

I already openedhttps://github.com/oasis-tcs/virtio-spec/issues/137, is there anything else I should do?

The patch should have

in it (no need to resend, we can include that before pushing as long as it sits in a reply to the mail); also, please update the issue to point to the v3 patch.

I updated the link in the issue. Thanks for the guidance!

Laura

Quoted 12 lines

[We still need to open up the 1.3 branch after some editorial stuff has been done; then we can hopefully flush the queue of outstanding issues.]

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Quoted 9 lines

Subscribe:[email protected] Unsubscribe:[email protected]
List help:[email protected]
List archive:https://lists.oasis-open.org/archives/virtio-comment/ Feedback License:https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines:https://www.oasis-open.org/policies-guidelines/mailing-lists Committee:https://www.oasis-open.org/committees/virtio/
Join OASIS:https://www.oasis-open.org/join/

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.