drm/msm: Fix range size vs end confusion
Subsystems (4)
PATCH 1/1 drm/msm: Fix range size vs end confusion
From: Rob Clark <[email protected]>
The fourth param is size, rather than range_end.
Note that we could increase the address space size if we had a way to prevent buffers from spanning a 4G split, mostly just to avoid fw bugs with 64b math.
Fixes 84c31ee16f90 ("drm/msm/a6xx: Add support for per-instance pagetables")
Signed-off-by Rob Clark <[email protected]>
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
@@ -1742,7 +1742,7 @@ a6xx_create_private_address_space(struct msm_gpu *gpu)return ERR_CAST (mmu);return msm_gem_address_space_create (mmu, -"gpu" ,0x100000000ULL ,0x1ffffffffULL ); +"gpu" ,0x100000000ULL ,SZ_4G ); }static uint32_t a6xx_get_rptr (struct msm_gpu *gpu,struct msm_ringbuffer *ring)
Signature · 1 line
2.35.1
Quoted 11 lines · Rob Clark
From: Rob Clark <[email protected]>
The fourth param is size, rather than
range_end.Note that we could increase the address space size if we had a way to prevent buffers from spanning a 4G split, mostly just to avoid fw bugs with 64b math.
Fixes 84c31ee16f90 ("drm/msm/a6xx: Add support for per-instance pagetables")Signed-off-by Rob Clark <[email protected]>
Reviewed-by Dmitry Baryshkov <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1
-2@@ -1742,7 +1742,7 @@ a6xx_create_private_address_space(struct msm_gpu *gpu)return ERR_CAST (mmu);return msm_gem_address_space_create (mmu, -"gpu" ,0x100000000ULL ,0x1ffffffffULL ); +"gpu" ,0x100000000ULL ,SZ_4G ); }static uint32_t a6xx_get_rptr (struct msm_gpu *gpu,struct msm_ringbuffer *ring) --2.35.1
Signature · 2 lines
With best wishes Dmitry