Skip to contentSkip to conversation

perf tools: Fix perf's libperf_print callback

PATCH Applied Adrian Hunter 2 participants 2 messages Apr 8, 2022 – Apr 9, 2022 perf events

lore
Share & tools
lore

Adrian Hunter

author reviewer
#0 lore raw

PATCH 1/1 perf tools: Fix perf's libperf_print callback

eprintf does not expect va_list as the 4th parameter. Use veprintf because it does.

---
 tools/perf/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/perf.c +1 -1
index 2f6b67189b42..6aae7b6c376b 100644
@@ -434,7 +434,7 @@ void pthread__unblock_sigwinch(void)
 static int libperf_print(enum libperf_print_level level,
 			 const char *fmt, va_list ap)
 {
-	return eprintf(level, verbose, fmt, ap);
+	return veprintf(level, verbose, fmt, ap);
 }
 
 int main(int argc, const char **argv)
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw

Em Fri, Apr 08, 2022 at 04:26:25PM +0300, Adrian Hunter escreveu:

Quoted 2 lines

eprintf does not expect va_list as the 4th parameter. Use veprintf because it does.

You forgot to add this:

Fixes 428dab813a56ce94 ("libperf: Merge libperf_set_print() into libperf_init()")

Please consider doing it next time.

Thanks, applied.

- Arnaldo

Quoted 20 lines
---
 tools/perf/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/perf.c +1 -1
index 2f6b67189b42..6aae7b6c376b 100644
@@ -434,7 +434,7 @@ void pthread__unblock_sigwinch(void)
 static int libperf_print(enum libperf_print_level level,
 			 const char *fmt, va_list ap)
 {
-	return eprintf(level, verbose, fmt, ap);
+	return veprintf(level, verbose, fmt, ap);
 }
 
 int main(int argc, const char **argv)
Signature · 1 line
2.25.1
Signature · 1 line
- Arnaldo