tools/xl: fix vif and vcpupin parse tests
PATCH 1/1 tools/xl: fix vif and vcpupin parse tests
Current vif and vcpupin parse tests are out of sync. First of all, xl returns 1 on failure, so replace the expected error code.
Secondly fix the expected output from some vif tests, as xl will no longer print the unpopulated fields.
---
We should find a way for those tests to be run as part of osstest, or else they will go stale again sooner or later.
--- tools/xl/check-xl-vcpupin-parse | 2 +- tools/xl/check-xl-vif-parse | 52 +-------------------------------- 2 files changed, 2 insertions(+), 52 deletions(-)
tools/xl/check-xl-vcpupin-parse +1 -1
@@ -158,7 +158,7 @@ END RANDOM=$seed echo "# Testing a wrong configuration" >> $outfile -write foo 255 "" +write foo 1 "" echo "# Testing the 'all' syntax" >> $outfile write "all" 0 "cpumap: all"
tools/xl/check-xl-vif-parse +1 -51
88 lines not on this page · raw message
Signature · 1 line
2.35.1
Quoted 7 lines · Roger Pau Monne
Current vif and vcpupin parse tests are out of sync. First of all, xl returns 1 on failure, so replace the expected error code.
Secondly fix the expected output from some vif tests, as xl will no longer print the unpopulated fields.
Signed-off-by Roger Pau Monné <[email protected]>
Quoted 3 lines
---
We should find a way for those tests to be run as part of osstest, or else they will go stale again sooner or later.
I guess having those two tests case in "tools/tests/" would be better, then having osstest runs all tests in "tools/tests/" might be the way to go.
Thanks,
Signature · 1 line
Anthony PERARD