Skip to contentSkip to conversation

webkitgtk: Add missing header locale.h

PATCH Superseded Khem Raj 2 participants 2 messages Apr 11, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 webkitgtk: Add missing header locale.h

This fixes build issues seen on mips, but problem is generic

---
 .../webkitgtk/add_missing_include.patch       | 19 +++++++++++++++++++
 meta/recipes-sato/webkit/webkitgtk_2.36.0.bb  |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-sato/webkit/webkitgtk/add_missing_include.patch
meta/recipes-sato/webkit/webkitgtk/add_missing_include.patch new file +19 -0
new file mode 100644
index 00000000000..e60c317a26f
@@ -0,0 +1,19 @@
+Include locale.h for LC_MESSAGE definition
+
+This fixes build error
+Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:115:51: error: use of undeclared identifier 'LC_MESSAGES'
+            return g_variant_new_string(setlocale(LC_MESSAGES, nullptr));
+                                                  ^
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <[email protected]>
+
+--- a/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
++++ b/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
+@@ -30,6 +30,7 @@
+ #include "FrameView.h"
+ #include "Page.h"
+ #include <glib/gi18n-lib.h>
++#include <locale.h>
+ 
+ namespace WebCore {
+ 
meta/recipes-sato/webkit/webkitgtk_2.36.0.bb +1 -0
index 09d44933706..db8a565511a 100644
@@ -15,6 +15,7 @@ SRC_URI = "https://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \
            file://0001-Fix-build-without-opengl-or-es.patch \
            file://reproducibility.patch \
            file://0001-When-building-introspection-files-do-not-quote-CFLAG.patch \
+           file://add_missing_include.patch \
            "
 
 SRC_URI[sha256sum] = "b877cca1f105235f5dd57c7ac2b2c2be3c6b691ff444f93925c7254cf156c64d"
Signature · 1 line
2.35.1
#1 lore raw

Can you submit upstream please?

Alex

Quoted 68 lines · Khem Raj

This fixes build issues seen on mips, but problem is generic

---
 .../webkitgtk/add_missing_include.patch       | 19 +++++++++++++++++++
 meta/recipes-sato/webkit/webkitgtk_2.36.0.bb  |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644

meta/recipes-sato/webkit/webkitgtk/add_missing_include.patch

meta/recipes-sato/webkit/webkitgtk/add_missing_include.patch new file +4 -0
new file mode 100644
index 00000000000..e60c317a26f
@@ -0,0 +1,19 @@
+Include locale.h for LC_MESSAGE definition
+
+This fixes build error
+Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:115:51:

error: use of undeclared identifier 'LC_MESSAGES'

meta/recipes-sato/webkit/webkitgtk/add_missing_include.patch new file +15 -0
+            return g_variant_new_string(setlocale(LC_MESSAGES, nullptr));
+                                                  ^
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <[email protected]>
+
+--- a/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
++++ b/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
+@@ -30,6 +30,7 @@
+ #include "FrameView.h"
+ #include "Page.h"
+ #include <glib/gi18n-lib.h>
++#include <locale.h>
+
+ namespace WebCore {
+
meta/recipes-sato/webkit/webkitgtk_2.36.0.bb +1 -0
index 09d44933706..db8a565511a 100644
@@ -15,6 +15,7 @@ SRC_URI = "
 https://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \
            file://0001-Fix-build-without-opengl-or-es.patch \
            file://reproducibility.patch \
 
 file://0001-When-building-introspection-files-do-not-quote-CFLAG.patch \
+           file://add_missing_include.patch \
            "

SRC_URI[sha256sum] =
"b877cca1f105235f5dd57c7ac2b2c2be3c6b691ff444f93925c7254cf156c64d" --
2.35.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#164185):
https://lists.openembedded.org/g/openembedded-core/message/164185
Mute This Topic: https://lists.openembedded.org/mt/90352028/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-