go: Always pass interpreter to linker
PATCH 1/1 go: Always pass interpreter to linker
From: Joerg Vehlow <[email protected]>
When gos internal linker is used, it uses hardcoded paths to the interpreter (dynamic linker). For x86_64 this hardcoded path is /lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path is /lib64/ld-linux-x86-64.so.2.
Most of the time, the internal linker is not used and binutils linker sets the correct path, but sometimes the internal linker is used and the resulting binary will not work on x86_64.
To ensure the path is always correct, pass it to the linker.
--- meta/classes/go.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/go.bbclass +2 -1
@@ -1,4 +1,5 @@ inherit goarch +inherit linuxloader GO_PARALLEL_BUILD ?= "${@oe.utils.parallel_make_argument(d, '-p %d')}"
@@ -44,7 +45,7 @@ GO_LINKMODE ?= "" GO_LINKMODE:class-nativesdk = "--linkmode=external" GO_LINKMODE:class-native = "--linkmode=external" GO_EXTRA_LDFLAGS ?= "" -GO_LDFLAGS ?= '-ldflags="${GO_RPATH} ${GO_LINKMODE} ${GO_EXTRA_LDFLAGS} -extldflags '${GO_EXTLDFLAGS}'"' +GO_LDFLAGS ?= '-ldflags="${GO_RPATH} ${GO_LINKMODE} -I ${@get_linuxloader(d)} ${GO_EXTRA_LDFLAGS} -extldflags '${GO_EXTLDFLAGS}'"' export GOBUILDFLAGS ?= "-v ${GO_LDFLAGS} -trimpath" export GOPATH_OMIT_IN_ACTIONID ?= "1" export GOPTESTBUILDFLAGS ?= "${GOBUILDFLAGS} -c"
Signature · 1 line
2.25.1
J?rg Vehlow <[email protected]> escreveu no dia segunda, 11/04/2022 à(s) 13:35:
Quoted 7 lines
From: Joerg Vehlow <[email protected]>
When gos internal linker is used, it uses hardcoded paths to the interpreter (dynamic linker). For
x86_64this hardcoded path is/lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path is/lib64/ld-linux-x86-64.so.2.
Is this correct? The first path is the seme one of the second.
Jose
Quoted 47 lines
Most of the time, the internal linker is not used and binutils linker sets the correct path, but sometimes the internal linker is used and the resulting binary will not work on
x86_64.To ensure the path is always correct, pass it to the linker.
Signed-off-by Joerg Vehlow <[email protected]>--- meta/classes/go.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/classes/go.bbclass +2
-2@@ -1,4 +1,5 @@ inherit goarch +inherit linuxloader GO_PARALLEL_BUILD ?= "${@oe.utils.parallel_make_argument(d, '-p %d')}"@@ -44,7 +45,7 @@ GO_LINKMODE ?= "" GO_LINKMODE:class-nativesdk = "--linkmode=external" GO_LINKMODE:class-native = "--linkmode=external" GO_EXTRA_LDFLAGS ?= "" -GO_LDFLAGS ?= '-ldflags="${GO_RPATH} ${GO_LINKMODE} ${GO_EXTRA_LDFLAGS} -extldflags '${GO_EXTLDFLAGS}'"' +GO_LDFLAGS ?= '-ldflags="${GO_RPATH} ${GO_LINKMODE} -I${@get_linuxloader(d)} ${GO_EXTRA_LDFLAGS} -extldflags '${GO_EXTLDFLAGS}'"'
export GOBUILDFLAGS ?= "-v ${GO_LDFLAGS} -trimpath"
exportGOPATH_OMIT_IN_ACTIONID?= "1"
export GOPTESTBUILDFLAGS ?= "${GOBUILDFLAGS} -c"
--
2.25.1-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#164219):
https://lists.openembedded.org/g/openembedded-core/message/164219
Mute This Topic: https://lists.openembedded.org/mt/90393660/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Best regards, José Quaresma
Hi Jose,
Am 4/11/2022 um 3:30 PM schrieb Jose Quaresma:
Quoted 7 lines
J?rg Vehlow <[email protected] <mailto:[email protected]>> escreveu no dia segunda, 11/04/2022 à(s) 13:35:
From: Joerg Vehlow <[email protected] <mailto:[email protected]>>
Quoted 7 lines
When gos internal linker is used, it uses hardcoded paths to the interpreter (dynamic linker). For
x86_64this hardcoded path is/lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path is/lib64/ld-linux-x86-64.so.2.Is this correct? The first path is the seme one of the second.
Yes... of course this is wrong. /lib/ld-linux-x86-64.so.2 is the default linker path for yocto on x86_64
Sorry about that
Joerg
Quoted 7 lines · Jose Quaresma
J?rg Vehlow <[email protected]> escreveu no dia segunda, 11/04/2022 à(s) 13:35:
Quoted 3 lines
From: Joerg Vehlow <[email protected]>
Quoted 7 lines
Quoted 4 lines
When gos internal linker is used, it uses hardcoded paths to the interpreter (dynamic linker). For
x86_64this hardcoded path is/lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path is/lib64/ld-linux-x86-64.so.2.Is this correct? The first path is the seme one of the second.
its a typo, Sadly we do differ in baselib naming convention on x86_64 ( without multilib )
compared to other distributions which are inherently multilib and use /lib64 OE instead uses
/lib when multilib is not enabled but lib64/ when multilib is enabled.
Quoted 52 lines
Jose
Quoted 35 lines
Most of the time, the internal linker is not used and binutils linker sets the correct path, but sometimes the internal linker is used and the resulting binary will not work on
x86_64.To ensure the path is always correct, pass it to the linker.
Signed-off-by Joerg Vehlow <[email protected]>--- meta/classes/go.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/classes/go.bbclass +2
-2@@ -1,4 +1,5 @@ inherit goarch +inherit linuxloader GO_PARALLEL_BUILD ?= "${@oe.utils.parallel_make_argument(d, '-p %d')}"@@ -44,7 +45,7 @@ GO_LINKMODE ?= "" GO_LINKMODE:class-nativesdk = "--linkmode=external" GO_LINKMODE:class-native = "--linkmode=external" GO_EXTRA_LDFLAGS ?= "" -GO_LDFLAGS ?= '-ldflags="${GO_RPATH} ${GO_LINKMODE} ${GO_EXTRA_LDFLAGS} -extldflags '${GO_EXTLDFLAGS}'"' +GO_LDFLAGS ?= '-ldflags="${GO_RPATH} ${GO_LINKMODE} -I ${@get_linuxloader(d)} ${GO_EXTRA_LDFLAGS} -extldflags '${GO_EXTLDFLAGS}'"' export GOBUILDFLAGS ?= "-v ${GO_LDFLAGS} -trimpath" export GOPATH_OMIT_IN_ACTIONID ?= "1" export GOPTESTBUILDFLAGS ?= "${GOBUILDFLAGS} -c" --2.25.1
Quoted 8 lines
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164219): https://lists.openembedded.org/g/openembedded-core/message/164219
Mute This Topic: https://lists.openembedded.org/mt/90393660/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=---
Best regards,José Quaresma
Hi,
Am 4/11/2022 um 6:04 PM schrieb Khem Raj:
Quoted 14 lines · Jose Quaresma
Quoted 13 lines
J?rg Vehlow <[email protected]> escreveu no dia segunda, 11/04/2022 à(s) 13:35:
Quoted 7 lines
From: Joerg Vehlow <[email protected]>
When gos internal linker is used, it uses hardcoded paths to the interpreter (dynamic linker). For
x86_64this hardcoded path is/lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path is/lib64/ld-linux-x86-64.so.2.
Quoted 7 lines
Quoted 1 line
Is this correct? The first path is the seme one of the second.
its a typo, Sadly we do differ in baselib naming convention on
x86_64( without multilib )
compared to other distributions which are inherently multilib and use /lib64 OE instead uses
/lib when multilib is not enabled but lib64/ when multilib is enabled.
Any comment on the content of the patch or do I have to send a v2 with a fixed commit message?
Thanks,
Joerg
Quoted 19 lines · J?rg Vehlow
Hi,
Am 4/11/2022 um 6:04 PM schrieb Khem Raj:
Quoted 16 lines · Jose Quaresma
Quoted 14 lines
J?rg Vehlow <[email protected]> escreveu no dia segunda, 11/04/2022 à(s) 13:35:
Quoted 7 lines
From: Joerg Vehlow <[email protected]>
When gos internal linker is used, it uses hardcoded paths to the interpreter (dynamic linker). For
x86_64this hardcoded path is/lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path is/lib64/ld-linux-x86-64.so.2.Is this correct? The first path is the seme one of the second.
Quoted 8 lines
Quoted 5 lines
its a typo, Sadly we do differ in baselib naming convention on
x86_64( without multilib )
compared to other distributions which are inherently multilib and use /lib64 OE instead uses
/lib when multilib is not enabled but lib64/ when multilib is enabled.Any comment on the content of the patch or do I have to send a v2 with a fixed commit message?
It merged:
https://git.yoctoproject.org/poky/commit/?id=460012e04a89e0b84fd5949c9a2229ef46e7a341
Cheers,
Richard