Skip to contentSkip to conversation

nfs-utils: nfsidmap.man: Fix section number

PATCH In review Salvatore Bonaccorso 2 participants 7 messages Apr 12, 2022 – Apr 19, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs-utils: nfsidmap.man: Fix section number

From: Ben Hutchings <[email protected]>

The nfsidmap manual page is supposed to be in section 8, but calls the .TH macro with a section argument of 5. This results in an incorrect header and causes debhelper (in Debian) to install it in the section 5 directory. Fix that.

[Salvatore Bonaccorso: Slightly modify commit message to mention that the Problem is found in Debian through installing the manpage via debhelper.]

---
 utils/nfsidmap/nfsidmap.man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/nfsidmap/nfsidmap.man +1 -1
index 2af16f3157ff..1911c41be6f9 100644
@@ -2,7 +2,7 @@
 .\"@(#)nfsidmap(8) - The NFS idmapper upcall program
 .\"
 .\" Copyright (C) 2010 Bryan Schumaker <[email protected]>
-.TH nfsidmap 5 "1 October 2010"
+.TH nfsidmap 8 "1 October 2010"
 .SH NAME
 nfsidmap \- The NFS idmapper upcall program
 .SH SYNOPSIS
Signature · 1 line
2.35.1
#1 lore raw

Hello,

On 4/12/22 3:00 AM, Salvatore Bonaccorso wrote:

My mailer was unable to process the attachment
Please in-line the patch and resend it.

steved.

#2 lore raw

Hi Steve,

Quoted 6 lines · Steve Dickson

Hello,

On 4/12/22 3:00 AM, Salvatore Bonaccorso wrote:

My mailer was unable to process the attachment
Please in-line the patch and resend it.

That is very strange, I used git send-email to submit it, and I do not see where it got mangled, as it is present as well in

https://lore.kernel.org/linux-nfs/[email protected]/

Any idea what happened?

Here it is again, inlined in this message.

Regards,
Salvatore

From da390ced58885b0ed80be3722d4d913909e7c543 Mon Sep 17 00:00:00 2001
From: Ben Hutchings <[email protected]>
Date: Mon, 14 Mar 2022 00:19:33 +0100
Subject: [PATCH] nfsidmap.man: Fix section number

The nfsidmap manual page is supposed to be in section 8, but calls the .TH macro with a section argument of 5. This results in an incorrect header and causes debhelper (in Debian) to install it in the section 5 directory. Fix that.

[Salvatore Bonaccorso: Slightly modify commit message to mention that the Problem is found in Debian through installing the manpage via debhelper]

---
 utils/nfsidmap/nfsidmap.man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/nfsidmap/nfsidmap.man +1 -1
index 2af16f3157ff..1911c41be6f9 100644
@@ -2,7 +2,7 @@
 .\"@(#)nfsidmap(8) - The NFS idmapper upcall program
 .\"
 .\" Copyright (C) 2010 Bryan Schumaker <[email protected]>
-.TH nfsidmap 5 "1 October 2010"
+.TH nfsidmap 8 "1 October 2010"
 .SH NAME
 nfsidmap \- The NFS idmapper upcall program
 .SH SYNOPSIS
Signature · 1 line
2.35.1
#3 lore raw

Hi Steve,

Quoted 56 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 6 lines · Steve Dickson

Hello,

On 4/12/22 3:00 AM, Salvatore Bonaccorso wrote:

My mailer was unable to process the attachment
Please in-line the patch and resend it.

That is very strange, I used git send-email to submit it, and I do not see where it got mangled, as it is present as well in

https://lore.kernel.org/linux-nfs/[email protected]/

Any idea what happened?

Here it is again, inlined in this message.

Regards,
Salvatore

From da390ced58885b0ed80be3722d4d913909e7c543 Mon Sep 17 00:00:00 2001
From: Ben Hutchings <[email protected]>
Date: Mon, 14 Mar 2022 00:19:33 +0100
Subject: [PATCH] nfsidmap.man: Fix section number

The nfsidmap manual page is supposed to be in section 8, but calls the .TH macro with a section argument of 5. This results in an incorrect header and causes debhelper (in Debian) to install it in the section 5 directory. Fix that.

[Salvatore Bonaccorso: Slightly modify commit message to mention that the Problem is found in Debian through installing the manpage via debhelper]

---
 utils/nfsidmap/nfsidmap.man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/nfsidmap/nfsidmap.man +1 -1
index 2af16f3157ff..1911c41be6f9 100644
@@ -2,7 +2,7 @@
 .\"@(#)nfsidmap(8) - The NFS idmapper upcall program
 .\"
 .\" Copyright (C) 2010 Bryan Schumaker <[email protected]>
-.TH nfsidmap 5 "1 October 2010"
+.TH nfsidmap 8 "1 October 2010"
 .SH NAME
 nfsidmap \- The NFS idmapper upcall program
 .SH SYNOPSIS
Signature · 1 line
2.35.1

Was this version now correctly processed by your mailer?

Regards,
Salvatore

#4 lore raw

Hey!

Sorry for the delay...

Quoted 53 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 50 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 6 lines · Steve Dickson

Hello,

On 4/12/22 3:00 AM, Salvatore Bonaccorso wrote:

My mailer was unable to process the attachment
Please in-line the patch and resend it.

That is very strange, I used git send-email to submit it, and I do not see where it got mangled, as it is present as well in

https://lore.kernel.org/linux-nfs/[email protected]/

Any idea what happened?

Here it is again, inlined in this message.

Regards,
Salvatore

From da390ced58885b0ed80be3722d4d913909e7c543 Mon Sep 17 00:00:00 2001
From: Ben Hutchings <[email protected]>
Date: Mon, 14 Mar 2022 00:19:33 +0100
Subject: [PATCH] nfsidmap.man: Fix section number

The nfsidmap manual page is supposed to be in section 8, but calls the .TH macro with a section argument of 5. This results in an incorrect header and causes debhelper (in Debian) to install it in the section 5 directory. Fix that.

[Salvatore Bonaccorso: Slightly modify commit message to mention that the Problem is found in Debian through installing the manpage via debhelper]

---
  utils/nfsidmap/nfsidmap.man | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
utils/nfsidmap/nfsidmap.man +0 -1
index 2af16f3157ff..1911c41be6f9 100644
@@ -2,7 +2,7 @@
  .\"@(#)nfsidmap(8) - The NFS idmapper upcall program
  .\"
  .\" Copyright (C) 2010 Bryan Schumaker <[email protected]>
-.TH nfsidmap 5 "1 October 2010"
Quoted 8 lines
Quoted 6 lines
utils/nfsidmap/nfsidmap.man +1 -0
+.TH nfsidmap 8 "1 October 2010"
  .SH NAME
  nfsidmap \- The NFS idmapper upcall program
  .SH SYNOPSIS
Signature · 1 line
2.35.1

Was this version now correctly processed by your mailer?

Yeah I got it... thanks... but...
Are you saying that this man page should be in chapter 5 or it is fact Debian installs into chapter 5?

In RHEL and Fedora we install it in chapter 8... If it belongs in a different chapter I have no problem changing it... I just need to know why.

steved.

steved.

#5 lore raw

Hi Steve,

Quoted 66 lines · Steve Dickson

Hey!

Sorry for the delay...

Quoted 53 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 50 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 6 lines · Steve Dickson

Hello,

On 4/12/22 3:00 AM, Salvatore Bonaccorso wrote:

My mailer was unable to process the attachment
Please in-line the patch and resend it.

That is very strange, I used git send-email to submit it, and I do not see where it got mangled, as it is present as well in

https://lore.kernel.org/linux-nfs/[email protected]/

Any idea what happened?

Here it is again, inlined in this message.

Regards,
Salvatore

From da390ced58885b0ed80be3722d4d913909e7c543 Mon Sep 17 00:00:00 2001
From: Ben Hutchings <[email protected]>
Date: Mon, 14 Mar 2022 00:19:33 +0100
Subject: [PATCH] nfsidmap.man: Fix section number

The nfsidmap manual page is supposed to be in section 8, but calls the .TH macro with a section argument of 5. This results in an incorrect header and causes debhelper (in Debian) to install it in the section 5 directory. Fix that.

[Salvatore Bonaccorso: Slightly modify commit message to mention that the Problem is found in Debian through installing the manpage via debhelper]

---
  utils/nfsidmap/nfsidmap.man | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
utils/nfsidmap/nfsidmap.man +0 -1
index 2af16f3157ff..1911c41be6f9 100644
@@ -2,7 +2,7 @@
  .\"@(#)nfsidmap(8) - The NFS idmapper upcall program
  .\"
  .\" Copyright (C) 2010 Bryan Schumaker <[email protected]>
-.TH nfsidmap 5 "1 October 2010"
Quoted 8 lines
Quoted 6 lines
utils/nfsidmap/nfsidmap.man +1 -0
+.TH nfsidmap 8 "1 October 2010"
  .SH NAME
  nfsidmap \- The NFS idmapper upcall program
  .SH SYNOPSIS
Signature · 1 line
2.35.1

Was this version now correctly processed by your mailer?

Quoted 7 lines

Yeah I got it... thanks... but...
Are you saying that this man page should be in chapter 5 or it is fact Debian installs into chapter 5?

In RHEL and Fedora we install it in chapter 8... If it belongs in a different chapter I have no problem changing it... I just need to know why.

Apologies, so this was apparently not very clear. That it belongs into section 8 is right. Debian installed it into the wrong section because the section in the manpage itself refers to 5. This is what the patch tries to inline, and fix the wrong argument to the .TH macro.

Because the manpage incorrectly calls the .TH macro with a section argument of 5 the debhelper program in Debian installs the manpage into section 5.

Does this clarifies?

Regards,
Salvatore

#6 lore raw
Quoted 82 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 66 lines · Steve Dickson

Hey!

Sorry for the delay...

Quoted 53 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 50 lines · Salvatore Bonaccorso

Hi Steve,

Quoted 6 lines · Steve Dickson

Hello,

On 4/12/22 3:00 AM, Salvatore Bonaccorso wrote:

My mailer was unable to process the attachment
Please in-line the patch and resend it.

That is very strange, I used git send-email to submit it, and I do not see where it got mangled, as it is present as well in

https://lore.kernel.org/linux-nfs/[email protected]/

Any idea what happened?

Here it is again, inlined in this message.

Regards,
Salvatore

From da390ced58885b0ed80be3722d4d913909e7c543 Mon Sep 17 00:00:00 2001
From: Ben Hutchings <[email protected]>
Date: Mon, 14 Mar 2022 00:19:33 +0100
Subject: [PATCH] nfsidmap.man: Fix section number

The nfsidmap manual page is supposed to be in section 8, but calls the .TH macro with a section argument of 5. This results in an incorrect header and causes debhelper (in Debian) to install it in the section 5 directory. Fix that.

[Salvatore Bonaccorso: Slightly modify commit message to mention that the Problem is found in Debian through installing the manpage via debhelper]

---
   utils/nfsidmap/nfsidmap.man | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
utils/nfsidmap/nfsidmap.man +0 -1
index 2af16f3157ff..1911c41be6f9 100644
@@ -2,7 +2,7 @@
   .\"@(#)nfsidmap(8) - The NFS idmapper upcall program
   .\"
   .\" Copyright (C) 2010 Bryan Schumaker <[email protected]>
-.TH nfsidmap 5 "1 October 2010"
Quoted 8 lines
Quoted 6 lines
utils/nfsidmap/nfsidmap.man +1 -0
+.TH nfsidmap 8 "1 October 2010"
   .SH NAME
   nfsidmap \- The NFS idmapper upcall program
   .SH SYNOPSIS
Signature · 1 line
2.35.1

Was this version now correctly processed by your mailer?

Quoted 7 lines

Yeah I got it... thanks... but...
Are you saying that this man page should be in chapter 5 or it is fact Debian installs into chapter 5?

In RHEL and Fedora we install it in chapter 8... If it belongs in a different chapter I have no problem changing it... I just need to know why.

Apologies, so this was apparently not very clear. That it belongs into section 8 is right. Debian installed it into the wrong section because the section in the manpage itself refers to 5. This is what the patch tries to inline, and fix the wrong argument to the .TH macro.

Quoted 5 lines

Because the manpage incorrectly calls the .TH macro with a section argument of 5 the debhelper program in Debian installs the manpage into section 5.

Does this clarifies?Yes it does... Thank you!

Committed... (re-tagged: nfs-utils-2-6-2-rc4)

steved.